From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="g42ijmI7" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D99D7AC; Mon, 4 Dec 2023 08:04:46 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B4FEVvg005446; Mon, 4 Dec 2023 16:04:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=7SyjEZYix8RBtB52xZQgB2+0lCKxgrfJUq97NfAQsHg=; b=g42ijmI7q87bYocyUZZz6GyVLgBjDsSTVl/xah26NDsRXq03zXLU3DqZViuo1cS0gzYP 900uS1MlfbvTHLmGMdSuwZQHUcvWXo1bOyu1Lgdxaw0qjUNV+KqZPxVjdQ/VXV2ZKMUV 9T5gOWST7Zc0lKinvjs60T6qjZa30FejhcmjsUF5SFpP1DJE/yCzP6AUmK1VaIAXvRs2 gjdjg2LcQEveES+nhcBZE3/hXj85xujlfbei6n3uAPLhQkeVJ5H5u4Ultf0jtJEzq4C1 vix+T16wDtjSFlWUVi8zCI++8ItvIYKDMSw0Y54bZhh+oFZh/JHsjNjablmKkPzsLQx9 cg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uqwbqmec6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Dec 2023 16:04:43 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B4G4goT021466 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Dec 2023 16:04:42 GMT Received: from [10.110.89.58] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 4 Dec 2023 08:04:39 -0800 Message-ID: Date: Mon, 4 Dec 2023 08:04:38 -0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver Content-Language: en-US To: Krzysztof Kozlowski , Tengfei Fan , , , , CC: , , , References: <20231130024046.25938-1-quic_tengfan@quicinc.com> <20231130024046.25938-3-quic_tengfan@quicinc.com> <1d2fbb36-9476-4f32-8bcd-33fd5dcbd6e4@kernel.org> <1b65f67a-8142-4690-af6e-4a0bf641b7be@kernel.org> From: Jeff Johnson In-Reply-To: <1b65f67a-8142-4690-af6e-4a0bf641b7be@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: QTtMnbm3_qEodrRL0BT35rbhPm5kbEM6 X-Proofpoint-GUID: QTtMnbm3_qEodrRL0BT35rbhPm5kbEM6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-04_15,2023-12-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 mlxlogscore=801 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312040122 On 12/3/2023 11:56 PM, Krzysztof Kozlowski wrote: > On 04/12/2023 02:57, Tengfei Fan wrote: >> >> >> 在 11/30/2023 7:57 PM, Krzysztof Kozlowski 写道: >>> On 30/11/2023 03:40, Tengfei Fan wrote: >>>> Add pinctrl driver for TLMM block found in SM4450 SoC. >>>> >>>> Reviewed-by: Bjorn Andersson >>>> Signed-off-by: Tengfei Fan >>>> --- >>>> drivers/pinctrl/qcom/Kconfig.msm | 8 + >>>> drivers/pinctrl/qcom/Makefile | 1 + >>>> drivers/pinctrl/qcom/pinctrl-sm4450.c | 1013 +++++++++++++++++++++++++ >>>> 3 files changed, 1022 insertions(+) >>>> create mode 100644 drivers/pinctrl/qcom/pinctrl-sm4450.c >>>> >>> >>> Hm, was this patch ever built? >>> >>> Best regards, >>> Krzysztof >>> >> This patch has been built before, I will check and compare if there are >> any errors and changes when I submitted this patch series. >> > > No, it wasn't built. I just tried - applied it and: > > pinctrl-sm4450.c:996:19: error: initialization of ‘int (*)(struct > platform_device *)’ from incompatible pointer type ‘void (*)(struct > platform_device *)’ [-Werror=incompatible-pointer-types] > 996 | .remove = msm_pinctrl_remove, > | ^~~~~~~~~~~~~~~~~~ > ../drivers/pinctrl/qcom/pinctrl-sm4450.c:996:19: note: (near > initialization for ‘sm4450_tlmm_driver.remove’) > > So you just sent a patch which was not even compiled. > > NAK. > > Best regards, > Krzysztof > The problem here is patch 2/4 incorrectly initializes .remove and patch 3/4 changes it to correctly use .remove_new. Bisection at patch 2 doesn't build. Those two patches should be squashed