linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "palash.kambar@oss.qualcomm.com" <palash.kambar@oss.qualcomm.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>
Cc: "quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
	"James.Bottomley@hansenpartnership.com"
	<James.Bottomley@hansenpartnership.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ebiggers@kernel.org" <ebiggers@kernel.org>,
	"peter.griffin@linaro.org" <peter.griffin@linaro.org>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"quic_cang@quicinc.com" <quic_cang@quicinc.com>
Subject: Re: [PATCH V1 2/2] ufs: ufs-qcom: Disable AHIT before SQ tail update to prevent race in MCQ mode
Date: Mon, 20 Oct 2025 06:53:06 +0000	[thread overview]
Message-ID: <e3fa13724a08bfaa764d57a3d223d201cd4d30c0.camel@mediatek.com> (raw)
In-Reply-To: <677b59f4-5732-43ad-83af-c670f6fb999d@oss.qualcomm.com>

On Sat, 2025-10-18 at 12:14 +0530, Palash Kambar wrote:
> Thanks for the feedback, Bart. However, I believe setting the runtime
> suspend delay to 5ms
>  might be overly aggressive for the system and may have below side
> effects:
> 
> 1. Short autosuspend timeouts can cause the UFS device to enter low-
> power states even
> during brief idle periods. This results in resume latency,
> introducing delays when the
> device needs to wake up for subsequent operations.
> 2. Frequent suspend and resume cycles may disrupt data flow,
> particularly in workloads
> with bursty or intermittent I/O, leading to performance degradation.
> 3. When the autosuspend timer is overly aggressive, the UFS device
> may repeatedly
> transition between active and low-power states. These transitions
> themselves consume power,
> and if they occur too often, they can offset or even negate the
> intended power savings.
> 
> Please let me know your thoughts on this.
> 
> Regards,
> 
> 
> Palash K
> 

Hi Palash,

Maybe disabling AH8 and enabling both UFSHCD_CAP_CLK_SCALING
and UFSHCD_CAP_HIBERN8_WITH_CLK_GATING is sufficient?

Thanks
Peter

> 

      reply	other threads:[~2025-10-20  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  6:04 [PATCH V1 0/2] Address race condition in MCQ mode and enhance palash.kambar
2025-10-14  6:04 ` [PATCH V1 1/2] ufs: core:Add vendor-specific callbacks and update setup_xfer_req interface palash.kambar
2025-10-14 16:10   ` Bart Van Assche
2025-10-18  6:49     ` Palash Kambar
2025-10-14  6:04 ` [PATCH V1 2/2] ufs: ufs-qcom: Disable AHIT before SQ tail update to prevent race in MCQ mode palash.kambar
2025-10-14 16:18   ` Bart Van Assche
     [not found]     ` <CAGbPq5dhUXr59U_J3W4haNHughkaiXpnc4kAZWXB0SjPdFQMhg@mail.gmail.com>
2025-10-15 15:45       ` Bart Van Assche
2025-10-18  6:44         ` Palash Kambar
2025-10-20  6:53           ` Peter Wang (王信友) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3fa13724a08bfaa764d57a3d223d201cd4d30c0.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=ebiggers@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    --cc=palash.kambar@oss.qualcomm.com \
    --cc=peter.griffin@linaro.org \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).