From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E01C43219 for ; Fri, 25 Nov 2022 14:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbiKYOzv (ORCPT ); Fri, 25 Nov 2022 09:55:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbiKYOzt (ORCPT ); Fri, 25 Nov 2022 09:55:49 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F214931DC6 for ; Fri, 25 Nov 2022 06:55:47 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id bp15so7215580lfb.13 for ; Fri, 25 Nov 2022 06:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VxBpBwNM8lbqAqevdDFL53IYXQgfoQq8ag1aBuLSLxI=; b=TRCfVHMriA0CRg1R8NCh5cJ6Kcsxo2SdWk5x5g3g/XWOEKJlPLicUtfS1J7Bcd5YZG DFH3R6AZR/m7hdiWOUnqSi+HiPeqJl+HV9udEUISUqryFHQXskWEeTyAYkeZPuiPbfqy W6buRZUHOcoDm/7MwEk0wM6XtFWgubux5r7uvwAcfGV13iusfhgk3Qfuw29DjVbsrrZt lYfjYm5CAf5G0MwhdY7KnXsgPsl93/LtXed9lzQdxQ7hkcrzOjuX4k6kNHn16JAY7USP oo/wHqPLutA/guNs3AMKX3tGSrjmMu7x+bqz7hf/fLlVWDBqoJfza6J/XOKIgzpVaAke arjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VxBpBwNM8lbqAqevdDFL53IYXQgfoQq8ag1aBuLSLxI=; b=Fz6oi+Yz/gfzjZ2A6tZEPPqalBiCVFKygeH9y0pgYS2NXF2jc9Y/wnkMdTUXQolNZ9 UiQHHLajzDqhPu/b4+Sl2BuUh9SbJ4YU0mv+SHZsgYSbozrzvMUOufdnnlvaz6jACT9W yOACuY4GH1Uap7v1/3Cd9hHy0XxIjfNxr7OUb4HsD6foE1LCkFAwDcLJz0wEwctdnZ5m 3Wp6A89mCywqD5tXIO0xPe2mFJiZ50yHZVqmtOfUxBytuvb37F0hMmIhCmEhnU4eRdp/ qrZlIleTGx+FYQNmWDhFWdNYOodw/bWecwRxEsRHBeTkzSTzzUqzg5JYrjde5TLM2XdG ZlMQ== X-Gm-Message-State: ANoB5pmSx/4MV9+2pNh9KehZiMa98VYOF/1D5+8PnlpNgxPLnmf6D8xa oB6CmFZBW0tThIb9G+1T9gjePQ== X-Google-Smtp-Source: AA0mqf7Gm+58Go9sKrIMFxXvl8KJRz9zByM5cvhEqK0ccTyKySFxTT2TXz/HJuSiyQq1awCnhbwoyg== X-Received: by 2002:a05:6512:324f:b0:4b4:f3c5:f195 with SMTP id c15-20020a056512324f00b004b4f3c5f195mr3290518lfr.516.1669388146359; Fri, 25 Nov 2022 06:55:46 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id k2-20020a2ea282000000b0026c2baa72d4sm378848lja.27.2022.11.25.06.55.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 06:55:45 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 15:55:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] ARM: dts: qcom: align LED node names with dtschema Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> <20221125144209.477328-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221125144209.477328-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25.11.2022 15:42, Krzysztof Kozlowski wrote: > The node names should be generic and DT schema expects certain pattern: > > qcom-ipq4018-ap120c-ac.dtb: leds: 'wlan2g', 'wlan5g' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 6 +++--- > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts > index cf7da1ab177c..1b27edce9d4f 100644 > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts > @@ -9,7 +9,7 @@ / { > leds { > compatible = "gpio-leds"; > > - power { > + led-power { > label = "ap120c-ac:green:power"; > function = LED_FUNCTION_POWER; > color = ; > @@ -17,14 +17,14 @@ power { > default-state = "on"; > }; > > - wlan { > + led-wlan { > label = "ap120c-ac:green:wlan"; > function = LED_FUNCTION_WLAN; > color = ; > gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; > }; > > - support { > + led-support { > label = "ap120c-ac:green:support"; > color = ; > gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>; > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts > index c4f89b712fd9..a707057c887d 100644 > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts > @@ -7,7 +7,7 @@ / { > leds { > compatible = "gpio-leds"; > > - status: status { > + status: led-status { > label = "ap120c-ac:blue:status"; > function = LED_FUNCTION_STATUS; > color = ; > @@ -15,7 +15,7 @@ status: status { > default-state = "keep"; > }; > > - wlan2g { > + led-wlan2g { > label = "ap120c-ac:green:wlan2g"; > function = LED_FUNCTION_WLAN; > color = ; > @@ -23,7 +23,7 @@ wlan2g { > linux,default-trigger = "phy0tpt"; > }; > > - wlan5g { > + led-wlan5g { > label = "ap120c-ac:red:wlan5g"; > function = LED_FUNCTION_WLAN; > color = ;