From: Can Guo <cang@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write
Date: Fri, 20 Dec 2019 09:30:13 +0800 [thread overview]
Message-ID: <e489ea10809772a847545fe1ee53215b@codeaurora.org> (raw)
In-Reply-To: <20191219150433.2785427-5-vkoul@kernel.org>
On 2019-12-19 23:04, Vinod Koul wrote:
> We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init()
> before invoking qcom_qmp_phy_configure() so remove the duplicate write.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
> b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 80304b7cd895..309ef15e46b0 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl
> msm8998_usb3_pcs_tbl[] = {
> };
>
> static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = {
> - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),
prev parent reply other threads:[~2019-12-20 1:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:04 [PATCH 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-19 15:04 ` [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Vinod Koul
2019-12-19 15:29 ` Jeffrey Hugo
2019-12-19 15:40 ` Vinod Koul
2019-12-20 2:08 ` Bjorn Andersson
2019-12-20 4:21 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 2/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-19 15:30 ` Jeffrey Hugo
2019-12-20 0:44 ` cang
2019-12-20 4:22 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 0:22 ` cang
2019-12-20 0:49 ` cang
2019-12-20 4:24 ` Vinod Koul
2019-12-20 6:00 ` Can Guo
2019-12-20 7:10 ` Vinod Koul
2019-12-20 7:41 ` Can Guo
2019-12-20 7:53 ` Vinod Koul
2019-12-23 9:00 ` Manu Gautam
2019-12-23 9:02 ` Manu Gautam
2019-12-19 15:04 ` [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 1:30 ` Can Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e489ea10809772a847545fe1ee53215b@codeaurora.org \
--to=cang@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox