Re: [PATCH 2/3] media: qcom: camss: add support for SM6150 camss

[Wenmeng Liu <quic_wenmliu@qualcomm.com>]

On 10/16/2025 6:29 PM, Bryan O'Donoghue wrote:
> On 16/10/2025 11:22, Wenmeng Liu wrote:
>> The camera subsystem for SM6150 which is based on Spectra 230.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> 
> Your commit log needs more detail.
> 
> - VFE17x version what ?
> - CSID version .. gen2 so CSID 480 is it ?
> - CSIPHY process node would be nice
> 
> 

Yes, will add more detail in next version.
For SM6150, vfe and csid version is 170(vfe170, csid170),
csiphy version is csiphy-v2.0.

>> ---
>>   .../platform/qcom/camss/camss-csiphy-3ph-1-0.c     |   2 +
>>   drivers/media/platform/qcom/camss/camss-vfe.c      |   2 +
>>   drivers/media/platform/qcom/camss/camss.c          | 186 +++++++++++ 
>> ++++++++++
>>   drivers/media/platform/qcom/camss/camss.h          |   1 +
>>   4 files changed, 191 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c 
>> b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> index 
>> a229ba04b158739ddfe4076bdd28167a309f13ea..7bc524a9c4bbe3a316e366868e9d636e58d5956a 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> @@ -908,6 +908,7 @@ static bool csiphy_is_gen2(u32 version)
>>       switch (version) {
>>       case CAMSS_2290:
>> +    case CAMSS_6150:
>>       case CAMSS_7280:
>>       case CAMSS_8250:
>>       case CAMSS_8280XP:
>> @@ -996,6 +997,7 @@ static int csiphy_init(struct csiphy_device *csiphy)
>>           regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
>>           break;
>>       case CAMSS_2290:
>> +    case CAMSS_6150:
>>           regs->lane_regs = &lane_regs_qcm2290[0];
> 
> You don't need to specify the array index for that.
> 

Here I have only added "case CAMSS_6150:", then do I need to modify the 
part of "&lane_regs_qcm2290[0]"?

>>           regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290);
>>           break;

Best regards,
Wenmeng

B