From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5346CC636CC for ; Mon, 13 Feb 2023 11:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbjBMLil (ORCPT ); Mon, 13 Feb 2023 06:38:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjBMLii (ORCPT ); Mon, 13 Feb 2023 06:38:38 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AA747D9D for ; Mon, 13 Feb 2023 03:38:37 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id sa10so31027393ejc.9 for ; Mon, 13 Feb 2023 03:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r8vF+glCGL/TIHZAeFd6umlQYUbpkh549EdL910Nq6g=; b=pbzrgTDa/e/4xlg4PGDTCGTOAIrar5NNyj1XRDqVj2OW2kFztgpd8dfuWPW2mMUB5/ Kam3Hmw6s1u9RG7HZC8au2k//hLg4JZ+MdamafPtasioKUV8usFJ+bR+VDvQZSuTDc8c DTQCRhiuXbjC6otr2LbJS9OWT5S7jNCs+X2eCIzRzyhdOnPm5rzYZBroC5YSQGpCQzMR KQYXwL0XuYBbZiHOnjZkRocRjs5WQnddxMVHQaJtbPZUzz2lnE000ZBWOg04wz6tXkAb rTgkgL0CfKG2SfKyeioa/MzemDIdfpFlwBjHMCs5qdhfbukBEnQD8tHbuD8DkDTKEUgi YIFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r8vF+glCGL/TIHZAeFd6umlQYUbpkh549EdL910Nq6g=; b=bvpnkXI/rlso6yqttAVaDiiZz1UOYi1y0Z984dLnmornumebazZK+63KjZlxms+vI4 GjYOn+0OmKk1x2QKVx6SngQOKX1Hrv0cpoxNPKwilL6XfKpSHCpz9JzUDEP7lwmeYV3l W/KL+jPCYw2j6Zje//G0guL7T21zNOyZALpf4rJo4D0phgDwVPrX06nUDljVt87m6joC ePrUFTm3WMZvnBSnGBzCk+/HPErlkBngaDo0Ha4IsFI/Q0hR1o8+2XZaA1BDj0hF2GFa +606CcF8HIs07KQtSCmCuwgDPq81rUDZVWXfcfcAhHev/yagY2i0jAxIH75vt6PHvHHB KdRA== X-Gm-Message-State: AO0yUKUVunmZIyzrP7w4cf+cF0IVgIkG9BOoX4kVve88bcOUlbK54eyM t1y1XQoP0I3/rraoZPO5hT2lfA== X-Google-Smtp-Source: AK7set8vw+ntyrLewHqJOjyeT2fk0N1lSDwSYCQMzlHCi7qiYZ98Cc2LOazfM4b9+yhsYZF/cbKmtA== X-Received: by 2002:a17:906:9b96:b0:8af:370a:c1f8 with SMTP id dd22-20020a1709069b9600b008af370ac1f8mr20437423ejc.23.1676288315728; Mon, 13 Feb 2023 03:38:35 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id n8-20020a1709065e0800b0087fa83790d8sm6755316eju.13.2023.02.13.03.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 03:38:35 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 13:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 05/10] drm/msm/dpu: Allow variable SSPP/INTF_BLK size Content-Language: en-GB To: Marijn Suijten , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Robert Foss , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230211122656.1479141-1-konrad.dybcio@linaro.org> <20230211122656.1479141-6-konrad.dybcio@linaro.org> <20230213111220.ietr4aro6xu4emtu@SoMainline.org> From: Dmitry Baryshkov In-Reply-To: <20230213111220.ietr4aro6xu4emtu@SoMainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13/02/2023 13:12, Marijn Suijten wrote: > On 2023-02-11 13:26:51, Konrad Dybcio wrote: >> These blocks are of variable length on different SoCs. Set the >> correct values where I was able to retrieve it from downstream >> DTs and leave the old defaults (0x1c8 for sspp and 0x280 for >> intf) otherwise. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 242 +++++++++--------- >> 1 file changed, 121 insertions(+), 121 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> index 802050118345..d9ef1e133c1e 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > [..] >> @@ -1848,10 +1848,10 @@ static struct dpu_dsc_cfg sm8150_dsc[] = { >> /************************************************************* >> * INTF sub blocks config >> *************************************************************/ >> -#define INTF_BLK(_name, _id, _base, _type, _ctrl_id, _progfetch, _features, _reg, _underrun_bit, _vsync_bit) \ >> +#define INTF_BLK(_name, _id, _base, _len, _type, _ctrl_id, _progfetch, _features, _reg, _underrun_bit, _vsync_bit) \ > > Dmitry and I discussed in #freedreno to instead add the INTF_BLK_DSI_TE > macro that accounts for the INTF TE registers using this higher register > area, as well as an extended signature to configure extra interrupts. Yes, that's still the plan. It's slightly painful that we are touching this are simultaneously. > > (Besides, I think the len is currently only used for snapshot dumping > and no validation for out-of-blk reads/writes) Yes. Because in most of the cases non-existing registers seem to be RAZ/WI. > >> {\ >> .name = _name, .id = _id, \ >> - .base = _base, .len = 0x280, \ >> + .base = _base, .len = _len, \ >> .features = _features, \ >> .type = _type, \ >> .controller_id = _ctrl_id, \ > [..] > > - Marijn -- With best wishes Dmitry