linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
@ 2025-08-13 16:14 Wolfram Sang
  2025-08-13 16:14 ` [PATCH 02/21] clk: " Wolfram Sang
                   ` (9 more replies)
  0 siblings, 10 replies; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, Wolfram Sang, Adrian Hunter, Alexandre Belloni,
	Alexandre Torgue, Alim Akhtar, Andrea della Porta,
	Andreas Färber, Andrzej Hajda, Andy Shevchenko, Andy Yan,
	Avi Fishman, Bartosz Golaszewski, Benjamin Fair, Bjorn Andersson,
	Chen-Yu Tsai, Daniel Lezcano, David Airlie, David Lechner,
	Dmitry Torokhov, Drew Fustini, dri-devel, Fabio Estevam,
	Fabrice Gasnier, Fu Wei, Guo Ren, Hans Verkuil,
	Heiko Stübner, imx, Iwona Winiarska, Jaroslav Kysela,
	Jassi Brar, Jernej Skrabec, Jerome Brunet, Jonas Karlman,
	Jonathan Cameron, Kevin Hilman, Kishon Vijay Abraham I,
	Konrad Dybcio, Krzysztof Kozlowski, Laurent Pinchart, Lee Jones,
	Liam Girdwood, Linus Walleij, linux-actions, linux-amlogic,
	linux-arm-kernel, linux-arm-msm, linux-clk, linux-gpio, linux-iio,
	linux-input, linux-media, linux-mmc, linux-phy, linux-pm,
	linuxppc-dev, linux-pwm, linux-riscv, linux-rockchip, linux-rtc,
	linux-samsung-soc, linux-sound, linux-spi, linux-stm32,
	linux-sunxi, Liu Ying, Lukasz Luba, Maarten Lankhorst,
	Manivannan Sadhasivam, Martin Blumenstingl, Mauro Carvalho Chehab,
	Maxime Coquelin, Maxime Ripard, Michael Turquette, Miquel Raynal,
	Nancy Yuen, Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick, Vinod Koul,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui

While working on a driver using regmap with MMIO, I wondered if I need
to set 'fast_io' in the config. Turned out I don't need to, so I added
documentation for it with commit ffc72771ff6e ("regmap: Annotate that
MMIO implies fast IO").

This series fixes the existing users in the tree which needlessly set
the flag. They have been found using this coccinelle script:

===

@ match @
expression dev, clk, regs;
identifier config;
@@

(
	regmap_init_mmio(dev, regs, &config)
|
	devm_regmap_init_mmio(dev, regs, &config)
|
	regmap_init_mmio_clk(dev, clk, regs, &config)
|
	devm_regmap_init_mmio_clk(dev, clk, regs, &config)
)

@ fix depends on match @
identifier match.config;
@@

	struct regmap_config config = {
-	.fast_io = true,
	};

===

It misses occasions where 'config' is an expression and not an
identifier. These are rare, though, I can fix them manually later. The
advantage of this approach is that it produces no false positives to the
best of my knowledge.

Please apply individually per subsystem. There are no dependencies and
buildbot is happy. Patches are based on 6.17-rc1

Happy hacking,

   Wolfram


Wolfram Sang (21):
  bus: remove unneeded 'fast_io' parameter in regmap_config
  clk: remove unneeded 'fast_io' parameter in regmap_config
  gpio: remove unneeded 'fast_io' parameter in regmap_config
  drm: remove unneeded 'fast_io' parameter in regmap_config
  iio: remove unneeded 'fast_io' parameter in regmap_config
  Input: remove unneeded 'fast_io' parameter in regmap_config
  mailbox: remove unneeded 'fast_io' parameter in regmap_config
  media: remove unneeded 'fast_io' parameter in regmap_config
  mfd: remove unneeded 'fast_io' parameter in regmap_config
  mmc: remove unneeded 'fast_io' parameter in regmap_config
  peci: remove unneeded 'fast_io' parameter in regmap_config
  phy: remove unneeded 'fast_io' parameter in regmap_config
  pinctrl: remove unneeded 'fast_io' parameter in regmap_config
  pmdomain: remove unneeded 'fast_io' parameter in regmap_config
  regulator: remove unneeded 'fast_io' parameter in regmap_config
  reset: remove unneeded 'fast_io' parameter in regmap_config
  rtc: remove unneeded 'fast_io' parameter in regmap_config
  soc: remove unneeded 'fast_io' parameter in regmap_config
  spi: remove unneeded 'fast_io' parameter in regmap_config
  thermal: remove unneeded 'fast_io' parameter in regmap_config
  ASoC: remove unneeded 'fast_io' parameter in regmap_config

 drivers/bus/bt1-apb.c                             | 1 -
 drivers/clk/actions/owl-common.c                  | 1 -
 drivers/clk/clk-axm5516.c                         | 1 -
 drivers/clk/nxp/clk-lpc32xx.c                     | 1 -
 drivers/clk/qcom/a53-pll.c                        | 1 -
 drivers/clk/qcom/a7-pll.c                         | 1 -
 drivers/clk/qcom/apss-ipq-pll.c                   | 1 -
 drivers/clk/qcom/clk-cbf-8996.c                   | 1 -
 drivers/clk/qcom/clk-cpu-8996.c                   | 1 -
 drivers/clk/qcom/hfpll.c                          | 1 -
 drivers/clk/qcom/ipq-cmn-pll.c                    | 1 -
 drivers/clk/thead/clk-th1520-ap.c                 | 1 -
 drivers/gpio/gpio-mvebu.c                         | 1 -
 drivers/gpio/gpio-sifive.c                        | 1 -
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c    | 1 -
 drivers/gpu/drm/imx/dc/dc-cf.c                    | 1 -
 drivers/gpu/drm/imx/dc/dc-de.c                    | 1 -
 drivers/gpu/drm/imx/dc/dc-ed.c                    | 2 --
 drivers/gpu/drm/imx/dc/dc-fg.c                    | 1 -
 drivers/gpu/drm/imx/dc/dc-fl.c                    | 1 -
 drivers/gpu/drm/imx/dc/dc-fw.c                    | 2 --
 drivers/gpu/drm/imx/dc/dc-ic.c                    | 1 -
 drivers/gpu/drm/imx/dc/dc-lb.c                    | 2 --
 drivers/gpu/drm/imx/dc/dc-tc.c                    | 1 -
 drivers/gpu/drm/imx/ipuv3/imx-tve.c               | 2 --
 drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c  | 1 -
 drivers/iio/adc/sun4i-gpadc-iio.c                 | 1 -
 drivers/input/touchscreen/fsl-imx25-tcq.c         | 1 -
 drivers/mailbox/qcom-apcs-ipc-mailbox.c           | 1 -
 drivers/media/cec/platform/stm32/stm32-cec.c      | 1 -
 drivers/mfd/exynos-lpass.c                        | 1 -
 drivers/mfd/fsl-imx25-tsadc.c                     | 1 -
 drivers/mfd/stm32-lptimer.c                       | 1 -
 drivers/mfd/sun4i-gpadc.c                         | 1 -
 drivers/mmc/host/sdhci_am654.c                    | 1 -
 drivers/peci/controller/peci-npcm.c               | 1 -
 drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 1 -
 drivers/phy/rockchip/phy-rockchip-usbdp.c         | 1 -
 drivers/phy/ti/phy-am654-serdes.c                 | 1 -
 drivers/phy/ti/phy-j721e-wiz.c                    | 1 -
 drivers/pinctrl/pinctrl-rp1.c                     | 1 -
 drivers/pmdomain/imx/gpc.c                        | 1 -
 drivers/regulator/qcom-refgen-regulator.c         | 1 -
 drivers/reset/reset-intel-gw.c                    | 1 -
 drivers/reset/reset-qcom-pdc.c                    | 1 -
 drivers/reset/reset-th1520.c                      | 1 -
 drivers/rtc/rtc-meson.c                           | 1 -
 drivers/soc/qcom/llcc-qcom.c                      | 1 -
 drivers/soc/qcom/ramp_controller.c                | 1 -
 drivers/spi/spi-altera-platform.c                 | 1 -
 drivers/thermal/armada_thermal.c                  | 1 -
 drivers/thermal/sun8i_thermal.c                   | 1 -
 sound/soc/fsl/fsl_sai.c                           | 1 -
 53 files changed, 57 deletions(-)

-- 
2.47.2


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 02/21] clk: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
@ 2025-08-13 16:14 ` Wolfram Sang
  2025-08-21 21:46   ` Brian Masney
  2025-08-13 16:14 ` [PATCH 07/21] mailbox: " Wolfram Sang
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, Wolfram Sang, Michael Turquette, Stephen Boyd,
	Andreas Färber, Manivannan Sadhasivam, Vladimir Zapolskiy,
	Piotr Wojtaszczyk, Bjorn Andersson, Drew Fustini, Guo Ren, Fu Wei,
	linux-clk, linux-arm-kernel, linux-actions, linux-arm-msm,
	linux-riscv

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/clk/actions/owl-common.c  | 1 -
 drivers/clk/clk-axm5516.c         | 1 -
 drivers/clk/nxp/clk-lpc32xx.c     | 1 -
 drivers/clk/qcom/a53-pll.c        | 1 -
 drivers/clk/qcom/a7-pll.c         | 1 -
 drivers/clk/qcom/apss-ipq-pll.c   | 1 -
 drivers/clk/qcom/clk-cbf-8996.c   | 1 -
 drivers/clk/qcom/clk-cpu-8996.c   | 1 -
 drivers/clk/qcom/hfpll.c          | 1 -
 drivers/clk/qcom/ipq-cmn-pll.c    | 1 -
 drivers/clk/thead/clk-th1520-ap.c | 1 -
 11 files changed, 11 deletions(-)

diff --git a/drivers/clk/actions/owl-common.c b/drivers/clk/actions/owl-common.c
index c62024b7c737..b3dded204dc5 100644
--- a/drivers/clk/actions/owl-common.c
+++ b/drivers/clk/actions/owl-common.c
@@ -18,7 +18,6 @@ static const struct regmap_config owl_regmap_config = {
 	.reg_stride	= 4,
 	.val_bits	= 32,
 	.max_register	= 0x00cc,
-	.fast_io	= true,
 };
 
 static void owl_clk_set_regmap(const struct owl_clk_desc *desc,
diff --git a/drivers/clk/clk-axm5516.c b/drivers/clk/clk-axm5516.c
index 4a3462ee8f3e..3823383f3fa6 100644
--- a/drivers/clk/clk-axm5516.c
+++ b/drivers/clk/clk-axm5516.c
@@ -529,7 +529,6 @@ static const struct regmap_config axmclk_regmap_config = {
 	.reg_stride	= 4,
 	.val_bits	= 32,
 	.max_register	= 0x1fffc,
-	.fast_io	= true,
 };
 
 static const struct of_device_id axmclk_match_table[] = {
diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index e00f270bc6aa..96a1a527b380 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -68,7 +68,6 @@ static const struct regmap_config lpc32xx_scb_regmap_config = {
 	.reg_stride = 4,
 	.val_format_endian = REGMAP_ENDIAN_LITTLE,
 	.max_register = 0x114,
-	.fast_io = true,
 };
 
 static struct regmap *clk_regmap;
diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
index f43d455ab4b8..724a642311e5 100644
--- a/drivers/clk/qcom/a53-pll.c
+++ b/drivers/clk/qcom/a53-pll.c
@@ -33,7 +33,6 @@ static const struct regmap_config a53pll_regmap_config = {
 	.reg_stride		= 4,
 	.val_bits		= 32,
 	.max_register		= 0x40,
-	.fast_io		= true,
 };
 
 static struct pll_freq_tbl *qcom_a53pll_get_freq_tbl(struct device *dev)
diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
index c4a53e5db229..f95aefc43119 100644
--- a/drivers/clk/qcom/a7-pll.c
+++ b/drivers/clk/qcom/a7-pll.c
@@ -50,7 +50,6 @@ static const struct regmap_config a7pll_regmap_config = {
 	.reg_stride		= 4,
 	.val_bits		= 32,
 	.max_register		= 0x1000,
-	.fast_io		= true,
 };
 
 static int qcom_a7pll_probe(struct platform_device *pdev)
diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
index d6c1aea7e9e1..3a8987fe7008 100644
--- a/drivers/clk/qcom/apss-ipq-pll.c
+++ b/drivers/clk/qcom/apss-ipq-pll.c
@@ -169,7 +169,6 @@ static const struct regmap_config ipq_pll_regmap_config = {
 	.reg_stride		= 4,
 	.val_bits		= 32,
 	.max_register		= 0x40,
-	.fast_io		= true,
 };
 
 static int apss_ipq_pll_probe(struct platform_device *pdev)
diff --git a/drivers/clk/qcom/clk-cbf-8996.c b/drivers/clk/qcom/clk-cbf-8996.c
index ce4efcd995ea..0b40ed601f9a 100644
--- a/drivers/clk/qcom/clk-cbf-8996.c
+++ b/drivers/clk/qcom/clk-cbf-8996.c
@@ -212,7 +212,6 @@ static const struct regmap_config cbf_msm8996_regmap_config = {
 	.reg_stride		= 4,
 	.val_bits		= 32,
 	.max_register		= 0x10000,
-	.fast_io		= true,
 	.val_format_endian	= REGMAP_ENDIAN_LITTLE,
 };
 
diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
index 72689448a653..21d13c0841ed 100644
--- a/drivers/clk/qcom/clk-cpu-8996.c
+++ b/drivers/clk/qcom/clk-cpu-8996.c
@@ -411,7 +411,6 @@ static const struct regmap_config cpu_msm8996_regmap_config = {
 	.reg_stride		= 4,
 	.val_bits		= 32,
 	.max_register		= 0x80210,
-	.fast_io		= true,
 	.val_format_endian	= REGMAP_ENDIAN_LITTLE,
 };
 
diff --git a/drivers/clk/qcom/hfpll.c b/drivers/clk/qcom/hfpll.c
index b0b0cb074b4a..385964196185 100644
--- a/drivers/clk/qcom/hfpll.c
+++ b/drivers/clk/qcom/hfpll.c
@@ -99,7 +99,6 @@ static const struct regmap_config hfpll_regmap_config = {
 	.reg_stride	= 4,
 	.val_bits	= 32,
 	.max_register	= 0x30,
-	.fast_io	= true,
 };
 
 static int qcom_hfpll_probe(struct platform_device *pdev)
diff --git a/drivers/clk/qcom/ipq-cmn-pll.c b/drivers/clk/qcom/ipq-cmn-pll.c
index b3d7169c63e5..dafbf5732048 100644
--- a/drivers/clk/qcom/ipq-cmn-pll.c
+++ b/drivers/clk/qcom/ipq-cmn-pll.c
@@ -108,7 +108,6 @@ static const struct regmap_config ipq_cmn_pll_regmap_config = {
 	.reg_stride = 4,
 	.val_bits = 32,
 	.max_register = 0x7fc,
-	.fast_io = true,
 };
 
 static const struct cmn_pll_fixed_output_clk ipq5018_output_clks[] = {
diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c
index cf1bba58f641..cff4f014bddb 100644
--- a/drivers/clk/thead/clk-th1520-ap.c
+++ b/drivers/clk/thead/clk-th1520-ap.c
@@ -1056,7 +1056,6 @@ static const struct regmap_config th1520_clk_regmap_config = {
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,
-	.fast_io = true,
 };
 
 struct th1520_plat_data {
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 07/21] mailbox: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
  2025-08-13 16:14 ` [PATCH 02/21] clk: " Wolfram Sang
@ 2025-08-13 16:14 ` Wolfram Sang
  2025-08-13 16:15 ` [PATCH 15/21] regulator: " Wolfram Sang
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:14 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Wolfram Sang, Jassi Brar, linux-arm-msm

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 8b24ec0fa191..d3a8f6b4a03b 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -58,7 +58,6 @@ static const struct regmap_config apcs_regmap_config = {
 	.reg_stride = 4,
 	.val_bits = 32,
 	.max_register = 0x1008,
-	.fast_io = true,
 };
 
 static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data)
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 15/21] regulator: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
  2025-08-13 16:14 ` [PATCH 02/21] clk: " Wolfram Sang
  2025-08-13 16:14 ` [PATCH 07/21] mailbox: " Wolfram Sang
@ 2025-08-13 16:15 ` Wolfram Sang
  2025-08-13 16:15 ` [PATCH 16/21] reset: " Wolfram Sang
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:15 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Wolfram Sang, Liam Girdwood, linux-arm-msm

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/regulator/qcom-refgen-regulator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/qcom-refgen-regulator.c b/drivers/regulator/qcom-refgen-regulator.c
index cfa72ce85bc8..299ac3c8c3bc 100644
--- a/drivers/regulator/qcom-refgen-regulator.c
+++ b/drivers/regulator/qcom-refgen-regulator.c
@@ -94,7 +94,6 @@ static const struct regmap_config qcom_refgen_regmap_config = {
 	.reg_bits = 32,
 	.reg_stride = 4,
 	.val_bits = 32,
-	.fast_io = true,
 };
 
 static int qcom_refgen_probe(struct platform_device *pdev)
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 16/21] reset: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (2 preceding siblings ...)
  2025-08-13 16:15 ` [PATCH 15/21] regulator: " Wolfram Sang
@ 2025-08-13 16:15 ` Wolfram Sang
  2025-08-13 18:28   ` Drew Fustini
  2025-08-14 10:56   ` Philipp Zabel
  2025-08-13 16:15 ` [PATCH 18/21] soc: " Wolfram Sang
                   ` (5 subsequent siblings)
  9 siblings, 2 replies; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, Wolfram Sang, Philipp Zabel, Drew Fustini, Guo Ren,
	Fu Wei, linux-arm-msm, linux-riscv

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/reset/reset-intel-gw.c | 1 -
 drivers/reset/reset-qcom-pdc.c | 1 -
 drivers/reset/reset-th1520.c   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/reset/reset-intel-gw.c b/drivers/reset/reset-intel-gw.c
index a5a01388ae7f..a5ce3350cb5e 100644
--- a/drivers/reset/reset-intel-gw.c
+++ b/drivers/reset/reset-intel-gw.c
@@ -40,7 +40,6 @@ static const struct regmap_config intel_rcu_regmap_config = {
 	.reg_bits =	32,
 	.reg_stride =	4,
 	.val_bits =	32,
-	.fast_io =	true,
 };
 
 /*
diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c
index dce1fc1a68ad..ae2b5aba7a59 100644
--- a/drivers/reset/reset-qcom-pdc.c
+++ b/drivers/reset/reset-qcom-pdc.c
@@ -36,7 +36,6 @@ static const struct regmap_config pdc_regmap_config = {
 	.reg_stride	= 4,
 	.val_bits	= 32,
 	.max_register	= 0x20000,
-	.fast_io	= true,
 };
 
 static const struct qcom_pdc_reset_map sdm845_pdc_resets[] = {
diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c
index 7874f0693e1b..3ec22ae1fac1 100644
--- a/drivers/reset/reset-th1520.c
+++ b/drivers/reset/reset-th1520.c
@@ -78,7 +78,6 @@ static const struct regmap_config th1520_reset_regmap_config = {
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,
-	.fast_io = true,
 };
 
 static int th1520_reset_probe(struct platform_device *pdev)
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 18/21] soc: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (3 preceding siblings ...)
  2025-08-13 16:15 ` [PATCH 16/21] reset: " Wolfram Sang
@ 2025-08-13 16:15 ` Wolfram Sang
  2025-08-14  9:29   ` Konrad Dybcio
  2025-08-13 21:28 ` (subset) [PATCH 00/21] treewide: " Mark Brown
                   ` (4 subsequent siblings)
  9 siblings, 1 reply; 16+ messages in thread
From: Wolfram Sang @ 2025-08-13 16:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, Wolfram Sang, Bjorn Andersson, Konrad Dybcio,
	linux-arm-msm

When using MMIO with regmap, fast_io is implied. No need to set it
again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
No dependencies, can be applied directly to the subsystem tree. Buildbot is
happy, too.

 drivers/soc/qcom/llcc-qcom.c       | 1 -
 drivers/soc/qcom/ramp_controller.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 192edc3f64dc..857ead56b37d 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -4409,7 +4409,6 @@ static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev, u8 index
 		.reg_bits = 32,
 		.reg_stride = 4,
 		.val_bits = 32,
-		.fast_io = true,
 	};
 
 	base = devm_platform_ioremap_resource(pdev, index);
diff --git a/drivers/soc/qcom/ramp_controller.c b/drivers/soc/qcom/ramp_controller.c
index 349bdfbc61ef..15782bed2925 100644
--- a/drivers/soc/qcom/ramp_controller.c
+++ b/drivers/soc/qcom/ramp_controller.c
@@ -229,7 +229,6 @@ static const struct regmap_config qrc_regmap_config = {
 	.reg_stride = 4,
 	.val_bits = 32,
 	.max_register =	0x68,
-	.fast_io = true,
 };
 
 static const struct reg_sequence msm8976_cfg_dfs_sid[] = {
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 16/21] reset: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:15 ` [PATCH 16/21] reset: " Wolfram Sang
@ 2025-08-13 18:28   ` Drew Fustini
  2025-08-14 10:56   ` Philipp Zabel
  1 sibling, 0 replies; 16+ messages in thread
From: Drew Fustini @ 2025-08-13 18:28 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-kernel, Mark Brown, Philipp Zabel, Guo Ren, Fu Wei,
	linux-arm-msm, linux-riscv, Michal Wilczynski, Icenowy Zheng,
	Yao Zi

On Wed, Aug 13, 2025 at 06:15:02PM +0200, Wolfram Sang wrote:
> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> No dependencies, can be applied directly to the subsystem tree. Buildbot is
> happy, too.
> 
>  drivers/reset/reset-intel-gw.c | 1 -
>  drivers/reset/reset-qcom-pdc.c | 1 -
>  drivers/reset/reset-th1520.c   | 1 -
>  3 files changed, 3 deletions(-)
[snip]
> diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c
> index 7874f0693e1b..3ec22ae1fac1 100644
> --- a/drivers/reset/reset-th1520.c
> +++ b/drivers/reset/reset-th1520.c
> @@ -78,7 +78,6 @@ static const struct regmap_config th1520_reset_regmap_config = {
>  	.reg_bits = 32,
>  	.val_bits = 32,
>  	.reg_stride = 4,
> -	.fast_io = true,
>  };
>  
>  static int th1520_reset_probe(struct platform_device *pdev)
> -- 
> 2.47.2

Acked-by: Drew Fustini <fustini@kernel.org> # for reset-th1520.c

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (4 preceding siblings ...)
  2025-08-13 16:15 ` [PATCH 18/21] soc: " Wolfram Sang
@ 2025-08-13 21:28 ` Mark Brown
  2025-08-14 11:13 ` Mark Brown
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2025-08-13 21:28 UTC (permalink / raw)
  To: linux-kernel, Wolfram Sang
  Cc: Adrian Hunter, Alexandre Belloni, Alexandre Torgue, Alim Akhtar,
	Andrea della Porta, Andreas Färber, Andrzej Hajda,
	Andy Shevchenko, Andy Yan, Avi Fishman, Bartosz Golaszewski,
	Benjamin Fair, Bjorn Andersson, Chen-Yu Tsai, Daniel Lezcano,
	David Airlie, David Lechner, Dmitry Torokhov, Drew Fustini,
	dri-devel, Fabio Estevam, Fabrice Gasnier, Fu Wei, Guo Ren,
	Hans Verkuil, Heiko Stübner, imx, Iwona Winiarska,
	Jaroslav Kysela, Jassi Brar, Jernej Skrabec, Jerome Brunet,
	Jonas Karlman, Jonathan Cameron, Kevin Hilman,
	Kishon Vijay Abraham I, Konrad Dybcio, Krzysztof Kozlowski,
	Laurent Pinchart, Lee Jones, Liam Girdwood, Linus Walleij,
	linux-actions, linux-amlogic, linux-arm-kernel, linux-arm-msm,
	linux-clk, linux-gpio, linux-iio, linux-input, linux-media,
	linux-mmc, linux-phy, linux-pm, linuxppc-dev, linux-pwm,
	linux-riscv, linux-rockchip, linux-rtc, linux-samsung-soc,
	linux-sound, linux-spi, linux-stm32, linux-sunxi, Liu Ying,
	Lukasz Luba, Maarten Lankhorst, Manivannan Sadhasivam,
	Martin Blumenstingl, Mauro Carvalho Chehab, Maxime Coquelin,
	Maxime Ripard, Michael Turquette, Miquel Raynal, Nancy Yuen,
	Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick, Vinod Koul,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui

On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote:
> While working on a driver using regmap with MMIO, I wondered if I need
> to set 'fast_io' in the config. Turned out I don't need to, so I added
> documentation for it with commit ffc72771ff6e ("regmap: Annotate that
> MMIO implies fast IO").
> 
> This series fixes the existing users in the tree which needlessly set
> the flag. They have been found using this coccinelle script:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[15/21] regulator: remove unneeded 'fast_io' parameter in regmap_config
        commit: 37533933bfe92cd5a99ef4743f31dac62ccc8de0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 18/21] soc: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:15 ` [PATCH 18/21] soc: " Wolfram Sang
@ 2025-08-14  9:29   ` Konrad Dybcio
  0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2025-08-14  9:29 UTC (permalink / raw)
  To: Wolfram Sang, linux-kernel
  Cc: Mark Brown, Bjorn Andersson, Konrad Dybcio, linux-arm-msm

On 8/13/25 6:15 PM, Wolfram Sang wrote:
> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 16/21] reset: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:15 ` [PATCH 16/21] reset: " Wolfram Sang
  2025-08-13 18:28   ` Drew Fustini
@ 2025-08-14 10:56   ` Philipp Zabel
  1 sibling, 0 replies; 16+ messages in thread
From: Philipp Zabel @ 2025-08-14 10:56 UTC (permalink / raw)
  To: Wolfram Sang, linux-kernel
  Cc: Mark Brown, Drew Fustini, Guo Ren, Fu Wei, linux-arm-msm,
	linux-riscv

On Mi, 2025-08-13 at 18:15 +0200, Wolfram Sang wrote:
> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> No dependencies, can be applied directly to the subsystem tree. Buildbot is
> happy, too.

Applied patch 16 to reset/next, thanks!

[16/21] reset: remove unneeded 'fast_io' parameter in regmap_config
        https://git.pengutronix.de/cgit/pza/linux/commit/?id=1527cd3b89f0

regards
Philipp

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (5 preceding siblings ...)
  2025-08-13 21:28 ` (subset) [PATCH 00/21] treewide: " Mark Brown
@ 2025-08-14 11:13 ` Mark Brown
  2025-08-14 14:18 ` Mark Brown
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2025-08-14 11:13 UTC (permalink / raw)
  To: linux-kernel, Wolfram Sang
  Cc: Adrian Hunter, Alexandre Belloni, Alexandre Torgue, Alim Akhtar,
	Andrea della Porta, Andreas Färber, Andrzej Hajda,
	Andy Shevchenko, Andy Yan, Avi Fishman, Bartosz Golaszewski,
	Benjamin Fair, Bjorn Andersson, Chen-Yu Tsai, Daniel Lezcano,
	David Airlie, David Lechner, Dmitry Torokhov, Drew Fustini,
	dri-devel, Fabio Estevam, Fabrice Gasnier, Fu Wei, Guo Ren,
	Hans Verkuil, Heiko Stübner, imx, Iwona Winiarska,
	Jaroslav Kysela, Jassi Brar, Jernej Skrabec, Jerome Brunet,
	Jonas Karlman, Jonathan Cameron, Kevin Hilman,
	Kishon Vijay Abraham I, Konrad Dybcio, Krzysztof Kozlowski,
	Laurent Pinchart, Lee Jones, Liam Girdwood, Linus Walleij,
	linux-actions, linux-amlogic, linux-arm-kernel, linux-arm-msm,
	linux-clk, linux-gpio, linux-iio, linux-input, linux-media,
	linux-mmc, linux-phy, linux-pm, linuxppc-dev, linux-pwm,
	linux-riscv, linux-rockchip, linux-rtc, linux-samsung-soc,
	linux-sound, linux-spi, linux-stm32, linux-sunxi, Liu Ying,
	Lukasz Luba, Maarten Lankhorst, Manivannan Sadhasivam,
	Martin Blumenstingl, Mauro Carvalho Chehab, Maxime Coquelin,
	Maxime Ripard, Michael Turquette, Miquel Raynal, Nancy Yuen,
	Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick, Vinod Koul,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui

On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote:
> While working on a driver using regmap with MMIO, I wondered if I need
> to set 'fast_io' in the config. Turned out I don't need to, so I added
> documentation for it with commit ffc72771ff6e ("regmap: Annotate that
> MMIO implies fast IO").
> 
> This series fixes the existing users in the tree which needlessly set
> the flag. They have been found using this coccinelle script:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[19/21] spi: remove unneeded 'fast_io' parameter in regmap_config
        commit: 48124569bbc6bfda1df3e9ee17b19d559f4b1aa3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (6 preceding siblings ...)
  2025-08-14 11:13 ` Mark Brown
@ 2025-08-14 14:18 ` Mark Brown
  2025-08-15 14:42 ` Bjorn Andersson
  2025-08-20 17:02 ` Vinod Koul
  9 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2025-08-14 14:18 UTC (permalink / raw)
  To: linux-kernel, Wolfram Sang
  Cc: Adrian Hunter, Alexandre Belloni, Alexandre Torgue, Alim Akhtar,
	Andrea della Porta, Andreas Färber, Andrzej Hajda,
	Andy Shevchenko, Andy Yan, Avi Fishman, Bartosz Golaszewski,
	Benjamin Fair, Bjorn Andersson, Chen-Yu Tsai, Daniel Lezcano,
	David Airlie, David Lechner, Dmitry Torokhov, Drew Fustini,
	dri-devel, Fabio Estevam, Fabrice Gasnier, Fu Wei, Guo Ren,
	Hans Verkuil, Heiko Stübner, imx, Iwona Winiarska,
	Jaroslav Kysela, Jassi Brar, Jernej Skrabec, Jerome Brunet,
	Jonas Karlman, Jonathan Cameron, Kevin Hilman,
	Kishon Vijay Abraham I, Konrad Dybcio, Krzysztof Kozlowski,
	Laurent Pinchart, Lee Jones, Liam Girdwood, Linus Walleij,
	linux-actions, linux-amlogic, linux-arm-kernel, linux-arm-msm,
	linux-clk, linux-gpio, linux-iio, linux-input, linux-media,
	linux-mmc, linux-phy, linux-pm, linuxppc-dev, linux-pwm,
	linux-riscv, linux-rockchip, linux-rtc, linux-samsung-soc,
	linux-sound, linux-spi, linux-stm32, linux-sunxi, Liu Ying,
	Lukasz Luba, Maarten Lankhorst, Manivannan Sadhasivam,
	Martin Blumenstingl, Mauro Carvalho Chehab, Maxime Coquelin,
	Maxime Ripard, Michael Turquette, Miquel Raynal, Nancy Yuen,
	Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick, Vinod Koul,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui

On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote:
> While working on a driver using regmap with MMIO, I wondered if I need
> to set 'fast_io' in the config. Turned out I don't need to, so I added
> documentation for it with commit ffc72771ff6e ("regmap: Annotate that
> MMIO implies fast IO").
> 
> This series fixes the existing users in the tree which needlessly set
> the flag. They have been found using this coccinelle script:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[21/21] ASoC: remove unneeded 'fast_io' parameter in regmap_config
        commit: d578faf7096affc036fd16333f1bfbe4991a22f7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (7 preceding siblings ...)
  2025-08-14 14:18 ` Mark Brown
@ 2025-08-15 14:42 ` Bjorn Andersson
  2025-08-20 17:02 ` Vinod Koul
  9 siblings, 0 replies; 16+ messages in thread
From: Bjorn Andersson @ 2025-08-15 14:42 UTC (permalink / raw)
  To: linux-kernel, Wolfram Sang
  Cc: Mark Brown, Adrian Hunter, Alexandre Belloni, Alexandre Torgue,
	Alim Akhtar, Andrea della Porta, Andreas Färber,
	Andrzej Hajda, Andy Shevchenko, Andy Yan, Avi Fishman,
	Bartosz Golaszewski, Benjamin Fair, Chen-Yu Tsai, Daniel Lezcano,
	David Airlie, David Lechner, Dmitry Torokhov, Drew Fustini,
	dri-devel, Fabio Estevam, Fabrice Gasnier, Fu Wei, Guo Ren,
	Hans Verkuil, Heiko Stübner, imx, Iwona Winiarska,
	Jaroslav Kysela, Jassi Brar, Jernej Skrabec, Jerome Brunet,
	Jonas Karlman, Jonathan Cameron, Kevin Hilman,
	Kishon Vijay Abraham I, Konrad Dybcio, Krzysztof Kozlowski,
	Laurent Pinchart, Lee Jones, Liam Girdwood, Linus Walleij,
	linux-actions, linux-amlogic, linux-arm-kernel, linux-arm-msm,
	linux-clk, linux-gpio, linux-iio, linux-input, linux-media,
	linux-mmc, linux-phy, linux-pm, linuxppc-dev, linux-pwm,
	linux-riscv, linux-rockchip, linux-rtc, linux-samsung-soc,
	linux-sound, linux-spi, linux-stm32, linux-sunxi, Liu Ying,
	Lukasz Luba, Maarten Lankhorst, Manivannan Sadhasivam,
	Martin Blumenstingl, Mauro Carvalho Chehab, Maxime Coquelin,
	Maxime Ripard, Michael Turquette, Miquel Raynal, Nancy Yuen,
	Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick, Vinod Koul,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui


On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote:
> While working on a driver using regmap with MMIO, I wondered if I need
> to set 'fast_io' in the config. Turned out I don't need to, so I added
> documentation for it with commit ffc72771ff6e ("regmap: Annotate that
> MMIO implies fast IO").
> 
> This series fixes the existing users in the tree which needlessly set
> the flag. They have been found using this coccinelle script:
> 
> [...]

Applied, thanks!

[18/21] soc: remove unneeded 'fast_io' parameter in regmap_config
        commit: 5d8a9c8401648d338d072a488d455ed4611c5d4b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
                   ` (8 preceding siblings ...)
  2025-08-15 14:42 ` Bjorn Andersson
@ 2025-08-20 17:02 ` Vinod Koul
  9 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2025-08-20 17:02 UTC (permalink / raw)
  To: linux-kernel, Wolfram Sang
  Cc: Mark Brown, Adrian Hunter, Alexandre Belloni, Alexandre Torgue,
	Alim Akhtar, Andrea della Porta, Andreas Färber,
	Andrzej Hajda, Andy Shevchenko, Andy Yan, Avi Fishman,
	Bartosz Golaszewski, Benjamin Fair, Bjorn Andersson, Chen-Yu Tsai,
	Daniel Lezcano, David Airlie, David Lechner, Dmitry Torokhov,
	Drew Fustini, dri-devel, Fabio Estevam, Fabrice Gasnier, Fu Wei,
	Guo Ren, Hans Verkuil, Heiko Stübner, imx, Iwona Winiarska,
	Jaroslav Kysela, Jassi Brar, Jernej Skrabec, Jerome Brunet,
	Jonas Karlman, Jonathan Cameron, Kevin Hilman,
	Kishon Vijay Abraham I, Konrad Dybcio, Krzysztof Kozlowski,
	Laurent Pinchart, Lee Jones, Liam Girdwood, Linus Walleij,
	linux-actions, linux-amlogic, linux-arm-kernel, linux-arm-msm,
	linux-clk, linux-gpio, linux-iio, linux-input, linux-media,
	linux-mmc, linux-phy, linux-pm, linuxppc-dev, linux-pwm,
	linux-riscv, linux-rockchip, linux-rtc, linux-samsung-soc,
	linux-sound, linux-spi, linux-stm32, linux-sunxi, Liu Ying,
	Lukasz Luba, Maarten Lankhorst, Manivannan Sadhasivam,
	Martin Blumenstingl, Mauro Carvalho Chehab, Maxime Coquelin,
	Maxime Ripard, Michael Turquette, Miquel Raynal, Nancy Yuen,
	Neil Armstrong, Nicolin Chen, Nuno Sá, openbmc,
	Patrick Venture, Paul Walmsley, Pengutronix Kernel Team,
	Philipp Zabel, Piotr Wojtaszczyk, Rafael J. Wysocki, Robert Foss,
	Samuel Holland, Samuel Holland, Sandy Huang, Sascha Hauer,
	Shawn Guo, Shengjiu Wang, Simona Vetter, Stephen Boyd,
	Takashi Iwai, Tali Perry, Thomas Zimmermann, Tomer Maimon,
	Ulf Hansson, Uwe Kleine-König, Vasily Khoruzhick,
	Vladimir Zapolskiy, Xiubo Li, Yangtao Li, Zhang Rui


On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote:
> While working on a driver using regmap with MMIO, I wondered if I need
> to set 'fast_io' in the config. Turned out I don't need to, so I added
> documentation for it with commit ffc72771ff6e ("regmap: Annotate that
> MMIO implies fast IO").
> 
> This series fixes the existing users in the tree which needlessly set
> the flag. They have been found using this coccinelle script:
> 
> [...]

Applied, thanks!

[12/21] phy: remove unneeded 'fast_io' parameter in regmap_config
        commit: e1e1e77f7df7cbee959ba024e5475907fe561c98

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 02/21] clk: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-13 16:14 ` [PATCH 02/21] clk: " Wolfram Sang
@ 2025-08-21 21:46   ` Brian Masney
  2025-08-22  5:59     ` Wolfram Sang
  0 siblings, 1 reply; 16+ messages in thread
From: Brian Masney @ 2025-08-21 21:46 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-kernel, Mark Brown, Michael Turquette, Stephen Boyd,
	Andreas Färber, Manivannan Sadhasivam, Vladimir Zapolskiy,
	Piotr Wojtaszczyk, Bjorn Andersson, Drew Fustini, Guo Ren, Fu Wei,
	linux-clk, linux-arm-kernel, linux-actions, linux-arm-msm,
	linux-riscv

Hi Wolfram,

On Wed, Aug 13, 2025 at 06:14:48PM +0200, Wolfram Sang wrote:
> When using MMIO with regmap, fast_io is implied. No need to set it
> again.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> No dependencies, can be applied directly to the subsystem tree. Buildbot is
> happy, too.
> 
>  drivers/clk/actions/owl-common.c  | 1 -
>  drivers/clk/clk-axm5516.c         | 1 -
>  drivers/clk/nxp/clk-lpc32xx.c     | 1 -
>  drivers/clk/qcom/a53-pll.c        | 1 -
>  drivers/clk/qcom/a7-pll.c         | 1 -
>  drivers/clk/qcom/apss-ipq-pll.c   | 1 -
>  drivers/clk/qcom/clk-cbf-8996.c   | 1 -
>  drivers/clk/qcom/clk-cpu-8996.c   | 1 -
>  drivers/clk/qcom/hfpll.c          | 1 -
>  drivers/clk/qcom/ipq-cmn-pll.c    | 1 -
>  drivers/clk/thead/clk-th1520-ap.c | 1 -
>  11 files changed, 11 deletions(-)

These all look good to me.

Reviewed-by: Brian Masney <bmasney@redhat.com>

Should drivers/clk/sprd/common.c also be updated as well?

Brian


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 02/21] clk: remove unneeded 'fast_io' parameter in regmap_config
  2025-08-21 21:46   ` Brian Masney
@ 2025-08-22  5:59     ` Wolfram Sang
  0 siblings, 0 replies; 16+ messages in thread
From: Wolfram Sang @ 2025-08-22  5:59 UTC (permalink / raw)
  To: Brian Masney
  Cc: linux-kernel, Mark Brown, Michael Turquette, Stephen Boyd,
	Andreas Färber, Manivannan Sadhasivam, Vladimir Zapolskiy,
	Piotr Wojtaszczyk, Bjorn Andersson, Drew Fustini, Guo Ren, Fu Wei,
	linux-clk, linux-arm-kernel, linux-actions, linux-arm-msm,
	linux-riscv

Hi Brian,

> These all look good to me.
> 
> Reviewed-by: Brian Masney <bmasney@redhat.com>

Thank you!

> Should drivers/clk/sprd/common.c also be updated as well?

Yes. I wrote in the cover-letter that a few occasions couldn't be
automated with my coccinelle script because of the indirection. I will
fix the remaining few ones manually, but I didn't get to that until now.

Happy hacking,

   Wolfram


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2025-08-22  5:59 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 16:14 [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config Wolfram Sang
2025-08-13 16:14 ` [PATCH 02/21] clk: " Wolfram Sang
2025-08-21 21:46   ` Brian Masney
2025-08-22  5:59     ` Wolfram Sang
2025-08-13 16:14 ` [PATCH 07/21] mailbox: " Wolfram Sang
2025-08-13 16:15 ` [PATCH 15/21] regulator: " Wolfram Sang
2025-08-13 16:15 ` [PATCH 16/21] reset: " Wolfram Sang
2025-08-13 18:28   ` Drew Fustini
2025-08-14 10:56   ` Philipp Zabel
2025-08-13 16:15 ` [PATCH 18/21] soc: " Wolfram Sang
2025-08-14  9:29   ` Konrad Dybcio
2025-08-13 21:28 ` (subset) [PATCH 00/21] treewide: " Mark Brown
2025-08-14 11:13 ` Mark Brown
2025-08-14 14:18 ` Mark Brown
2025-08-15 14:42 ` Bjorn Andersson
2025-08-20 17:02 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).