linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Georgi Djakov <djakov@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sdm670: add cpu frequency scaling
Date: Tue, 25 Jul 2023 09:26:19 +0200	[thread overview]
Message-ID: <e6b0c188-9078-af38-39db-8551fcbf39a5@linaro.org> (raw)
In-Reply-To: <20230724214209.208699-9-mailingradian@gmail.com>

On 24.07.2023 23:42, Richard Acayan wrote:
> Add CPU frequency scaling and the operating performance points for the
> CPUs.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
You should also mention you're adding DDR scaling here (the APPS-EBI path)

[...]

>  
> +	cpu0_opp_table: opp-table-cpu0 {
> +		compatible = "operating-points-v2";
> +		opp-shared;
> +
> +		// 576 mV
Drop these comments.

Konrad

  reply	other threads:[~2023-07-25  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 21:42 [PATCH 0/4] SDM670 CPU Frequency Scaling Richard Acayan
2023-07-24 21:42 ` [PATCH 1/4] dt-bindings: interconnect: add SDM670 OSM L3 compatible Richard Acayan
2023-07-25  5:45   ` Krzysztof Kozlowski
2023-07-24 21:42 ` [PATCH 2/4] arm64: dts: qcom: sdm670: add osm l3 Richard Acayan
2023-07-25  7:24   ` Konrad Dybcio
2023-07-24 21:42 ` [PATCH 3/4] arm64: dts: qcom: sdm670: add cpu frequency scaling Richard Acayan
2023-07-25  7:26   ` Konrad Dybcio [this message]
2023-07-24 21:42 ` [PATCH 4/4] arm64: dts: qcom: sdm670: add frequency profile Richard Acayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6b0c188-9078-af38-39db-8551fcbf39a5@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mailingradian@gmail.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).