From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E987622324 for ; Mon, 19 Feb 2024 07:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328042; cv=none; b=SRdNKaOb6nLbCUy8OFcIpFM3hhCSYuY61NQN6Qxf418IAKe3ZTNFzfi5sJdfdDS20twIWqHvyvFtcjf4hiRBV9uo6rGmAmxZrMnS4HF/A4+KF2wFI5VzQnbceLtYNLLDGvBxvZZflBwtwAYgUQCzFktAuAPkhPnvbSfVqIpIVdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328042; c=relaxed/simple; bh=pSGqYWEkgA5r9fvAZaRNq9VpI+rNE64hzozwKd0Iv60=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=otiYnVJlM/gviJLTEf9CT2+JZ0neTTfoq1sFvdtqX5vvn/wGdVt2yOOnAtwVnMFTZ6wNqZ3HLz9hugnUccZ+sJKwcPtJm2KclUm7aznqo0MuW/EqqxbmwdCCJ4yNATKegscBLHGs0uPANbcuxPIfVDY1+EbpudCID5NcJ+KC3uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=agmGWt0G; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="agmGWt0G" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-511ac32fe38so5938811e87.1 for ; Sun, 18 Feb 2024 23:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1708328037; x=1708932837; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+ng3gW4V3o0lgSkXW6LbE2EKjcIRK6fb4LZxE38g6CE=; b=agmGWt0GYXvSMZ5nFELoKzr7zFdgt7JzmtUYPeiiRxQlJxcBoGgOylwgHzarSE/PTY tMd1EuXOdLZH4pZ8dLddHn4tpz7r87EivJpJpv7W8qXRIGa+l+1YC4QUnpmh/0NFxJ93 Z509cUXTYLax9/aNTu/CbDLPUv3IJWLNWt4qGTK0MrcK4Vhge74X77GVWFKZtZ8IiB7R N3lR7s/ZNj27Ps77ra8wHKaAswIaatdghJZ3rdc7diLlfN+MT16abFK4lnB4flsJ+bbe JZuGw2fYSioAVUQtJihYeokp3zbnUK3y5CHrMKBVALcXAWqrNyuQIKui8Jn1Vr1jOkKR hCqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708328037; x=1708932837; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+ng3gW4V3o0lgSkXW6LbE2EKjcIRK6fb4LZxE38g6CE=; b=RoHKCpiHpXwUD1qNO7jFD6bNj44RlFMNOUhh1KuYzAoyv0g9FDCnpQJpvVJTCId8bi GyGFTuSslDgdq9a3PTDNZV0AyjpY+EiUx0z/3iX13lLbjYJ/Q2GBHSJvCjI+ED412iHM 9J9Pwc93AREz+cc48hTTkPLZVu/Z4S7xHW/KXPc7eEafoDnjsZklak+3SZD8lcl0IPQ3 uRofAdDK+U38fQ2eKLqlIH96BIv5xMWU2jmUS5/RVQlY0s00sIsi0JEG+F639uZP4H7/ yOntJPotxBACMEh80fJChVmiEHvp0QHFXwlpRKDF26QNbWzuctCEDg/gnRoSSbc90qvM uwbw== X-Forwarded-Encrypted: i=1; AJvYcCXnkXREUGaU7SCzLw3VJ1ViGriHGTqxULU3md1LSM+F/L70Ve6C1sh6IqDH3pMdfv4M1fxJw2T+H80Wl7UTgRcdvT76dE+g9D2r9mk3xQ== X-Gm-Message-State: AOJu0Yxuezk/iVuZn2lYEZ5/5KPF1RIRtUPyyAlnnMViKEhgxO+F041I nhKvvJct//cn1t+SPzCthBtAzo+rcBe1JZtb7WJZiZBWGQ9Fh0NtHGu5ZP+L36U= X-Google-Smtp-Source: AGHT+IH7t2S3UJLlE+g5RosWguA6ACJo1jYaUo0HRFcgzCtXQeK6rSIGLys7KhAWV1PTPsrhu0txhw== X-Received: by 2002:a05:6512:3144:b0:511:84fe:8dcd with SMTP id s4-20020a056512314400b0051184fe8dcdmr7786108lfi.1.1708328036943; Sun, 18 Feb 2024 23:33:56 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.20]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c1d1400b0041256ab5becsm7611582wms.26.2024.02.18.23.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Feb 2024 23:33:56 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 09:33:53 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: constify the of_phandle_args argument of of_clk_provider Content-Language: en-US To: Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Sudeep Holla , Peng Fan , Shawn Guo , Nishanth Menon , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Thierry Reding , Jonathan Hunter , Linus Walleij , Laurent Pinchart , Mauro Carvalho Chehab , Vinod Koul , Russell King , Srinivas Kandagatla , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-stm32@st-md-mailman.stormreply.com, NXP Linux Team , linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org References: <20240208163710.512733-1-krzysztof.kozlowski@linaro.org> <88de75cd-4069-4be6-9c4e-f32befa46d58@linaro.org> From: claudiu beznea In-Reply-To: <88de75cd-4069-4be6-9c4e-f32befa46d58@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19.02.2024 08:59, Krzysztof Kozlowski wrote: > On 19/02/2024 07:25, claudiu beznea wrote: >> >> >> On 08.02.2024 18:37, Krzysztof Kozlowski wrote: >>> None of the implementations of the get() and get_hw() callbacks of >>> "struct of_clk_provider" modify the contents of received of_phandle_args >>> pointer. They treat it as read-only variable used to find the clock to >>> return. Make obvious that implementations are not supposed to modify >>> the of_phandle_args, by making it a pointer to const. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> drivers/clk/at91/pmc.c | 3 +- >>> drivers/clk/at91/pmc.h | 3 +- >> >> Reviewed-by: Claudiu Beznea > > You understand there is no review for "part of patch"? You probably > meant Acked-by. Sure... Here it is: Acked-by: Claudiu Beznea > > https://elixir.bootlin.com/linux/v6.8-rc5/source/Documentation/process/submitting-patches.rst#L544 > > Best regards, > Krzysztof >