linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
Cc: bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v2 4/7] drm/msm: dpu: Remove dpu_plane_sspp_enabled()
Date: Thu, 13 Sep 2018 15:25:39 -0700	[thread overview]
Message-ID: <e702940d5aaf229b131241aaf8ad8a17@codeaurora.org> (raw)
In-Reply-To: <20180912135459.216217-4-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>

On 2018-09-12 06:54, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> It's doing the same thing dpu_plane_enabled() is.
> 
> Changes in v2:
> - None
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---

Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 2b1f61114e1c..0c6798df1e6b 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -138,11 +138,6 @@ static bool dpu_plane_enabled(struct 
> drm_plane_state
> *state)
>  	return state && state->fb && state->crtc;
>  }
> 
> -static bool dpu_plane_sspp_enabled(struct drm_plane_state *state)
> -{
> -	return state && state->crtc;
> -}
> -
>  /**
>   * _dpu_plane_calc_fill_level - calculate fill level of the given 
> source
> format
>   * @plane:		Pointer to drm plane
> @@ -1398,7 +1393,7 @@ static void dpu_plane_atomic_update(struct 
> drm_plane
> *plane,
> 
>  	DPU_DEBUG_PLANE(pdpu, "\n");
> 
> -	if (!dpu_plane_sspp_enabled(state)) {
> +	if (!dpu_plane_enabled(state)) {
>  		_dpu_plane_atomic_disable(plane, old_state);
>  	} else {
>  		int ret;

-- 
Jeykumar S
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2018-09-13 22:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 13:54 [PATCH v2 1/7] drm/msm: dpu: Remove impossible checks Sean Paul
     [not found] ` <20180912135459.216217-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-12 13:54   ` [PATCH v2 2/7] drm/msm: dpu: Move atomic_check_plane_state() call to atomic_check Sean Paul
     [not found]     ` <20180912135459.216217-2-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:24       ` Jeykumar Sankaran
2018-09-12 13:54   ` [PATCH v2 3/7] drm/msm: dpu: Consolidate atomic_check functions() Sean Paul
     [not found]     ` <20180912135459.216217-3-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:24       ` Jeykumar Sankaran
2018-09-12 13:54   ` [PATCH v2 4/7] drm/msm: dpu: Remove dpu_plane_sspp_enabled() Sean Paul
     [not found]     ` <20180912135459.216217-4-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:25       ` Jeykumar Sankaran [this message]
2018-09-12 13:54   ` [PATCH v2 5/7] drm/msm: dpu: Remove dpu_plane_enabled() Sean Paul
     [not found]     ` <20180912135459.216217-5-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:30       ` Jeykumar Sankaran
2018-09-12 13:54   ` [PATCH v2 6/7] drm/msm: dpu: Make dpu_plane_sspp_atomic_update() void Sean Paul
     [not found]     ` <20180912135459.216217-6-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:33       ` Jeykumar Sankaran
2018-09-12 13:54   ` [PATCH v2 7/7] drm/msm: dpu: Don't continue after error in atomic_check Sean Paul
     [not found]     ` <20180912135459.216217-7-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-13 22:34       ` Jeykumar Sankaran
2018-09-13 22:23   ` [PATCH v2 1/7] drm/msm: dpu: Remove impossible checks Jeykumar Sankaran
     [not found]     ` <3782b720d2c4bee1bc20cacff8f6f7f5-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-09-17 15:44       ` Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e702940d5aaf229b131241aaf8ad8a17@codeaurora.org \
    --to=jsanka-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).