From: Akhil P Oommen <akhilpo@codeaurora.org>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc: Linux Firmware <linux-firmware@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH] qcom: add gpu firmwares for sc7280
Date: Thu, 29 Apr 2021 14:56:13 +0530 [thread overview]
Message-ID: <e76cc831-ed8e-9f29-0472-96cdf929ce14@codeaurora.org> (raw)
In-Reply-To: <CAP71WjzphRWpcMvmUZQJwobXdmgqoUG2MzgQaLLg03P-Fm0Rvw@mail.gmail.com>
On 4/29/2021 1:08 PM, Nicolas Dechesne wrote:
> On Thu, Apr 29, 2021 at 8:25 AM Akhil P Oommen <akhilpo@codeaurora.org> wrote:
>>
>> Adds a660_gmu.bin (v3.01.06) and a660_sqe.fw (v0.94) firmware blobs
>> required for sc7280 SoC.
>>
>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
>> ---
>> WHENCE | 2 ++
>> qcom/a660_gmu.bin | Bin 0 -> 55444 bytes
>> qcom/a660_sqe.fw | Bin 0 -> 40496 bytes
>> 3 files changed, 2 insertions(+)
>> create mode 100644 qcom/a660_gmu.bin
>> create mode 100644 qcom/a660_sqe.fw
>>
>> diff --git a/WHENCE b/WHENCE
>> index 3a27e34..3371dc7 100644
>> --- a/WHENCE
>> +++ b/WHENCE
>> @@ -5191,6 +5191,8 @@ File: qcom/sdm845/a630_zap.mbn
>> File: qcom/a650_gmu.bin
>> File: qcom/a650_sqe.fw
>> File: qcom/sm8250/a650_zap.mbn
>> +File: qcom/a660_gmu.bin
>> +File: qcom/a660_sqe.fw
>>
>> Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
>>
>> diff --git a/qcom/a660_gmu.bin b/qcom/a660_gmu.bin
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..ee1b922b45bf17899f486cd1151f0fffe3fd8eb5
>> GIT binary patch
>
> For linux-firmware PR, you most likely need to send a PR from a public
> branch instead. Binary patch isn't really working well. Here are
> example of previous QCOM firmware PRs:
>
> https://lore.kernel.org/linux-firmware/bee73b3fe8b04c1a2663be0cd3cc7318@codeaurora.org/
> https://lore.kernel.org/linux-firmware/20210401201115.stkX71kzODcOGviP6NCSqy_k3M3AN3G5oqHzAyBYMWs@z/
>
I thought that binary patches were acceptable. It is mentioned in the
README and also, I see a lot of binary patches being posted to
linux-firmware like this:
https://lore.kernel.org/linux-firmware/CA+5PVA7Deq3P_cw+Ro8xDeQeS1CTeK8RTfXUB0b5L622npvX7w@mail.gmail.com/T/
-Akhil.
prev parent reply other threads:[~2021-04-29 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 6:24 [PATCH] qcom: add gpu firmwares for sc7280 Akhil P Oommen
[not found] ` <CAP71WjzphRWpcMvmUZQJwobXdmgqoUG2MzgQaLLg03P-Fm0Rvw@mail.gmail.com>
2021-04-29 9:26 ` Akhil P Oommen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76cc831-ed8e-9f29-0472-96cdf929ce14@codeaurora.org \
--to=akhilpo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-firmware@kernel.org \
--cc=nicolas.dechesne@linaro.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox