From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D752420DD51 for ; Wed, 13 May 2026 13:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778680439; cv=none; b=JvyzBReclLNWSR4p4TdAvqFMEuvaaACH1gQ5NCxT2hkhnKD/T6pikoOoBD5TnGyhzkFIt+AbqwGsuLUktPtfaLTZCMjS5qlH4pGTAtkxgWIegjeh9FfShzBoRdl8VDqnehVI/xOF4W/rIr0kmBthc69Qjz6cXhhNipLYnKQbXV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778680439; c=relaxed/simple; bh=XYGdoRidFMjiq6rKlhGtSdZX2v51fzcculvRGm/mbuA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FARM8rfVXjI+SIxmiEMvF1bqrfQHU3Cupe4qCSPbv1eROybnSUu/8l0FBqSsvp596UCDoFoDoCHtJMRkQ6xb0yRRTHrR8Dn4fKsmyzVwVGi9KzjGMS4zkTgHt4xMOc2nkiyKSSiNLX74dMOoLkSVVa7IM4iEAXFevoPTWPHdhW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BkuFHDI8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GhODYWjB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BkuFHDI8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GhODYWjB" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D8rF404082487 for ; Wed, 13 May 2026 13:53:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hs5P7u/MpNOgYLnxyt/wcmDt/oUTdWmSA9NpPH7AlyM=; b=BkuFHDI8rti1TUOF 4jCUWxIjBJ/0+OFK2IvsIOle9mWGiFxti8K2HtfSwSstrjOZCukILa9UlKAS/IqY Srt8hSyiIBsNjPjm3dHYQJXdotAA1LLbsasFTHdEivYGgwNld5xHcaaIm5r6CDe9 PKug9MGIkRgKdieoJNf58IaHZ/bAWeAJvVesvnvP1dMcYiKqolyY6bMKo3H3vGgp 7lGqUEpc4qLW3lazgw2WXxDcBFv9KnZsHTRV6vr0fldDB5BC+lPf+abIjezcbw8z qhgNrzQEZQJGNwcd+KqxmvghuiIU7kbm2r6M72mNhJ0l0tryQ00F9tv5bS6Yrsf4 /DYCsQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p6e136f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 13:53:57 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba86e35aa1so105670265ad.1 for ; Wed, 13 May 2026 06:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778680436; x=1779285236; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hs5P7u/MpNOgYLnxyt/wcmDt/oUTdWmSA9NpPH7AlyM=; b=GhODYWjBz4Lq1KxLQiO28O8N8m3c3Js6SaYoyXgeaaFBkQCb+1oNkFD1o0LsvZ0s9r zu/sMVJw2go4XpoiYegtiWrOk7p3BX2eXp/ZV9TfWVyKiuB0ekvjqyBlKV1pgLFd6IO1 FsZJSZkyaKa8EgvtaVHiUmyYvPwI2BBuHVWEX+tWlEsardjDP6jbcmOORvPbx3wNkVW1 77ttrZ/JtBSr+fLMJvM9C65kRvs0+9PGmUQVrBH0zO9d5wuOIIYTv5njg3DG9IbCtIDf TkVrbhW3IaQ9+OYloE18YpbD1uCcKlLbxcshG5b+9dPEV/UXmXXTrhuirz1m3ismooVW NFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778680436; x=1779285236; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hs5P7u/MpNOgYLnxyt/wcmDt/oUTdWmSA9NpPH7AlyM=; b=KjdNUFQSd7i4bQ1a48kT43guWKdBvuCdlSRlNH7vSWwPPCi0breoGnEcMF3ZQzNk7v jJh8Sv8BEeV8uzVDQ61DMLp2nOxZnfVndSTAUD9zAQXDgTK7lE4MxbPPv74h5nmCtHrg DKHLF1mgmwx2VX8XhV3M+8Bvf/lJaMlzGXcE9421aNRuOz8LrMiWjpeHzeJLmRVgXXiJ V9HHWOdicLKciErq7fKcE2rpa6kxuMSSbBLQzILj7E/UqhO16BRvR2pZQ6bBb2WLmiWv d1coUOyZahwth/vbWZ96xePqBpMkp/xxZD6rIqvAFf/UeXE/qGj6oFn1yognvwM45sDL TQuA== X-Forwarded-Encrypted: i=1; AFNElJ8yzhtaUyoEqyh8MgsdCUZ4Ip8aM7pv8Q9FGzVXggzvr8ln9KSAgmMRq2JGW8sWaQ3VIwJ4F2cC0Ts0U1+M@vger.kernel.org X-Gm-Message-State: AOJu0Yy9gmoGEeRv7cQoJy06dCZHPNNnF3UbTKvOldmnOcLnrVLFvD/l oQKCVRQUrUFSLdo4fpxVoA/WWqaY9NDsYjRkyo+Zip8hNcGYJZktRO8QotC8gkAMnqdcOEj9hR8 Uaf5+KAbU4FeuVKJwoAhuus6HvWtWrrslAPkaCkBdzS2l4rPjw0WjlmKHp3+BWLnbT1Tf X-Gm-Gg: Acq92OG9NHJM8bLTZBUDVf8xHwH7yT4LpvMllny9ZDrY9w9T1dSGPhsPwl9q3pQhx8W 8oXbroTrWHqlTwuT32ju/CpBT5YRVTkKBhcLeUB74EzKHnK9jhezIuyQJELLRwJ44V8BPvlM6IN evG79YMTPSPNQ8EVGC6h12x1bcxKDkILA84jVmcZQw47ilA8GzZ9M+JmkBG8OuiWCa3yKHqwEqm +Pwl1SXAM0FzPA7tQ8+2bkv7io423o7vV3LC8DeDXWRerEfeEvWN7ou4xbAvsUmxRqVGrDUrAdn +vK6EK58Iyu+34incD7kidtur4ldInrA5sK2bVE4336E+gD9lb3vMd/R0hFswKIuDb+mFykYjP7 fsFHKiTm4CwkaMccEszgRVxR/d4DpvXL3W+9LyfvXvSEhdjWduw== X-Received: by 2002:a17:903:8c6:b0:2bd:907:2cf0 with SMTP id d9443c01a7336-2bd276f20f8mr41796395ad.32.1778680436472; Wed, 13 May 2026 06:53:56 -0700 (PDT) X-Received: by 2002:a17:903:8c6:b0:2bd:907:2cf0 with SMTP id d9443c01a7336-2bd276f20f8mr41795905ad.32.1778680435955; Wed, 13 May 2026 06:53:55 -0700 (PDT) Received: from [10.219.49.212] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d405efsm179171335ad.23.2026.05.13.06.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 06:53:55 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 19:23:52 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Dmitry Baryshkov Cc: Bjorn Andersson , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260508113636.3561383-1-ajay.nandam@oss.qualcomm.com> <20260513122542.3726319-2-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: q7gXSwkyqSoSQ8ZwSHT67ZTITGgsnGd_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE0MiBTYWx0ZWRfX4C3pjOShMyxO twOdocXnaRiGbTX4gkpzhx/g2B40IziPPdStMNLW/bMH3+gEOXkIq39QQlvx+vWL2fKNu92gyd+ zuhmEcg/8GOSZsvGlmR44cS05a9Y75cq55EdUG4EoxtCMpYkdfazEwZDFzAMIhfFxGa7HCIWC64 do8JYVJjzC2KMyyz3p5otyeDloVVJjzqYsMKJGwi6k6LLJq86wEK5J9JgGfiWMXkrEMKzLAMBdI 2uKEXwOEZOyNPEZhVLXGOaNBDR14vcX9MB63/XLHBkVOPOfGwNutIleEgNtCraSPJDkiVPF2ADj +UuR7uLOZWlbax2vqLaN3nleGSItSGDhUtTLoqMyU5MYmqK6GXCs8BWHUMwBMdlcBN2+8FRfJlA p69+3KVUfhAlbZvOpFMbcMBVBiauA+sU2ZhtjyH0dMFhV8tapIX9q/CvijyECCopuu3ODA+nLgJ Nj4UKbnYJjL99YpGGZA== X-Proofpoint-GUID: q7gXSwkyqSoSQ8ZwSHT67ZTITGgsnGd_ X-Authority-Analysis: v=2.4 cv=Wukb99fv c=1 sm=1 tr=0 ts=6a048275 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=3XSISe0faenqoDDrUQoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130142 On 5/13/2026 6:22 PM, Dmitry Baryshkov wrote: > On Wed, May 13, 2026 at 05:55:26PM +0530, Ajay Kumar Nandam wrote: >> Convert the LPASS LPI pinctrl driver to use the PM clock framework for >> runtime power management. >> >> This allows the LPASS LPI pinctrl driver to drop clock votes when idle, >> improves power efficiency on platforms using LPASS LPI island mode, and >> aligns the driver with common runtime PM patterns used across Qualcomm >> LPASS subsystems. >> >> Guard GPIO register read/write helpers and slew-rate register programming >> with synchronous runtime PM calls so the device is active during MMIO >> operations whenever autosuspend is enabled. >> >> Signed-off-by: Ajay Kumar Nandam >> --- >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 118 ++++++++++++------ >> .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 7 ++ >> 2 files changed, 88 insertions(+), 37 deletions(-) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> index 15ced5027579..d95e28926d38 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> @@ -15,6 +15,9 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include "../pinctrl-utils.h" >> >> @@ -22,7 +25,6 @@ >> >> #define MAX_NR_GPIO 32 >> #define GPIO_FUNC 0 >> -#define MAX_LPI_NUM_CLKS 2 >> >> struct lpi_pinctrl { >> struct device *dev; >> @@ -31,7 +33,6 @@ struct lpi_pinctrl { >> struct pinctrl_desc desc; >> char __iomem *tlmm_base; >> char __iomem *slew_base; >> - struct clk_bulk_data clks[MAX_LPI_NUM_CLKS]; >> /* Protects from concurrent register updates */ >> struct mutex lock; >> DECLARE_BITMAP(ever_gpio, MAX_NR_GPIO); >> @@ -39,29 +40,47 @@ struct lpi_pinctrl { >> }; >> >> static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, >> - unsigned int addr) >> + unsigned int addr, u32 *val) >> { >> u32 pin_offset; >> + int ret; >> >> if (state->data->flags & LPI_FLAG_USE_PREDEFINED_PIN_OFFSET) >> pin_offset = state->data->groups[pin].pin_offset; >> else >> pin_offset = LPI_TLMM_REG_OFFSET * pin; >> >> - return ioread32(state->tlmm_base + pin_offset + addr); >> + ret = pm_runtime_resume_and_get(state->dev); >> + if (ret < 0) >> + return ret; >> + >> + *val = ioread32(state->tlmm_base + pin_offset + addr); >> + ret = pm_runtime_put_autosuspend(state->dev); >> + if (ret < 0) >> + return ret; >> + >> + return 0; > > Just `return pm_runtime_put_autosuspend(state->dev)`, no need for extra > ifs. > ACK, Addressed in V5. Thanks Ajay Kumar >> } >> >