Re: [PATCH v4 5/6] media: dt-bindings: Add qcom,qcm2290-camss

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/04/2025 09:53, Loic Poulain wrote:
> Hi Krzysztof,
> 
> On Thu, Apr 24, 2025 at 9:37 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Wed, Apr 23, 2025 at 09:20:43AM GMT, Loic Poulain wrote:
>>> +  power-domains:
>>> +    items:
>>> +      - description: GDSC CAMSS Block, Global Distributed Switch Controller.
>>> +
>>> +  vdda-csiphy-1p2-supply:
>>> +    description:
>>> +      Phandle to a 1.2V regulator supply to CSI PHYs.
>>> +
>>> +  vdda-pll-1p8-supply:
>>
>>
>> How are the pins or input supplies called?
> 
> Pins are called:
> - VDD_A_CSI_0_1P2 (for csiphy 0)
> - VDD_A_CSI_1_1P2 (for csiphy 1)

OK. This however starts new questions: why aren't there separate nodes
for the CSI PHY controllers? These are separate blocks with their own
address space, own power rails, own interrupts and own clocks.

> (both of the above are supplied together without individual control)
> - VDD_A_CAMSS_PLL_1P8
This does not need voltage name then.


Best regards,
Krzysztof