From: Konrad Dybcio <konradybcio@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Fabien Parent <fabien.parent@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Luca Weiss <luca@lucaweiss.eu>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM
Date: Thu, 5 Sep 2024 14:39:52 +0200 [thread overview]
Message-ID: <e868a812-def6-483b-95a1-ffc8e47d0577@kernel.org> (raw)
In-Reply-To: <2a15105f-67e2-42f6-b624-562485b0bee2@kernel.org>
On 5.09.2024 2:38 PM, Konrad Dybcio wrote:
> On 4.09.2024 8:26 PM, Fabien Parent wrote:
>> Commit 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes
>> properties for APCS") broke the boot on msm8939 platforms.
>>
>> The issue comes from the SMD driver failing to request the mbox
>> channel because of circular dependencies:
>> 1. rpm -> apcs1_mbox -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm.
>> 2. rpm -> apcs1_mbox -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm
>> 3. rpm -> apcs1_mbox -> apcs2 -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm
>>
>> To fix this issue let's switch back to using the deprecated
>> qcom,ipc property for the RPM node.
>>
>> Fixes: 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes properties for APCS")
>> Signed-off-by: Fabien Parent <fabien.parent@linaro.org>
>> ---
>
> This is fine as a stopgap solution, Bjorn can we push it in -fixes?
>
> This platform is admittedly not of top importance.. but fixing this
> eventually would be nice
>
> #regzbot introduced: 22e4e43484c4
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
next prev parent reply other threads:[~2024-09-05 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 18:26 [PATCH] arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM Fabien Parent
2024-09-05 12:38 ` Konrad Dybcio
2024-09-05 12:39 ` Konrad Dybcio [this message]
2024-09-05 14:26 ` Luca Weiss
2024-10-03 14:29 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e868a812-def6-483b-95a1-ffc8e47d0577@kernel.org \
--to=konradybcio@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.parent@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox