From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE302F2F for ; Thu, 12 Dec 2024 18:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029251; cv=none; b=LsuXrCbRfXQaELkycrN2LGViij2W8g3VSKondlPkB3qUGeI22cY8qNV/IdCTlfN6EmJoIu0nrmMxofyBPvmAwj0ck0eyYuBhuj/XuBilHxhWxgNBbiE/7UxUMq3/ISkksRA26atAbZb46DG0ezULRy8w4wBEIBbVK9MxXlFavkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029251; c=relaxed/simple; bh=dRBwDdqVsCCEYLwA11HwOnnwTyk4wl1aEnHQ556Jb08=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gQF0uv/s+u0XI95F+eWI+d3DepHyq4i4femnjEhOMgArkswxp0dmJ/WvbP1at5SdK3nm/veVdbv+SU5X2GqOeR5dM1UAOOG8rElCGLJtic3NWZyB0xbAIGPiHEO+1Wnwuq1P1XbR1WbhV2N4hshvAlSYv7cFmmOn1j7ynZZpLOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MytoWnSo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MytoWnSo" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BCGPfZa002087 for ; Thu, 12 Dec 2024 18:47:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mVNJWdu24OyWB2jkcJ8N7wb3euEWMH8XguJzsbaIJ/s=; b=MytoWnSoV1jWWrpz QZ5FYuzg9pwFWurCI3HZM5hybr/E2viiamMoJciRVHUy2HHBdP9xJTQXQCUWfcda s56uEOeHsJ5hWTngjVSEbSzBZ18CvWsIJnQv/46Caruz+Pi/0erro15pIztyWF15 IOoHuU+AEjeZDNBpGNsTqNbb79Jpn32vsE2f3f7rXg+XlKWyJLlOBFamKpCnhkhD I9gJ45PJng5px8KeT6yJjlPM8OdVBjrZ6xZozY2Hr+XZOpc0c5knAIXShm+yo1Dt C8/qVnt4UnBqCh9d0h1gbw3Q6FKKPDVoXIUZC0hkiWTKrNso69uYZcRuRnTO0qRI ZIlDuQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43f0r9xctn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 Dec 2024 18:47:29 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4679fb949e8so1166951cf.1 for ; Thu, 12 Dec 2024 10:47:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734029248; x=1734634048; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mVNJWdu24OyWB2jkcJ8N7wb3euEWMH8XguJzsbaIJ/s=; b=po6iUoP+IK2Smjhwbqq384oYvBNb40wacOnUDjWGk3/7hyY11taIj1X++pqxbbz5jL 9EBT+uuNQyN4wXMM7gEOcFUPfU54xWlTr0/Ps3jZt0FVXG4gJQLLi06vH2n+ucHxWxYh AXghx3V2ecVcxOWpnClOwiJscpqDYUJ/yXWEMi6uEahhiCaaR4oirQPyzrsud0OI6KL5 g+fr+URv3EXb7Aq7RT66PflWfnolo84/9Z1652j5a93j8i8+2wRArQE06zrNCllve7ad 1Q8z64ZqE2DpTveg31aquAipVyteA0GpQUrs8tt9iLhIa/udAFRkU2V2M8r41D3oySQx R8cg== X-Gm-Message-State: AOJu0YyetYen3VaTpO4guruw9uNWXOCSkw8+dRzCxgkS5D475d/srGaZ j2F+N4sTCNfgTpyxFT4Thdyyt92/jAKQ7IworDQb7qn6zXllGJjXRf/aE/icSoQTZF4XXd32XLf VcmKkWE4BsF/iuZgjObzPJfDDHUhbko+yrHFwIow5Xq++qlKYs/PlKvxwSBhCLOF9 X-Gm-Gg: ASbGncuOntDLBhCKA8IeZEMs0svgUBjL0U7gin6383h7ASlUXf5qf7xqThueFQNG0Bl HrWQfqeuYuWfE67dRxDsdmGbkFkSs8+KZCeRsBqsn2MBDwVmuzWEgVN/9SNEuf/9/hSgbWgsJ+d VZuhDJtfcrJlf980H8YKg9ubr0ZGcSbB1QXNO1lArD+NqFy/2791sj+0svh2LFgiBfCWEek4K+a K8snwEJJuWTU4WWXNPMMlVCZqQzFfoHXP+zmTMwsjOALniceQ9KXpMS2SPAV2oJbgeKpa7V55Dl CpxWHec7VfKFO8LlrdLRu9tjrmkK/w91OqhRIQ== X-Received: by 2002:a05:622a:1a09:b0:467:79fc:b009 with SMTP id d75a77b69052e-467a16beaccmr8769511cf.11.1734029248354; Thu, 12 Dec 2024 10:47:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGvvMQ7lofip2DSWuv2YsHw8pxK/baG/hp3YQw+8Snci4cZdUkEXAtY399JRKgvY3WDHKaA7w== X-Received: by 2002:a05:622a:1a09:b0:467:79fc:b009 with SMTP id d75a77b69052e-467a16beaccmr8769341cf.11.1734029247995; Thu, 12 Dec 2024 10:47:27 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa69c3512f4sm482187966b.2.2024.12.12.10.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 10:47:27 -0800 (PST) Message-ID: Date: Thu, 12 Dec 2024 19:47:24 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/19] arm64: dts: qcom: sm8350: Fix CDSP memory base and length To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Dmitry Baryshkov , Neil Armstrong , Abel Vesa , Sibi Sankar , Luca Weiss Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241209-dts-qcom-cdsp-mpss-base-address-v2-0-d85a3bd5cced@linaro.org> <20241209-dts-qcom-cdsp-mpss-base-address-v2-2-d85a3bd5cced@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241209-dts-qcom-cdsp-mpss-base-address-v2-2-d85a3bd5cced@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UxEL4TeIlqMAOPpbEXTwvwMl6lzDX-mx X-Proofpoint-GUID: UxEL4TeIlqMAOPpbEXTwvwMl6lzDX-mx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=957 malwarescore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412120136 On 9.12.2024 12:02 PM, Krzysztof Kozlowski wrote: > The address space in CDSP PAS (Peripheral Authentication Service) > remoteproc node should point to the QDSP PUB address space > (QDSP6...SS_PUB): 0x0a30_0000 with length of 0x10000. 0x9890_0000, > value used so far, was copied from downstream DTS, is in the middle of > RAM/DDR space and downstream DTS describes the PIL loader, which is a > bit different interface. Datasheet says that one of the main CDSP > address spaces is 0x0980_0000, which is oddly similar to 0x9890_0000, > but quite different. > > Assume existing value (thus downstream DTS) is not really describing the > intended CDSP PAS region. > > Correct the base address and length, which also moves the node to > different place to keep things sorted by unit address. The diff looks > big, but only the unit address and "reg" property were changed. This > should have no functional impact on Linux users, because PAS loader does > not use this address space at all. > > Fixes: 177fcf0aeda2 ("arm64: dts: qcom: sm8350: Add remoteprocs") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad