From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
quic_qiweil@quicinc.com, quic_renjiang@quicinc.com
Subject: Re: [PATCH v3 1/5] media: qcom: iris: Improve format alignment for encoder
Date: Wed, 5 Nov 2025 10:57:00 +0800 [thread overview]
Message-ID: <e924f9f9-88b3-4c0f-a326-80cd80abc765@oss.qualcomm.com> (raw)
In-Reply-To: <0735f540-8085-440c-9c0f-7ac23b52b838@kernel.org>
On 2025/11/4 18:39, Bryan O'Donoghue wrote:
>
> To me reading this patch you seem to have three or four different
> alignment changed bunched into one.
>
> I would prefer to see more granular and specific patches for each change.
>
> Please break this up into more bite size chunks.
>
> ---
> bod
Yes, this patch does two things: first, it uses the actual YUV
resolution for raw resolution instead of the aligned one; second, it
improves the handling of crop_offset.
I will split it into two patches in v4.
--
Best Regards,
Wangao
next prev parent reply other threads:[~2025-11-05 2:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:11 [PATCH v3 0/5] media: qcom: iris: encoder feature enhancements Wangao Wang
2025-11-04 8:11 ` [PATCH v3 1/5] media: qcom: iris: Improve format alignment for encoder Wangao Wang
2025-11-04 10:39 ` Bryan O'Donoghue
2025-11-05 2:57 ` Wangao Wang [this message]
[not found] ` <d21b6376-3b20-4171-9037-a6faf4e438a1@oss.qualcomm.com>
2025-11-06 2:44 ` Wangao Wang
2025-11-04 8:11 ` [PATCH v3 2/5] media: qcom: iris: Add scale support " Wangao Wang
2025-11-04 8:11 ` [PATCH v3 3/5] media: qcom: iris: Add rotation " Wangao Wang
2025-11-04 8:11 ` [PATCH v3 4/5] media: qcom: iris: Add flip " Wangao Wang
2025-11-04 8:11 ` [PATCH v3 5/5] media: qcom: iris: Add intra refresh " Wangao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e924f9f9-88b3-4c0f-a326-80cd80abc765@oss.qualcomm.com \
--to=wangao.wang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox