From: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com
Subject: Re: [PATCH 4/6] dt-bindings: remoteproc: qcom,pas: Document pas for Kaanapali SoCCP
Date: Tue, 14 Oct 2025 12:28:58 +0800 [thread overview]
Message-ID: <e9813a47-c40b-475a-8faf-de0811c9066e@oss.qualcomm.com> (raw)
In-Reply-To: <a8796335-bec3-4c1f-afea-b5b7909d8ba3@kernel.org>
On 10/9/2025 6:27 PM, Krzysztof Kozlowski wrote:
> On 25/09/2025 08:37, Jingyi Wang wrote:
>> +
>> + glink-edge:
>> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
>> + unevaluatedProperties: false
>> + description: |
>
> Drop |
>
>
Will fix
>> + Qualcomm G-Link subnode which represents communication edge, channels
>> + and devices related to the Remoteproc.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - memory-region
>> + - clocks
>> + - clock-names
>> + - interrupts
>> + - interrupt-names
>> + - qcom,smem-states
>> + - qcom,smem-state-names
>> +
>> +unevaluatedProperties: false
>
> That's wrong in this context. But if you add missing (and corrected
> pas-common) then it would make sense.
>
Sorry I didn't get this point, could you make it more clear?
The property for Kaanapali SoCCP doesn't follow qcom,pas-common.yaml
(the interrupts are different) so it was not included here, like
"qcom,qcs404-cdsp-pil.yaml"
So I think just adding the missing "power-domains","power-domain-names"
under "required" will be okay?
Thanks,
Jingyi
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-10-14 4:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 23:37 [PATCH 0/6] Add initial remoteproc support for Kaanapali SoC Jingyi Wang
2025-09-24 23:37 ` [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP Jingyi Wang
2025-09-25 2:19 ` Dmitry Baryshkov
2025-09-29 6:06 ` Jingyi Wang
2025-09-29 9:39 ` Dmitry Baryshkov
2025-09-29 10:11 ` Jingyi Wang
2025-09-29 12:22 ` Dmitry Baryshkov
2025-09-30 2:12 ` Jingyi Wang
2025-09-30 2:16 ` Dmitry Baryshkov
2025-09-30 2:54 ` Jingyi Wang
2025-09-24 23:37 ` [PATCH 2/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP Jingyi Wang
2025-09-25 1:48 ` Krzysztof Kozłowski
2025-09-29 6:20 ` Jingyi Wang
2025-09-29 9:34 ` Dmitry Baryshkov
2025-09-29 9:41 ` Jingyi Wang
2025-09-29 10:03 ` Dmitry Baryshkov
2025-10-09 10:29 ` Krzysztof Kozlowski
2025-10-14 2:12 ` Jingyi Wang
2025-10-23 4:07 ` Jingyi Wang
2025-10-23 6:28 ` Krzysztof Kozlowski
2025-10-24 2:10 ` Jingyi Wang
2025-10-24 7:28 ` Krzysztof Kozlowski
2025-10-24 7:42 ` Jingyi Wang
2025-10-24 7:45 ` Krzysztof Kozlowski
2025-09-24 23:37 ` [PATCH 3/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali MPSS Jingyi Wang
2025-10-09 10:30 ` Krzysztof Kozlowski
2025-09-24 23:37 ` [PATCH 4/6] dt-bindings: remoteproc: qcom,pas: Document pas for Kaanapali SoCCP Jingyi Wang
2025-10-09 10:27 ` Krzysztof Kozlowski
2025-10-14 4:28 ` Jingyi Wang [this message]
2025-10-14 4:47 ` Krzysztof Kozlowski
2025-10-14 5:30 ` Jingyi Wang
2025-10-14 21:57 ` Krzysztof Kozlowski
2025-09-24 23:37 ` [PATCH 5/6] remoteproc: qcom: pas: Add late attach support for subsystems Jingyi Wang
2025-09-25 3:04 ` Dmitry Baryshkov
2025-09-29 6:42 ` Jingyi Wang
2025-09-29 9:35 ` Dmitry Baryshkov
2025-09-29 10:29 ` Jingyi Wang
2025-09-25 5:56 ` Zhongqiu Han
2025-09-29 6:27 ` Jingyi Wang
2025-09-24 23:37 ` [PATCH 6/6] remoteproc: qcom_q6v5_pas: Add SoCCP node on Kaanapali Jingyi Wang
2025-09-25 11:42 ` Konrad Dybcio
2025-09-29 6:27 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9813a47-c40b-475a-8faf-de0811c9066e@oss.qualcomm.com \
--to=jingyi.wang@oss.qualcomm.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox