Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: neil.armstrong@linaro.org, Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] ufs: delegate the interrupt service routine to a threaded irq handler
Date: Mon, 24 Mar 2025 07:02:25 -0400	[thread overview]
Message-ID: <e9f33f59-da1f-426b-8bdd-3c47397abf29@acm.org> (raw)
In-Reply-To: <d084e50e-8b2b-4820-a5e7-25ec440d128e@linaro.org>

On 3/24/25 5:31 AM, Neil Armstrong wrote:
> On 21/03/2025 17:20, Bart Van Assche wrote:
>> - Instead of retaining hba->ufs_stats.last_intr_status and
>>    hba->ufs_stats.last_intr_ts, please remove both members and also
>>    the debug code that reports the values of these member variables.
>>    Please also remove hba->intr_en.
> 
> Hmm ok so no need for the IRQ debug code anymore ? I guess this should
> be in a separate cleanup patch.

Hi Neil,

There are two reasons why I propose to remove that code:
- I don't think that it is possible to keep that code and switch to
   threaded interrupts without a measurable negative performance impact.
- That debug code is primarily useful for hardware (SoC) debugging,
   something that falls outside the scope of the UFS driver.

Thanks,

Bart.

      reply	other threads:[~2025-03-24 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 16:08 [PATCH RFC] ufs: delegate the interrupt service routine to a threaded irq handler Neil Armstrong
2025-03-21 16:20 ` Bart Van Assche
2025-03-24  9:31   ` Neil Armstrong
2025-03-24 11:02     ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f33f59-da1f-426b-8bdd-3c47397abf29@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox