From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: sdx55-fn980: Move "status" property to the end of node
Date: Fri, 31 Mar 2023 21:42:13 +0200 [thread overview]
Message-ID: <ea5d1433-3654-c22a-ce35-bb436d68cca4@linaro.org> (raw)
In-Reply-To: <20230331145915.11653-2-manivannan.sadhasivam@linaro.org>
On 31.03.2023 16:59, Manivannan Sadhasivam wrote:
> To align with rest of the devicetree files, let's move the "status"
> property to the end of the nodes.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 20 ++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> index b73b707342af..91d13c40496c 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> @@ -243,21 +243,21 @@ &ipa {
> };
>
> &pcie_phy {
> - status = "okay";
> -
> vdda-phy-supply = <&vreg_l1e_bb_1p2>;
> vdda-pll-supply = <&vreg_l4e_bb_0p875>;
> -};
>
> -&pcie_ep {
> status = "okay";
> +};
>
> +&pcie_ep {
> pinctrl-names = "default";
> pinctrl-0 = <&pcie_ep_clkreq_default &pcie_ep_perst_default
> &pcie_ep_wake_default>;
>
> reset-gpios = <&tlmm 57 GPIO_ACTIVE_LOW>;
> wake-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
> +
> + status = "okay";
> };
>
> &qpic_bam {
> @@ -265,8 +265,6 @@ &qpic_bam {
> };
>
> &qpic_nand {
> - status = "okay";
> -
> nand@0 {
> reg = <0>;
>
> @@ -277,11 +275,13 @@ nand@0 {
> secure-regions = /bits/ 64 <0x500000 0x500000
> 0xa00000 0xb00000>;
> };
> +
> + status = "okay";
Did you compiletest this?
Konrad
> };
>
> &remoteproc_mpss {
> - status = "okay";
> memory-region = <&mpss_adsp_mem>;
> + status = "okay";
> };
>
> &tlmm {
> @@ -308,16 +308,18 @@ pcie_ep_wake_default: pcie-ep-wake-default-state {
> };
>
> &usb_hsphy {
> - status = "okay";
> vdda-pll-supply = <&vreg_l4e_bb_0p875>;
> vdda33-supply = <&vreg_l10e_3p1>;
> vdda18-supply = <&vreg_l5e_bb_1p7>;
> +
> + status = "okay";
> };
>
> &usb_qmpphy {
> - status = "okay";
> vdda-phy-supply = <&vreg_l4e_bb_0p875>;
> vdda-pll-supply = <&vreg_l1e_bb_1p2>;
> +
> + status = "okay";
> };
>
> &usb {
next prev parent reply other threads:[~2023-03-31 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 14:59 [PATCH 1/2] ARM: dts: qcom: sdx55: Move reset and wake gpios to board dts Manivannan Sadhasivam
2023-03-31 14:59 ` [PATCH 2/2] ARM: dts: qcom: sdx55-fn980: Move "status" property to the end of node Manivannan Sadhasivam
2023-03-31 19:42 ` Konrad Dybcio [this message]
2023-03-31 20:26 ` Krzysztof Kozlowski
2023-03-31 21:06 ` kernel test robot
2023-03-31 19:41 ` [PATCH 1/2] ARM: dts: qcom: sdx55: Move reset and wake gpios to board dts Konrad Dybcio
2023-04-07 23:40 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5d1433-3654-c22a-ce35-bb436d68cca4@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox