From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
robh+dt@kernel.org, davem@davemloft.net, mka@chromium.org,
evgreen@chromium.org, cpratapa@codeaurora.org,
avuyyuru@codeaurora.org, jponduru@codeaurora.org,
subashab@codeaurora.org, elder@kernel.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: add IPA qcom,qmp property
Date: Thu, 3 Feb 2022 05:27:49 -0600 [thread overview]
Message-ID: <eb09c869-c5c6-4be8-5265-072849f1ecd0@linaro.org> (raw)
In-Reply-To: <20220202210638.07b83d41@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2/2/22 11:06 PM, Jakub Kicinski wrote:
> On Tue, 1 Feb 2022 08:07:23 -0600 Alex Elder wrote:
>> At least three platforms require the "qcom,qmp" property to be
>> specified, so the IPA driver can request register retention across
>> power collapse. Update DTS files accordingly.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>> ---
>>
>> Dave, Jakub, please let Bjorn take this through the Qualcomm tree.
>
> I don't know much about DT but the patch defining the property is
> targeting net - will it not cause validation errors? Or Bjorn knows
> to wait for the fixes to propagate? Or it doesn't matter? :)
It might matter sometimes, but in this case it does not.
If the DT property is present but never referenced by the
code, it doesn't matter.
The code in this patch looks up the DT property, and its
behavior is affected by whether the property is there
or not. If it's not there, it's treated as an error
that can be safely ignored.
In the case this fix is actually needed, we'll need
both the code present and DT property defined. If
the code is there but not the property, it's OK, but
the bug won't be fixed quite yet.
-Alex
next prev parent reply other threads:[~2022-02-03 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 14:07 [PATCH] arm64: dts: qcom: add IPA qcom,qmp property Alex Elder
2022-02-03 5:06 ` Jakub Kicinski
2022-02-03 11:27 ` Alex Elder [this message]
2022-02-03 14:44 ` Rob Herring
2022-02-03 20:11 ` Bjorn Andersson
2022-02-04 18:35 ` (subset) " Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2022-04-21 21:59 Alex Elder
2022-04-21 22:00 Alex Elder
2022-04-26 6:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb09c869-c5c6-4be8-5265-072849f1ecd0@linaro.org \
--to=elder@linaro.org \
--cc=agross@kernel.org \
--cc=avuyyuru@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=jponduru@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).