From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B415C0015E for ; Tue, 25 Jul 2023 09:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232856AbjGYJ4K (ORCPT ); Tue, 25 Jul 2023 05:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232395AbjGYJ4J (ORCPT ); Tue, 25 Jul 2023 05:56:09 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DFDE56; Tue, 25 Jul 2023 02:56:08 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36P89NFk011752; Tue, 25 Jul 2023 09:56:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=oxANqKL3T6h0PO+T/varJLfD1W31Y6md6sTVyawLt0c=; b=hIlZNY1UEgblcNX5hiQZTsLsTmfDjhETS64aUjtOxoenZcRN5FpPJZXz8UZoz8PGEsfq c5Xxws/r8JRXtEOVUtr0gAi4/gAdcHmXvyPfDgfoWs/qcJL/5LjBC9pGxwdKAahgsdsQ z22TK/ReFNIlgRa7Saa8HoSQZ9SpbWxRnd+2KGDQgd5HfegkUQy3fqBzuc+LSbE6oIiF PC8svfzfjsJhQruR4W/0VPT2kNaEp+xy3Hnjaw6EGOsEfQKSgD6sdNyl9u0Oi+j32aK9 DfuHH3rXeogeKZFrmCW4sITde3vKvErUzhKyimxYB+sPf0Tmx2fos2rd0eUCPcdHEN8f OQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s29xmgaa5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:56:04 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36P9u3De028457 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 09:56:03 GMT Received: from [10.201.2.96] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 25 Jul 2023 02:55:58 -0700 Message-ID: Date: Tue, 25 Jul 2023 15:25:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH V5 0/3] Introduce the read-modify-write API to collect To: Elliot Berman , Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , "Mukesh Ojha" , Kalle Valo , Loic Poulain , , , CC: , , , References: <20230720070408.1093698-1-quic_kathirav@quicinc.com> Content-Language: en-US From: Kathiravan T In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: CYYs4OKS_Uwbelfl__4nPIsMvAtEufbt X-Proofpoint-GUID: CYYs4OKS_Uwbelfl__4nPIsMvAtEufbt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_05,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 mlxlogscore=823 impostorscore=0 adultscore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250086 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7/25/2023 12:35 AM, Elliot Berman wrote: > > > On 7/20/2023 12:04 AM, Kathiravan T wrote: >> On IPQ platforms, to collect the crashdump, we need to just modify the >> DLOAD bit in the TCSR register. Current infrastructure, overwrites the >> entire regiter value when enabling the crashdump feature, which leads to >> crashdump not gets collected. This series introduce the >> qcom_scm_io_update_field API to achieve the same. >> > > I don't think you describe patch 2 in the subject line or cover > letter. As best I can tell, Patches 2 and 3 are independent. They're > similar only in that they both depend on patch 1. Yeah. I missed that part. I'm thinking of dropping the 2nd patch and send only the patch 1 and patch 3 in the next spin. Once the patch 1 and the another pinctrl patch which Bjorn's is referring [1] (Hopefully, If I am not wrong) is landed in linux-next, I can send out the patch 2 separately. Do let me know if this okay. [1] https://lore.kernel.org/linux-arm-msm/2d790f7e-b373-f0ee-d978-fb78bc4f1ed1@quicinc.com/ > >> Intially this approach is posted by Poovendhan[1], later Mukesh >> integrated this patch in his minidump support series[2]. Based on the >> current feedback on the minidump series, seems it will take sometime to >> get into a good shape, in the meantime these patches doesn't have any >> dependency with the minidump series. As discussed with the Mukesh[3], >> posting these 3 patches to enable the crashdump on IPQ chipsets. >> >> Since the current version of minidump series is V4, I'm posting this as >> a V5. Please let me know if this should be V1. >> >> [1] >> https://lore.kernel.org/linux-arm-msm/20230113160012.14893-4-quic_poovendh@quicinc.com/ >> >> >> [2] >> https://lore.kernel.org/linux-arm-msm/1676990381-18184-3-git-send-email-quic_mojha@quicinc.com/ >> >> >> [3] >> https://lore.kernel.org/linux-arm-msm/d77f5601-2b08-a7c7-1400-7ab68b8add3a@quicinc.com/ >> >> >> >> Mukesh Ojha (3): >>    firmware: qcom_scm: provide a read-modify-write function >>    pinctrl: qcom: Use qcom_scm_io_update_field() >>    firmware: scm: Modify only the download bits in TCSR register >> >>   drivers/firmware/qcom_scm.c            | 26 ++++++++++++++++++++++++-- >>   drivers/pinctrl/qcom/pinctrl-msm.c     | 12 +++++------- >>   include/linux/firmware/qcom/qcom_scm.h |  2 ++ >>   3 files changed, 31 insertions(+), 9 deletions(-) >>