From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v7 08/15] arm64: dts: qcom: x1e80100: Add MIPI CSI PHY nodes
Date: Sun, 13 Jul 2025 10:31:21 +0200 [thread overview]
Message-ID: <eba89d81-1dbb-4eed-8ad9-b49761aab49b@kernel.org> (raw)
In-Reply-To: <ddea072c-c495-4414-a497-a2851211934e@kernel.org>
On 13/07/2025 10:28, Krzysztof Kozlowski wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> index 41245e8592f78edf141141f2f5b7c5b841318f46..e385d6f329616360e089ba352be450c9eca6aab6 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> @@ -5244,6 +5244,94 @@ cci1_i2c1: i2c-bus@1 {
>> };
>> };
>>
>> + csiphy0: csiphy@ace4000 {
>
> phy@
>
> git grep csi.*phy@
> git grep phy@
... although we do have ethernet-phy@ and usb-phy@ accepted, so it could
also be csi-phy@. Up to you.
>
>> + compatible = "qcom,x1e80100-mipi-csi2-combo-phy";
>
> You should clearly express where the bindings are. I see only short
> remark about some driver in v7 changelog, but you have here a weak
> dependency, because this should not be accepted before the bindings
> reach their maintainer and qcom maintainers need to be able to check on
> that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-13 8:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 12:57 [PATCH v7 00/15] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2025-07-11 12:57 ` [PATCH v7 01/15] dt-bindings: media: qcom,x1e80100-camss: Assign correct main register bank to first address Bryan O'Donoghue
2025-07-13 8:15 ` Krzysztof Kozlowski
2025-07-13 9:12 ` Bryan O'Donoghue
2025-07-13 9:34 ` Krzysztof Kozlowski
2025-07-14 6:41 ` Krzysztof Kozlowski
2025-07-11 12:57 ` [PATCH v7 02/15] dt-bindings: media: qcom,x1e80100-camss: Convert from inline PHY definitions to PHY handles Bryan O'Donoghue
2025-07-13 8:18 ` Krzysztof Kozlowski
2025-07-13 8:20 ` Krzysztof Kozlowski
2025-07-13 9:14 ` Bryan O'Donoghue
2025-07-13 9:39 ` Krzysztof Kozlowski
2025-07-13 9:48 ` Bryan O'Donoghue
2025-07-13 10:03 ` Krzysztof Kozlowski
2025-07-11 12:57 ` [PATCH v7 03/15] media: qcom: camss: Add legacy_phy flag to SoC definition structures Bryan O'Donoghue
2025-07-11 12:57 ` [PATCH v7 04/15] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2025-07-16 9:36 ` Loic Poulain
2025-07-16 10:59 ` Bryan O'Donoghue
2025-07-11 12:57 ` [PATCH v7 05/15] media: qcom: camss: Drop legacy PHY descriptions from x1e Bryan O'Donoghue
2025-07-11 12:57 ` [PATCH v7 06/15] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2025-07-11 12:57 ` [PATCH v7 07/15] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2025-07-11 12:58 ` [PATCH v7 08/15] arm64: dts: qcom: x1e80100: Add MIPI CSI PHY nodes Bryan O'Donoghue
2025-07-13 8:28 ` Krzysztof Kozlowski
2025-07-13 8:31 ` Krzysztof Kozlowski [this message]
2025-07-17 20:34 ` Konrad Dybcio
2025-07-11 12:58 ` [PATCH v7 09/15] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2025-07-11 12:58 ` [PATCH v7 10/15] arm64: dts: qcom: x1e80100-crd: Add pm8010 CRD pmic,id=m regulators Bryan O'Donoghue
2025-07-14 9:07 ` Konrad Dybcio
2025-07-11 12:58 ` [PATCH v7 11/15] arm64: dts: qcom: x1e80100-crd: Add ov08x40 RGB sensor on CSIPHY4 Bryan O'Donoghue
2025-07-14 13:28 ` Konrad Dybcio
2025-07-11 12:58 ` [PATCH v7 12/15] arm64: dts: qcom: x1e80100-t14s: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2025-07-14 13:29 ` Konrad Dybcio
2025-07-11 12:58 ` [PATCH v7 13/15] arm64: dts: qcom: x1e80100-t14s: Add on ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2025-07-11 12:58 ` [PATCH v7 14/15] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2025-07-11 12:58 ` [PATCH v7 15/15] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add OV02E10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2025-07-15 6:53 ` [PATCH v7 00/15] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Vladimir Zapolskiy
2025-07-15 7:01 ` Krzysztof Kozlowski
2025-07-15 7:19 ` Vladimir Zapolskiy
2025-07-15 7:46 ` Krzysztof Kozlowski
2025-07-15 8:48 ` Bryan O'Donoghue
2025-07-15 10:27 ` Vladimir Zapolskiy
2025-07-15 11:16 ` Bryan O'Donoghue
2025-07-15 13:08 ` Vladimir Zapolskiy
2025-07-15 13:22 ` Bryan O'Donoghue
2025-07-15 15:25 ` Vladimir Zapolskiy
2025-07-16 13:17 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba89d81-1dbb-4eed-8ad9-b49761aab49b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).