From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 1/2] soc: qcom: cmd-db: replace strncpy() with strscpy_pad()
Date: Mon, 20 Jun 2022 20:38:30 +0200 [thread overview]
Message-ID: <ec29b0be-c388-dc3d-a169-acc719e8cefc@linaro.org> (raw)
In-Reply-To: <20220519073301.7072-1-krzysztof.kozlowski@linaro.org>
On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy. This fixes W=1 warning:
>
> drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_get_header.part.0’:
> drivers/soc/qcom/cmd-db.c:151:9: warning: ‘strncpy’ specified bound 8 equals destination size [-Wstringop-truncation]
> 151 | strncpy(query, id, sizeof(query));
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Any comments on the set?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-20 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:33 [PATCH v2 1/2] soc: qcom: cmd-db: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/2] soc: qcom: correct kerneldoc Krzysztof Kozlowski
2022-06-20 18:38 ` Krzysztof Kozlowski [this message]
2022-06-27 20:02 ` [PATCH v2 1/2] soc: qcom: cmd-db: replace strncpy() with strscpy_pad() Bjorn Andersson
2022-06-27 23:06 ` Doug Anderson
2022-06-27 23:18 ` Doug Anderson
2022-06-28 9:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec29b0be-c388-dc3d-a169-acc719e8cefc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox