From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6321A9B46 for ; Fri, 3 Oct 2025 07:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759474856; cv=none; b=poiCcgquM4mCUl90gb9VlUX+kVPp06xBu9N4U38AQgC54Ea0qY1pASNoefl2bfJeJfiBpuoER0RUluHAOKbXyDvMVIxP6IK9JNklwD4tFQW0PmOxzOdNGOUU7NJpjxMBcRqWc8Sfyr5OHc34JNxcbsu7djg6PxPRFnd9O5onmfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759474856; c=relaxed/simple; bh=5Exm/8PLdaYIQsbxEm7CrsQS0hKOILQWwFq03IzluZo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oQO4Dbp0asJQ8glFnhI3dvdeZfO9w44YmndL6uRVOPZw0DdxQveRcRRK4OR2s1kjhJfbbVWKdlOhoMWzmyiQ+dw2XxtVy89DHXBHrvKXVmWqjiO5mYoM0SHiti9gAL+OupsxtT/J+iifSwVe4C8XIgk+LmLTQ6YWa8nfyLa0lz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NBs5Rh5g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NBs5Rh5g" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 592Ks43p024838 for ; Fri, 3 Oct 2025 07:00:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Co5VzprZsR81aFpnYkYXzmF6KQjbt0d229OVKm0YBpM=; b=NBs5Rh5giHTu0yIG fp3IUgm2pJos2/MW3R/9TvxauMsylD+rNDtBlCQWXTj2lG4mgTtlj/tc8jzPqRwp 9p9thZzJNaiS+0drtWdS+gFdWJ1WewKKeGyBNs3GP+FkthMom72/HRve+yLV0iPD Pe13nZuQ/Z1OaITbRrRevj9YJqDUBpMi8U8CUElBi8U0uocGYaqrCh5eHm4spqPz I0N/Hy+y5l9fa5tm+FIT0fcXy2PgpKMRgjZx+m+rnrM2yRMxwvtXBc4F1q8M9t+Z CLLwAqWJmAnJyOF37CKywJ84MlLpV+09p4hVf713stV3IDmzsuo7H4ciA4+KoO+4 NBzulg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e9781ur0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 03 Oct 2025 07:00:53 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-28e8112143fso27166215ad.2 for ; Fri, 03 Oct 2025 00:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759474852; x=1760079652; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Co5VzprZsR81aFpnYkYXzmF6KQjbt0d229OVKm0YBpM=; b=NZfZ7WfT4sCtT2hfeY2PxEAfNLIn2bHENPMkS5rgzIcc2McPs7FXmbbzNgow6f1wSD 8WtCYHpUvtK0r2bA6UmvJH00aGexiCgqnCaapQJ6Co1tiHuzJNZJwg6hfL8D50QYYMoo e1oxcr/2hVm/pen4Cj47UQNJtcLweUf/ttUyAgVeoy53hL+uBY+5QA6CP+gXVU9iyUGf gVeAq9W6ydK7v4fzt+o4fKhnEjh6UxUq6n9HZwQB3LI03+bpScfp9AS0h+z1uQYQCnXU aLPQCVoopDSnnrwgUih/Wwnx1suKAYjJCs47lqdtQKc7L55Lhzrjph0FGnpwalj+055W 2R5g== X-Forwarded-Encrypted: i=1; AJvYcCVfEfKkpc1apMOcltNLuAhKhfFBp5tUjmjEYnWkIK2GXvxo7wuz9qulyJpNtok7HLw6lPp5zl4vlnQZCRIw@vger.kernel.org X-Gm-Message-State: AOJu0YxRpd43pe6vfOU9YIeb6CVVrehqRT4FVd2RDn7gQUOLi6LKje4e seWQpaNqFlAc/YdCx+f2zZQx+msB0Osr+fmhXv09CJlmysD8amYDc3Ltw07WNrAJIUTCoQa7K5C fAN4kE+/2Jiqn4FaQJ12rbCyGFDo3eiH4oW8dcpSwOqOLmc4D9h3kDyKPuGJhxEuENj3y7E/RKX kb X-Gm-Gg: ASbGnctje6JEjOrbn3KnRrrW6+4OgNvHT3+OSTIaPnllUzQT90Ff2rPOEBCGHFXFxen wvKm5nlxWW3cfwQp+cznNz6uFin9/KLwtGXzgED4MfV4JmPML79r6oxSj3d6sdABn4ENNg9BZl+ LKajrlC1jXmdIBcBqvN47utCBLP1qMDWgLvbzzPn663CbMxzG5Ukas2a6Jnal1HbOYf+GYYICsI giKaxxStKffSx4WoOZnMz2rrSOvObs1TRcwWMsbfUvFIIvHO2naF4LM1lB83/rZDsJi5K+RaZoB TtPmL4K6XdGcfIhew32JKuuyWI62yasBz6gxknjsl+4mfOE2gSi1tbNbqWpjs/SCRVvJctK5YUT OYkXcIrCm X-Received: by 2002:a17:903:287:b0:26d:d860:3db1 with SMTP id d9443c01a7336-28e9a56700amr25147435ad.24.1759474852284; Fri, 03 Oct 2025 00:00:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHryjKfAj9HgoLio+jseaVb7X04rOxIe8KAqRAkzFtrkbcwQLuvAuQxIWXpvFYBtK4NEGv3tQ== X-Received: by 2002:a17:903:287:b0:26d:d860:3db1 with SMTP id d9443c01a7336-28e9a56700amr25147165ad.24.1759474851714; Fri, 03 Oct 2025 00:00:51 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d126012sm40739195ad.41.2025.10.03.00.00.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Oct 2025 00:00:51 -0700 (PDT) Message-ID: Date: Fri, 3 Oct 2025 12:30:45 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ASoC: codecs: lpass-macro: Add support for channel map mixer control To: Alexey Klimov Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com, prasad.kumpatla@oss.qualcomm.com References: <20250902062300.212021-1-mohammad.rafi.shaik@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FzLxTSGqMAp9Otr6chsOx2rM3m1kihod X-Proofpoint-ORIG-GUID: FzLxTSGqMAp9Otr6chsOx2rM3m1kihod X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDA0MyBTYWx0ZWRfX/0x0OZQLnEFG AtVFtaAbhAHS7UeSY2W+No2OXDNzj8wxzr+jK/X0zut1qJ7mk17gClDioPfLvHDia3QBc4PmGDH utq/pvrm52iHkiWKvWWFTaXQn0boSVZuL9wLFmCQ1VrNWh4HIzdLa9RpOE5v+EczqHe8FvTaQUd mv8Kri5i184jvV8BrmJcn8KVKgT1U9BL2KR0123OmJ1OSCi9T9CLb+R9Hbl7W4Rz4teXkxw7bCj wjYvsPz8gfY7sMd7DMQDL5gEXWT/4qUWFmjM2FMkncJHyaz3KIPTbfsAc/0MrIu4dlqsr6Tw9OQ q9j7eC7F3PeElAlW2vq1JtI9DYYQBS7qiQK94Y2jk8Cfky8gj5tw27Nw6TIWFOHgo9EoCRbSyvP qiAHbXPcJnsC49Nf3zAVbqP8KsHVbw== X-Authority-Analysis: v=2.4 cv=Sf36t/Ru c=1 sm=1 tr=0 ts=68df74a5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=onMMKnJRGUs5ctigZmYA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-03_01,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270043 On 10/1/2025 7:36 PM, Alexey Klimov wrote: > On Tue Sep 2, 2025 at 7:23 AM BST, Mohammad Rafi Shaik wrote: >> Introduce the channel map mixer control support for LPASS macro >> codec Digital Audio Interfaces (DAIs). The channel map mixer controls >> are required by APPS to configure usecase-specific audio routing and > > What is APPS here? Will be good to have this abbreviation or acronym explained. > Ack, will write proper commit description. >> channel mapping. >> >> Signed-off-by: Mohammad Rafi Shaik >> --- >> Changes in v2: >> - Updated patch with improved commit description.. >> - Link to v1: https://lore.kernel.org/linux-sound/20240930053111.3986838-1-quic_mohs@quicinc.com/ >> --- >> sound/soc/codecs/lpass-macro-common.c | 55 +++++++++++++++++++++++++++ >> sound/soc/codecs/lpass-macro-common.h | 2 + >> sound/soc/codecs/lpass-rx-macro.c | 12 ++++++ >> sound/soc/codecs/lpass-tx-macro.c | 9 +++++ >> sound/soc/codecs/lpass-va-macro.c | 9 +++++ >> sound/soc/codecs/lpass-wsa-macro.c | 12 ++++++ >> 6 files changed, 99 insertions(+) >> >> diff --git a/sound/soc/codecs/lpass-macro-common.c b/sound/soc/codecs/lpass-macro-common.c >> index 6e3b8d0897dd..777af4885245 100644 >> --- a/sound/soc/codecs/lpass-macro-common.c >> +++ b/sound/soc/codecs/lpass-macro-common.c >> @@ -8,12 +8,67 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include "lpass-macro-common.h" >> >> static DEFINE_MUTEX(lpass_codec_mutex); >> static enum lpass_codec_version lpass_codec_version; >> >> +static int lpass_macro_chmap_ctl_get(struct snd_kcontrol *kcontrol, >> + struct snd_ctl_elem_value *ucontrol) >> +{ >> + struct snd_pcm_chmap *info = snd_kcontrol_chip(kcontrol); >> + struct snd_soc_dai *dai = info->private_data; >> + u32 *chmap_data = NULL; > > You probably don't need to set it to NULL here, if it will be overwritten > by kzalloc() call few lines below > Ack, will fix in next version. Thanks & Regards, Rafi. >> + u32 rx_ch_cnt = 0; >> + u32 tx_ch_cnt = 0; >> + u32 rx_ch, tx_ch; >> + >> + chmap_data = kzalloc(sizeof(u32) * 2, GFP_KERNEL); > > here. > > [..] > > Thanks, > Alexey > >