From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B382C77B73 for ; Thu, 20 Apr 2023 10:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbjDTKvP (ORCPT ); Thu, 20 Apr 2023 06:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234800AbjDTKus (ORCPT ); Thu, 20 Apr 2023 06:50:48 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B2CF9EE7 for ; Thu, 20 Apr 2023 03:48:41 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4ec8c2907c9so455550e87.3 for ; Thu, 20 Apr 2023 03:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681987716; x=1684579716; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zD279to/6+TWBjoIw2UrrbMEO+Ablbs2o2Hy3tbTBkU=; b=mMrqFoBNZuSiQTHDl6RiYeOcsEwVDcJfjwzaboiWvmgOt+9p5li6YIWwS5uR+n4pPn WmGY9LGOfKQNGtWrXGAngiXl+SOQuXzWNuYkK4UACYMUJGLrr8f4wokicHnzixv/eZ7Y 7a3xUjOGpBA2qYRqrNYv4AtVI19nssn2qfOmP6RCe3WMK1kjr9QpmaSpnZ/Umbe1Cppg HLCOKwOZSPKangyDezrABfIVNdL+BKsgz/8vgcZJnIkFJpayyc0sMtTwGnUjkRyNhubX /+LHHPtZMgOSob+l2TdsA1t3TMFp1u7LAiJ5QfurdDOpmv2i4Gg/FsgpLBJF/xyMh4N8 ReKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681987716; x=1684579716; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zD279to/6+TWBjoIw2UrrbMEO+Ablbs2o2Hy3tbTBkU=; b=MbVTvrRrV/EmGRFlP4GdAyk5brOwNCoXwl66zXiRUSRDe7IZgg6jXwrs58Yop/8Y3G u2t0ol4sbXbZpvwkSKU7VnOrk7WBMIIunOnx58vjj3IOBg4l5+JOR5YBtk+4WrYRlZO4 8jVDPsBq4M9l6VPVWw4Q7zOMpaKsDP47YWjn4QMBgZgTnb5G0GlfhSK9551mlEnyQQ9W E+3Wz1bx97mHpWEg6S0HCmG8h+1YYAz8iWa3hZT93nv5hP1F2rJ/yZUZv5w2DE46FPqK R7Ai58EwxlCabR5Flivpxx+HrdBU9RpaJK8tLgkFfMYx1TaEKPz3WdSfM4dERH4umuFE YwdA== X-Gm-Message-State: AAQBX9fQOntLWBdwgO8GslV6Q4/WL4ZID8+QlcqvvwkUEO8ibasfyt8s RKP045vmx+65sWKtnoiLLLIfhw== X-Google-Smtp-Source: AKy350aYVhOqGSVtBNCUjrt2Wb+KoklVOmlz2MrxgriDUwHxa3b2uAyhI8S5/FzTyVfeD5juU5G1kg== X-Received: by 2002:a05:6512:401:b0:4dd:9b6b:6b5b with SMTP id u1-20020a056512040100b004dd9b6b6b5bmr370391lfk.16.1681987716564; Thu, 20 Apr 2023 03:48:36 -0700 (PDT) Received: from [192.168.1.101] (abyj144.neoplus.adsl.tpnet.pl. [83.9.29.144]) by smtp.gmail.com with ESMTPSA id a5-20020a056512374500b004db3d57c3a8sm178161lfs.96.2023.04.20.03.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 03:48:36 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 12:48:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230420075053.41976-1-krzysztof.kozlowski@linaro.org> <20230420075053.41976-6-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230420075053.41976-6-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20.04.2023 09:50, Krzysztof Kozlowski wrote: > GPIO LEDs is not a bus, so drop unit-address and also start suffix > numbering from 0: > > Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 +- > arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts > index 47a5d1849c72..52eadefd2fb4 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts > +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts > @@ -203,7 +203,7 @@ leds { > pinctrl-0 = <&leds_pins>; > pinctrl-names = "default"; > > - led@7 { > + led-0 { > label = "rb3011:green:user"; > color = ; > gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>; > diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi > index 411c8d63c38e..c5abe7151f14 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi > @@ -92,34 +92,34 @@ leds { > pinctrl-0 = <&leds_pins>; > pinctrl-names = "default"; > > - led@7 { > + led-0 { > label = "led_usb1"; > gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "usbdev"; > default-state = "off"; > }; > > - led@8 { > + led-1 { > label = "led_usb3"; > gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "usbdev"; > default-state = "off"; > }; > > - led@9 { > + led-2 { > label = "status_led_fail"; > function = LED_FUNCTION_STATUS; > gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>; > default-state = "off"; > }; > > - led@26 { > + led-3 { > label = "sata_led"; > gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>; > default-state = "off"; > }; > > - led@53 { > + led-4 { > label = "status_led_pass"; > function = LED_FUNCTION_STATUS; > gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;