From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, mturquette@baylibre.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
dmitry.baryshkov@linaro.org, jonathan@marek.ca,
robert.foss@linaro.org
Subject: Re: [PATCH 1/2] clk: qcom: camcc-sm8250: Fix absent mmcx regulator reference
Date: Tue, 27 Jul 2021 19:31:37 +0100 [thread overview]
Message-ID: <ed6e31a9-fb07-458d-e791-d2ebad0b8fb3@linaro.org> (raw)
In-Reply-To: <162741055915.2368309.10049224467908332702@swboyd.mtv.corp.google.com>
On 27/07/2021 19:29, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-07-07 21:03:06)
>> On Wed 07 Jul 20:08 CDT 2021, Bryan O'Donoghue wrote:
>>
>>> The current implementation omits the necessary mmcx supply, which means if
>>> you are running the code for this block and a prior clock driver, like say
>>> the videocc hasn't run, then a reset will be generated the first time we
>>> touch these registers.
>>>
>>> Fixes: 5d66ca79b58c ("clk: qcom: Add camera clock controller driver for SM8250")
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>
>> camcc isn't enabled in the upstream dts yet and I expect that we're
>> going to conclude on defining these GDSCs as subdomains of the cc's
>> power-domain in time for v5.15.
>>
>> I don't mind if Stephen picks this to make sure the driver is
>> functional, but I will hold off on the dts change.
>>
>
> Seems like this is superseded by the GDSC patches that use subdomains
> instead of a fake supply?
>
yep
next prev parent reply other threads:[~2021-07-27 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 1:08 [PATCH 0/2] Fix and enable camcc-sm8250 Bryan O'Donoghue
2021-07-08 1:08 ` [PATCH 1/2] clk: qcom: camcc-sm8250: Fix absent mmcx regulator reference Bryan O'Donoghue
2021-07-08 4:03 ` Bjorn Andersson
2021-07-27 18:29 ` Stephen Boyd
2021-07-27 18:31 ` Bryan O'Donoghue [this message]
2021-07-08 1:08 ` [PATCH 2/2] arm64: dts: qcom: sm8250: Add camcc DT node Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6e31a9-fb07-458d-e791-d2ebad0b8fb3@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox