From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
swboyd@chromium.org, krzysztof.kozlowski+dt@linaro.org,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
broonie@kernel.org, quic_plai@quicinc.com,
konrad.dybcio@somainline.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rohkumar@quicinc.com, quic_visr@quicinc.com
Subject: Re: [PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration
Date: Fri, 31 Mar 2023 11:30:47 +0200 [thread overview]
Message-ID: <ed9f10e6-a2fe-1c75-a667-4dbdb91327c2@linaro.org> (raw)
In-Reply-To: <20230327163249.1081824-5-quic_mohs@quicinc.com>
On 27/03/2023 18:32, Mohammad Rafi Shaik wrote:
> The qdsp6ss memory region is being shared by ADSP remoteproc device and
> lpasscc clock device, hence causing memory conflict.
> As the qdsp6ss clocks are being enabled in remoteproc driver, remove the
> qdsp6ss clock registration.
>
> Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280")
I don't understand why this is a fix. The clocks were working before,
right? So removing them is both ABI break and not a fix.
More over, this *cannot* be backported because it will break users, thus
Fixes tag is here misleading stable folks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-31 9:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:32 [PATCH v1 0/4] Remove the qdsp6ss register from lpasscc Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 1/4] arm64: dts: qcom: sc7280: Modify lpasscc node name Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 2/4] dt-bindings: clock: qcom,sc7280-lpasscc: Remove qdsp6ss register region Mohammad Rafi Shaik
2023-03-31 9:29 ` Krzysztof Kozlowski
2023-03-27 16:32 ` [PATCH v1 3/4] arm64: dts: qcom: sc7280: Remove qdsp6ss regmap region Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration Mohammad Rafi Shaik
2023-03-29 3:11 ` Stephen Boyd
2023-03-29 9:24 ` Mohammad Rafi Shaik
2023-03-29 17:57 ` Stephen Boyd
2023-03-31 9:30 ` Krzysztof Kozlowski [this message]
2023-03-27 17:41 ` [PATCH v1 0/4] Remove the qdsp6ss register from lpasscc Stephen Boyd
2023-03-28 6:02 ` Mohammad Rafi Shaik
2023-03-28 17:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9f10e6-a2fe-1c75-a667-4dbdb91327c2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_mohs@quicinc.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_visr@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox