From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: kernel@quicinc.com, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition
Date: Sat, 22 Feb 2025 11:47:13 +0100 [thread overview]
Message-ID: <edfd6c6a-65d2-42f1-8225-0808359dd375@kernel.org> (raw)
In-Reply-To: <20250221-trace-noc-driver-v1-1-0a23fc643217@quicinc.com>
On 21/02/2025 08:40, Yuanfang Zhang wrote:
> Adds new coresight-tnoc.yaml file describing the bindings required
> to define Trace NOC in the device trees.
>
> Signed-off-by: Yuanfang Zhang <quic_yuanfang@quicinc.com>
So you just sent the same v1, ignoring previous review. That's not how
it works.
Provide proper changelog, implement ENTIRE feedback and do no ask
maintainers do point the same issues TWICE.
NAK
<form letter>
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-22 10:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 7:40 [PATCH 0/5] coresight: Add Coresight Trace NOC driver Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition Yuanfang Zhang
2025-02-21 23:53 ` Rob Herring
2025-02-28 7:20 ` Yuanfang Zhang
2025-02-22 10:47 ` Krzysztof Kozlowski [this message]
2025-02-26 10:52 ` Yuanfang Zhang
2025-02-26 11:07 ` Krzysztof Kozlowski
2025-02-28 7:29 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 2/5] coresight: add coresight Trace NOC driver Yuanfang Zhang
2025-02-22 10:54 ` Krzysztof Kozlowski
2025-02-26 10:44 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 3/5] coresight-tnoc: add nodes to configure flush Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 4/5] coresight-tnoc: add node to configure flag type Yuanfang Zhang
2025-02-22 10:55 ` Krzysztof Kozlowski
2025-02-28 7:44 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 5/5] coresight-tnoc: add nodes to configure freq packet Yuanfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edfd6c6a-65d2-42f1-8225-0808359dd375@kernel.org \
--to=krzk@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox