From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Nischal Subject: Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845 Date: Mon, 06 Aug 2018 14:37:18 +0530 Message-ID: References: <1528285308-25477-1-git-send-email-anischal@codeaurora.org> <1528285308-25477-3-git-send-email-anischal@codeaurora.org> <153111693472.143105.11303543263643845656@swboyd.mtv.corp.google.com> <1e6d9fc284c3c118203728867f504ec6@codeaurora.org> <153250192252.48062.9210075387954345932@swboyd.mtv.corp.google.com> <07e0321116993d27d6585bd1a186328d@codeaurora.org> <153324986956.10763.5124619734269160725@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <153324986956.10763.5124619734269160725@swboyd.mtv.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Michael Turquette , Andy Gross , David Brown , Rajendra Nayak , Odelu Kukatla , Taniya Das , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 2018-08-03 04:14, Stephen Boyd wrote: > Quoting Amit Nischal (2018-07-30 04:28:56) >> On 2018-07-25 12:28, Stephen Boyd wrote: >> > >> > Ok. Sounds good! Is the rate range call really needed? It can't be >> > determined in the PLL code with some table or avoided by making sure >> > GPU >> > uses OPP table with only approved frequencies? >> > >> >> Currently fabia PLL code does not have any table to check this and >> intention >> was to avoid relying on the client to call set_rate with only approved >> frequencies so we have added the set_rate_range() call in the GPUCC >> driver >> in order to set the rate range. >> > > But GPU will use OPP so it doesn't seem like it really buys us anything > here. And it really doesn't matter when the clk driver implementation > doesn't use the min/max to clamp the values of the round_rate() call. > Is > that being done here? I need to double check. I would be more convinced > if the implementation was looking at min/max to constrain the rate > requested. > So our understanding is that GPU(client) driver will always call the set_rate with approved frequencies only and we can completely rely on the client. Is our understanding is correct? > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html