From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03720C433EF for ; Wed, 13 Apr 2022 09:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233591AbiDMJLK (ORCPT ); Wed, 13 Apr 2022 05:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234262AbiDMJLH (ORCPT ); Wed, 13 Apr 2022 05:11:07 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A32A527E8; Wed, 13 Apr 2022 02:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649840923; x=1681376923; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=+YA29YZhcDAQNiqZ2SepI8k+n2MV8/k87giI4s9WskI=; b=ctD6+LX3fQ1aWm/+XnHOhVL9eNtATrDn029bQc4fVFIjbcR52d7xcYAY p4QmFWINd6kI10andDqIbvelwfhsfQfzUcguRHeMmvsBHL7SGzCMibPxo j+BJx5M6/e4NUwNQ9PI/mUYLok8/fvUVVqnyV5qoAEhkiyRWF9skJMbx0 U=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 13 Apr 2022 02:08:42 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 02:08:42 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Apr 2022 02:08:42 -0700 Received: from [10.216.14.96] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Apr 2022 02:08:36 -0700 Subject: Re: [PATCH v13 2/6] usb: dwc3: core: Host wake up support from system suspend To: Matthias Kaehlcke CC: Pavan Kondeti , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Mathias Nyman , Krzysztof Kozlowski , , , , , , , References: <1649704614-31518-1-git-send-email-quic_c_sanm@quicinc.com> <1649704614-31518-3-git-send-email-quic_c_sanm@quicinc.com> <36d22ad7-7f11-2f63-cd68-5d564476161e@quicinc.com> <20220412050018.GB2627@hu-pkondeti-hyd.qualcomm.com> <259c9e87-a52e-c063-7901-2c6decd42675@quicinc.com> From: "Sandeep Maheswaram (Temp)" Message-ID: Date: Wed, 13 Apr 2022 14:38:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Matthias, On 4/13/2022 12:35 AM, Matthias Kaehlcke wrote: > On Tue, Apr 12, 2022 at 12:08:02PM +0530, Sandeep Maheswaram (Temp) wrote: >> Hi Pavan, >> >> On 4/12/2022 10:30 AM, Pavan Kondeti wrote: >>> Hi Sandeep, >>> >>> On Tue, Apr 12, 2022 at 10:16:39AM +0530, Sandeep Maheswaram (Temp) wrote: >>>> Hi Matthias, >>>> >>>> On 4/12/2022 2:24 AM, Matthias Kaehlcke wrote: >>>>> On Tue, Apr 12, 2022 at 12:46:50AM +0530, Sandeep Maheswaram wrote: >>>>>> During suspend read the status of all port and set hs phy mode >>>>>> based on current speed. Use this hs phy mode to configure wakeup >>>>>> interrupts in qcom glue driver. >>>>>> >>>>>> Check wakep-source property for dwc3 core node to set the >>>>> s/wakep/wakeup/ >>>> Okay. Will update in next version. >>>>>> wakeup capability. Drop the device_init_wakeup call from >>>>>> runtime suspend and resume. >>>>>> >>>>>> Also check during suspend if any wakeup capable devices are >>>>>> connected to the controller (directly or through hubs), if there >>>>>> are none set a flag to indicate that the PHY is powered >>>>>> down during suspend. >>>>>> >>>>>> Signed-off-by: Sandeep Maheswaram >>>>>> --- >>>>> A per-patch change log would be really helpful for reviewers, even >>>>> if it doesn't include older versions. >>>> Okay. Will update in next version. >>>>>> drivers/usb/dwc3/core.c | 33 ++++++++++++++++++++------------- >>>>>> drivers/usb/dwc3/core.h | 4 ++++ >>>>>> drivers/usb/dwc3/host.c | 25 +++++++++++++++++++++++++ >>>>>> 3 files changed, 49 insertions(+), 13 deletions(-) >>>>>> >>>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>>>>> index 1170b80..effaa43 100644 >>>>>> --- a/drivers/usb/dwc3/core.c >>>>>> +++ b/drivers/usb/dwc3/core.c >>>>>> @@ -32,6 +32,7 @@ >>>>>> #include >>>>>> #include >>>>>> #include >>>>>> +#include >>>>>> #include "core.h" >>>>>> #include "gadget.h" >>>>>> @@ -1723,6 +1724,7 @@ static int dwc3_probe(struct platform_device *pdev) >>>>>> platform_set_drvdata(pdev, dwc); >>>>>> dwc3_cache_hwparams(dwc); >>>>>> + device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source")); >>>>>> spin_lock_init(&dwc->lock); >>>>>> mutex_init(&dwc->mutex); >>>>>> @@ -1865,6 +1867,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) >>>>>> { >>>>>> unsigned long flags; >>>>>> u32 reg; >>>>>> + struct usb_hcd *hcd = platform_get_drvdata(dwc->xhci); >>>>>> switch (dwc->current_dr_role) { >>>>>> case DWC3_GCTL_PRTCAP_DEVICE: >>>>>> @@ -1877,10 +1880,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) >>>>>> dwc3_core_exit(dwc); >>>>>> break; >>>>>> case DWC3_GCTL_PRTCAP_HOST: >>>>>> - if (!PMSG_IS_AUTO(msg)) { >>>>>> - dwc3_core_exit(dwc); >>>>>> - break; >>>>>> - } >>>>>> + dwc3_check_phy_speed_mode(dwc); >>>>>> /* Let controller to suspend HSPHY before PHY driver suspends */ >>>>>> if (dwc->dis_u2_susphy_quirk || >>>>>> @@ -1896,6 +1896,16 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) >>>>>> phy_pm_runtime_put_sync(dwc->usb2_generic_phy); >>>>>> phy_pm_runtime_put_sync(dwc->usb3_generic_phy); >>>>>> + >>>>>> + if (!PMSG_IS_AUTO(msg)) { >>>>>> + if (device_may_wakeup(dwc->dev) && >>>>>> + usb_wakeup_enabled_descendants(hcd->self.root_hub)) { >>>>> You did not answer my question on v12, reposting it: >>>>> >>>>> Did you ever try whether you could use device_children_wakeup_capable() from >>>>> [1] instead of usb_wakeup_enabled_descendants()? >>>>> >>>>> [1] https://patchwork.kernel.org/project/linux-usb/patch/1635753224-23975-2-git-send-email-quic_c_sanm@quicinc.com/#24566065 >>>> Sorry ..I have replied in mail yesterday but it is not showing up in >>>> patchwork link. >>>> >>>> Tried with  device_children_wakeup_capable(dwc->dev) instead of >>>> usb_wakeup_enabled_descendants and it always returns true even >>>> >>>> when no devices are connected. >>>> >>> What do you mean by when no devices are connected? There is always >>> root hub connected and we should not power down the DWC3 here even >>> when remote wakeup for root hub is enabled. Essentially >>> usb_wakeup_enabled_descendants() returns true even without any >>> physical devices connected. >>> >>> What does device_children_wakeup_capable() do? Sorry, I could not >>> find this function definition. >>> >>> Thanks, >>> Pavan >> usb_wakeup_enabled_descendants() doesn't consider hubs. It only returns true if any devices >> are connected with wakeup capability apart from hubs. > Actually it considers hubs: > > unsigned usb_wakeup_enabled_descendants(struct usb_device *udev) > { > struct usb_hub *hub = usb_hub_to_struct_hub(udev); > > return udev->do_remote_wakeup + > (hub ? hub->wakeup_enabled_descendants : 0); > } > > 'udev' may or may not be a hub, if 'do_remote_wakeup' is set then the > device is considered a wakeup enabled descendant. > > And for system suspebd 'do_remote_wakeup' is set based on the wakeup > config of the device: > > static void choose_wakeup(struct usb_device *udev, pm_message_t msg) > { > ... > w = device_may_wakeup(&udev->dev); > ... > udev->do_remote_wakeup = w; > } > > I checked on three systems with different Linux distributions, on all of > the wakeup flag of a connected hub is 'disabled'. Wakeup still works, so > apparently that flag doesn't really have an impact for child ports. > >> If we consider hubs also dwc3 core exit and phy exit will never be called. >> >> device_children_wakeup_capable() implementation was shared by Matthias in below thread >> https://patchwork.kernel.org/project/linux-usb/patch/1635753224-23975-2-git-send-email-quic_c_sanm@quicinc.com/#24566065 >> >> Probably device_children_wakeup_capable() is returning true because it considers hubs also. > I thought I did a basic test when I sent the patch, I did another (?) one > with v13 of your patch set. In this tests with a hub connected the > function returns true when an HID device is connected, and false when > nothing is connected. The wakeup flag of the hub is disabled (default). > > Sandeep, are the wakeup flags of the child hub(s) set to 'enabled' on > the system you tested on? The wakeup flags of hub is 'disabled' on system I tested. What is the input param you are giving to device_children_wakeup_capable() function ? I was passing the dwc->dev like this device_children_wakeup_capable(dwc->dev) .Is it right? Regards Sandeep