Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi

Zijun Hu
2026-03-25T10:59:51Z

On 3/25/2026 3:08 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 25, 2026 at 02:40:19PM +0800, Zijun Hu wrote:
>> On 3/24/2026 9:16 AM, Dmitry Baryshkov wrote:
>>>> +
>>>> + wcn7850-pmu {
>>>> + compatible = "qcom,wcn7850-pmu";
>>>> +
>>>> + pinctrl-0 = <&bt_default>, <&sw_ctrl_default>, <&wlan_en>;
>>>> + pinctrl-names = "default";
>>>> +
>>>> + bt-enable-gpios = <&pmh0104_j_e1_gpios 5 GPIO_ACTIVE_HIGH>;
>>>> + wlan-enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
>>> swctrl-gpios?
>>
>> it is '<&sw_ctrl_default>' within 'pinctrl-0' above.
>> the input pin is not used by power sequencing driver.
>> just give it some default configurations here.
>
> Please don't mix hardware description and the driver. If the pin is
> wired, let's describe it in DT.
>

give comments about that pin in this dts file ?
or give a seperated patch to describe the pin in DT binding schema of "qcom,wcn7850-pmu"?