Re: [PATCH 2/6] arm64: dts: qcom: kaanapali-mtp: Add PMIC support

Dmitry Baryshkov
2026-03-24T01:13:56Z

On Sun, Mar 22, 2026 at 11:19:42PM -0700, Jingyi Wang wrote:
> From: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>
> Include PMIC files used on Kaanapali MTP boards. Add configurations for
> keys (volume up and volume down), RGB LEDs and flash LEDs.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 92 ++++++++++++++++++++++++++++++
> 1 file changed, 92 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> index bc57935c042c..5054c5933687 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> @@ -5,9 +5,21 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "kaanapali.dtsi"
>
> +#include "pm8010-kaanapali.dtsi" /* SPMI1: SID-12/13 */
> +#include "pmd8028-kaanapali.dtsi" /* SPMI1: SID-4 */
> +#include "pmh0101.dtsi" /* SPMI0: SID-1 */
> +#include "pmh0104-kaanapali.dtsi" /* SPMI1: SID-9 */
> +#include "pmh0110-kaanapali.dtsi" /* SPMI0: SID-3/5/6/8 */
> +#include "pmih0108-kaanapali.dtsi" /* SPMI1: SID-7 */
> +#include "pmk8850.dtsi" /* SPMI0: SID-0 */
> +#include "pmr735d-kaanapali.dtsi" /* SPMI1: SID-10 */
> +
> / {
> model = "Qualcomm Technologies, Inc. Kaanapali MTP";
> compatible = "qcom,kaanapali-mtp", "qcom,kaanapali";
> @@ -53,6 +65,22 @@ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
> };
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-0 = <&key_vol_up_default>;
> + pinctrl-names = "default";
> +
> + key-volume-up {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
> + debounce-interval = <15>;
> + linux,can-disable;
> + wakeup-source;
> + };
> + };
> +

This is not related to PMICs (and doesn't use PMIC gpios).

> sound {
> compatible = "qcom,kaanapali-sndcard", "qcom,sm8450-sndcard";
> model = "Kaanapali-MTP";

--
With best wishes
Dmitry