Re: [PATCH 1/6] arm64: dts: qcom: kaanapali: Add PMIC devices

Jishnu Prakash
2026-03-25T11:04:53Z

Hi Dmitry,

On 3/24/2026 6:42 AM, Dmitry Baryshkov wrote:
> On Sun, Mar 22, 2026 at 11:19:41PM -0700, Jingyi Wang wrote:
>> From: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>>
>> Add a spmi-pmic-arb device for the SPMI PMIC arbiter found on Kaanapali.
>> It has two subnodes corresponding to the SPMI0 bus controller and the
>> SPMI1 bus controller.
>>
>> Also add dtsi files for PMH0104, PMH0110, PMD8028, PMIH0108, PMR735D
>> and PM8010 along with temp-alarm and GPIO nodes under them, which are
>> needed on Kaanapali.
>
> "Also" usually points out that these should be two separate commits.
>

I thought it was slightly better to add new PMIC dtsi files in the same
patch adding the PMIC arbiter (which they are dependent on) in the main
SoC dtsi file, like in here:
https://lore.kernel.org/all/20260219-upstream_v3_glymur_introduction-v8-3-8ce4e489ebb6@oss.qualcomm.com/.

It looks like this patch has been applied in linux-next now. We can
add the new PMIC dtsi files in a separate patch going forward if
that looks better.

Thanks,
Jishnu

>>
>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/kaanapali.dtsi | 47 +++++
>> arch/arm64/boot/dts/qcom/pm8010-kaanapali.dtsi | 93 ++++++++++
>> arch/arm64/boot/dts/qcom/pmd8028-kaanapali.dtsi | 62 +++++++
>> arch/arm64/boot/dts/qcom/pmh0104-kaanapali.dtsi | 63 +++++++
>> arch/arm64/boot/dts/qcom/pmh0110-kaanapali.dtsi | 213 +++++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi | 68 ++++++++
>> arch/arm64/boot/dts/qcom/pmr735d-kaanapali.dtsi | 63 +++++++
>> 7 files changed, 609 insertions(+)
>>
>