From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18719C6FA8B for ; Mon, 19 Sep 2022 11:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbiISL7C (ORCPT ); Mon, 19 Sep 2022 07:59:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbiISL7A (ORCPT ); Mon, 19 Sep 2022 07:59:00 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD11F1E2 for ; Mon, 19 Sep 2022 04:58:59 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id z25so46570639lfr.2 for ; Mon, 19 Sep 2022 04:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=tOSWQ/Fkk0V5oAcdCK1GczlPJaCXPeT7oD2Ukr849gI=; b=ud8s1MDjz5DX1o47iaJrLJF00O4hgWcsSs4er19vmHaPKcrqBfPysZ3TwkVrzhEr45 25HKqPWspOgbLAGoPSu1xN+HGQLU9ZcdoNW7eHHYRRlnF82EvqCnDCZREAVj5j5+Qks/ BaTEgJkD1GAYxtIHBV2NHPjwpOIDXkMXM2Tp0WJ3LphcddWQvJaaJiUiDUVko0zHtiBC eCKvzETT3zU/u82k0ZGnmPXggaQ1qZCIsnhX1AtuJ8YXc+hrs6xWD7lTmDUgB79yGe8f rfEFfAFco+cIdLL5HRiC4/vgNa0TWpe24JFgCwRMhvoIwkdN7kFwm9jMHn+u0bBRWah6 pMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=tOSWQ/Fkk0V5oAcdCK1GczlPJaCXPeT7oD2Ukr849gI=; b=DDbuDvNfPPQUfbFVh+XMHcXCZP0FCaWxf7AKbxqaz6mqRicvkg6phvQN1GefINl6T1 hAS8e3yMT+zQ+q0aJm4nYiT7NxCikWz/sn3TA9Mj6aa06IAtwkA0T8TyrOByKvMazamL aufvbc/PpjngiIHxmIeSMWK6+8PcTSxGB3cGRjmTtXkX5gGFtGazOGsv/NG1w+vhlCNj yposfb1dPnJKoWyJbDX2ROJ3li23OPNgENe+oLl9bdc8QqX5kPUh7porPwzOtlz/opXR tLOAxyhru70Dpq1z942hQAA7nw+33BnHe9dpufWod7cQi3rEQ6PViWWMejrbkQ5hWHHp V4wQ== X-Gm-Message-State: ACrzQf35zD8MDcArVtucGerGpLgrBsCXwCf6LkUiKmoXI4O6NpEHtlwx DfVu9t6dtVDyyFAk8VphA84vhA== X-Google-Smtp-Source: AMsMyM5q+6jx2f3SL4JC+p1u5O/iO5UAPFCnIdCUDD/xQ+gkohX0TWipZ7CN/CJOab2xJP98btYxmg== X-Received: by 2002:a05:6512:c17:b0:498:f034:1c30 with SMTP id z23-20020a0565120c1700b00498f0341c30mr5879136lfu.408.1663588738088; Mon, 19 Sep 2022 04:58:58 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id o3-20020a2e7303000000b0026bca725cd0sm4881188ljc.39.2022.09.19.04.58.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 04:58:57 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 14:58:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] firmware/psci: Print a warning if PSCI doesn't accept PC mode Content-Language: en-GB To: Mark Rutland Cc: Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20220804130750.3706897-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 05/08/2022 17:19, Mark Rutland wrote: > On Thu, Aug 04, 2022 at 04:07:50PM +0300, Dmitry Baryshkov wrote: >> The function psci_pd_try_set_osi_mode() will print an error if enabling >> OSI mode fails. To ease debugging PSCI issues print corresponding >> message if switching to PC mode fails too. >> >> Signed-off-by: Dmitry Baryshkov > > Acked-by: Mark Rutland > > Mark. Granted that this patch has been acked by the maintainers of PSCI interface, how do I proceed? Should I submit it to Russel's patch tracker? Or do PSCI patches land via some other tree? > >> --- >> This is a replacement for [1], now moving the warning from >> psci_set_osi_mode() callers to the function iself. >> >> https://lore.kernel.org/all/20220727182034.983727-1-dmitry.baryshkov@linaro.org/ >> >> --- >> drivers/cpuidle/cpuidle-psci-domain.c | 4 +--- >> drivers/firmware/psci/psci.c | 2 ++ >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c >> index 3db4fca1172b..821984947ed9 100644 >> --- a/drivers/cpuidle/cpuidle-psci-domain.c >> +++ b/drivers/cpuidle/cpuidle-psci-domain.c >> @@ -124,10 +124,8 @@ static bool psci_pd_try_set_osi_mode(void) >> return false; >> >> ret = psci_set_osi_mode(true); >> - if (ret) { >> - pr_warn("failed to enable OSI mode: %d\n", ret); >> + if (ret) >> return false; >> - } >> >> return true; >> } >> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c >> index cfb448eabdaa..1628f1edef4a 100644 >> --- a/drivers/firmware/psci/psci.c >> +++ b/drivers/firmware/psci/psci.c >> @@ -163,6 +163,8 @@ int psci_set_osi_mode(bool enable) >> PSCI_1_0_SUSPEND_MODE_PC; >> >> err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); >> + if (err < 0) >> + pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); >> return psci_to_linux_errno(err); >> } >> >> -- >> 2.35.1 >> -- With best wishes Dmitry