Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 2/5/26 1:04 AM, Roger Shimizu wrote:
> Thanks Konrad for the review!
> 
> On Wed, Feb 4, 2026 at 1:21 AM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 1/31/26 11:31 AM, Roger Shimizu wrote:
>>> Thundercomm AI MiniPC G1 IoT is single board computer with
>>> AI capability based on Qualcomm QCS6490 platform.
>>>
>>> This device tree is confirmed to work as below:
>>> - GPU
>>> - HDMI output port
>>> - PCIe M.2 port (for external Wi-Fi or 5G connectivity)
>>> - UART / serial console port
>>> - UFS
>>> - USB Type-C port, with Display Port
>>>
>>> Signed-off-by: Roger Shimizu <rosh@debian.org>
>>> ---

[...]

>>> +             vreg_s1b_1p872: smps1 {
>>> +                     regulator-name = "vreg_s1b_1p872";
>>> +                     regulator-min-microvolt = <1840000>;
>>> +                     regulator-max-microvolt = <2040000>;
>>
>> Have you cross-checked the regulator settings against the original
>> vendor-provided sw?
> 
> No. Those are from RB3 Gen2. So far there's no issue.
> If there's an issue, we can fix it later.

The issue may be that once you enable one of these regulators, you'll
see magic smoke.. please cross-check it

>> [...]
>>
>>> +&pon_pwrkey {
>>> +     status = "okay";
>>> +};
>>
>> This one is already enabled
> 
> May I know where it's enabled?
> From my search, pon_pwrkey is defined in:
> arch/arm64/boot/dts/qcom/pmk8350.dtsi, which is disabled.

Right, I must have misread.

Konrad