From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EA8EB64DD for ; Thu, 29 Jun 2023 20:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbjF2UFp (ORCPT ); Thu, 29 Jun 2023 16:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232600AbjF2UFD (ORCPT ); Thu, 29 Jun 2023 16:05:03 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A0C2D52 for ; Thu, 29 Jun 2023 13:05:01 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fba03becc6so741571e87.0 for ; Thu, 29 Jun 2023 13:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688069099; x=1690661099; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OF3SWHQBitllVPlaYnVLF/iiTBXMytWTZQU29N7FmDM=; b=gxSfIjzJgF4o6hdReIGjdG8oDb8YMY+FvG9DOf48gJS/uXUgVgdRBxWOyIbIwZURQ6 qqlLtGy9beddY4617elmaPql81XYUQ8zxW7WylayUjuELQrLfAH6Ort+7wOGubNRvfjs vPUnouklFBiwE0tQK5VjdKd6ndIr8to+h+Q9RDGQzK+DZDXTIUQ1jVsZKarH3Pku08RX 2QvOPHNXoyjvlv7ryV1D7SN/jNZctB6mPECftJZV3hBBGOiv7QrR0qAJLqP8YAr1Kln/ XVdozh/5IpjZyWV41qXtrBGwBcWg4aLtVJRCcZRZeIvobORm50LcEvt3gPIPCgI5UMbS PLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688069099; x=1690661099; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OF3SWHQBitllVPlaYnVLF/iiTBXMytWTZQU29N7FmDM=; b=UZRlJYysoFxewavKpfR4ood9FgP1fRFzNv4lHZ3JEqtLTNz1btIPAwqqBWS/QuWDlJ 00NCAnTJb8rISnxktRSjaZ3xKYRic0xgIqr55HJwMJTlx369TzEKYlqKqDtwM6wdjxjL sZQLtIsCJJ/HZIq7+81N02WIZ6K59nEncO9SAuJ629b0QlScaSeM4P4topBAr0ld8saU hi2cWcEt2t7i80jG3/aTT40Givii0HHCL0L3B/r2CNNWXzSx7OCQRj9KGL/QDlDN3c2M 8+J/O52c6y/RLspIOsXl2jG6WswesDowngHlqg4IFIj5vIEax6Bg8AK4o3AwUg+YygE6 /JuA== X-Gm-Message-State: ABy/qLagh/8DqV6u8LXmnRZkWs4juLM7XBCzqTXTLPkwYyqchvGv+gTN 9jba5SZM1YBBLV3KmCKFQmtlmQ== X-Google-Smtp-Source: APBJJlHCImMszh08qroN+ScqTvW+Lm4kzbNBHCoakjGE3swSx6rZ5XyHj9KuN68oeeMW8B9bxhKuoQ== X-Received: by 2002:a05:6512:693:b0:4f8:6d9d:abe0 with SMTP id t19-20020a056512069300b004f86d9dabe0mr365281lfe.33.1688069099306; Thu, 29 Jun 2023 13:04:59 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id k28-20020ac2457c000000b004fb9fbdd8fcsm207623lfm.252.2023.06.29.13.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 13:04:58 -0700 (PDT) Message-ID: Date: Thu, 29 Jun 2023 22:04:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 08/11] dt-bindings: usb: ci-hdrc-usb2: Fix handling pinctrl properties Content-Language: en-US To: Rob Herring Cc: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Benjamin Li , James Willcox , Joseph Gates , Stephan Gerhold , Zac Crosby , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Lee Jones , Stephen Boyd , Joerg Roedel , Will Deacon , Robin Murphy , Greg Kroah-Hartman , Xu Yang , Peng Fan , Christian Marangi , Wesley Cheng , Jun Nie , Max Chen , Shawn Guo , Vivek Gautam , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Knecht , Bryan O'Donoghue , Konrad Dybcio , alsa-devel@alsa-project.org, iommu@lists.linux.dev, linux-usb@vger.kernel.org, Krzysztof Kozlowski , Leo Yan , Andy Gross References: <20230627-topic-more_bindings-v1-0-6b4b6cd081e5@linaro.org> <20230627-topic-more_bindings-v1-8-6b4b6cd081e5@linaro.org> <20230629152335.GA3055525-robh@kernel.org> From: Konrad Dybcio In-Reply-To: <20230629152335.GA3055525-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 29.06.2023 17:23, Rob Herring wrote: > On Tue, Jun 27, 2023 at 06:24:24PM +0200, Konrad Dybcio wrote: >> Untangle the bit messy oneOf trees and add the missing pinctrl-2 mention >> to handle the different pinctrl combinations. >> >> Fixes: 4c8375d35f72 ("dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format") >> Signed-off-by: Konrad Dybcio >> --- >> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 ++++++---------------- >> 1 file changed, 7 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> index 782402800d4a..24431a7adf3e 100644 >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >> @@ -199,17 +199,6 @@ properties: >> In case of HSIC-mode, "idle" and "active" pin modes are mandatory. >> In this case, the "idle" state needs to pull down the data and >> strobe pin and the "active" state needs to pull up the strobe pin. >> - oneOf: >> - - items: >> - - const: idle >> - - const: active > > These are no longer valid values? The description still mentions them. I believe allOf: now covers them all? > >> - - items: >> - - const: default >> - - enum: >> - - host >> - - device >> - - items: >> - - const: default >> >> pinctrl-0: >> maxItems: 1 >> @@ -357,17 +346,15 @@ allOf: >> - const: active >> else: >> properties: >> + pinctrl-2: > > This should be implicitly allowed. Is it not? No, it errored out for me. > > I'm reallly at a loss as to what problem this patch solves. Specifying all 3 pin states is impossible with the current state of this binding, even though it's a supported configuration (check qcom/apq8039-t2.dtb). I should have been more clear in the commit message. Konrad > >> + maxItems: 1 >> + >> pinctrl-names: >> minItems: 1 >> - maxItems: 2 >> - oneOf: >> - - items: >> - - const: default >> - - enum: >> - - host >> - - device >> - - items: >> - - const: default >> + items: >> + - const: default >> + - const: host >> + - const: device >> - if: >> properties: >> compatible: >> >> -- >> 2.41.0 >>