linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_nguyenb@quicinc.com,
	quic_rampraka@quicinc.com, quic_pragalla@quicinc.com,
	quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com,
	quic_bhaskarv@quicinc.com, kernel@oss.qualcomm.com
Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
Date: Wed, 12 Nov 2025 11:57:25 +0530	[thread overview]
Message-ID: <efd1b2af-8beb-4d4c-91db-e622b09f3d40@oss.qualcomm.com> (raw)
In-Reply-To: <77898b11-e039-4c62-b651-219c971a3be0@oss.qualcomm.com>


On 11/10/2025 4:38 PM, Konrad Dybcio wrote:
> On 11/10/25 10:25 AM, Sarthak Garg wrote:
>> On 11/10/2025 2:43 PM, Krzysztof Kozlowski wrote:
>>> On 10/11/2025 09:50, Sarthak Garg wrote:
>>>> Add SD Card host controller for sm8750 soc.
>>>>
>>>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
>>>>    1 file changed, 54 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> index a82d9867c7cb..95b210fbfead 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> @@ -3482,6 +3482,60 @@ pcie0_phy: phy@1c06000 {
>>>>                status = "disabled";
>>>>            };
>>>>    +        sdhc_2: mmc@8804000 {
>>> Nothing improved.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I moved the sdhc_2 node to follow alphanumeric ordering and used hex in reg.
>> What extra is needed ?
> Nodes with a unit address (numbers after @) are supposed to be sorted
> by that register, just like any other register map
>
> Konrad


Thanks for pointing out. Will update in V5.


Regards,
Sarthak



  reply	other threads:[~2025-11-12  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10  8:50 [PATCH V4 0/3] Add SD Card support for sm8750 SoC and boards Sarthak Garg
2025-11-10  8:50 ` [PATCH V4 1/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc Sarthak Garg
2025-11-10  9:13   ` Krzysztof Kozlowski
2025-11-10  9:25     ` Sarthak Garg
2025-11-10 11:08       ` Konrad Dybcio
2025-11-12  6:27         ` Sarthak Garg [this message]
2025-11-10  8:50 ` [PATCH V4 2/3] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board Sarthak Garg
2025-11-10  8:50 ` [PATCH V4 3/3] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board Sarthak Garg
2025-11-10 14:34 ` [PATCH V4 0/3] Add SD Card support for sm8750 SoC and boards Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efd1b2af-8beb-4d4c-91db-e622b09f3d40@oss.qualcomm.com \
    --to=sarthak.garg@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_pragalla@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_sayalil@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).