From: Nikita Travkin <nikita@trvn.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Acer Aspire 1
Date: Tue, 14 Mar 2023 13:55:45 +0500 [thread overview]
Message-ID: <f09056264510944fbc35a0ad27e99c93@trvn.ru> (raw)
In-Reply-To: <92725aab-a540-b35a-6614-2b91039f433c@linaro.org>
Krzysztof Kozlowski писал(а) 14.03.2023 13:21:
> On 14/03/2023 07:43, Nikita Travkin wrote:
>> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 1bb24d46e4ee..903a5ea42cf6 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -352,6 +352,11 @@ properties:
>> - qcom,qru1000-idp
>> - const: qcom,qru1000
>>
>> + - items:
>> + - enum:
>> + - acer,aspire1
>> + - const: qcom,sc7180
>> +
>> - description: Qualcomm Technologies, Inc. SC7180 IDP
>
> Please merge with this one and drop the description (or rename it to
> something like SC7180-based boards). The sc7180 entries spread a lot and
> it is not helping to read the file.
>
I was debating whether to copy CrOS style or the majority for this one.
Will merge with IDP (dropping the description to be in line with all others)
but will not touch any other sc7180 boards.
Thanks,
Nikita
> Best regards,
> Krzysztof
prev parent reply other threads:[~2023-03-14 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 6:43 [PATCH 1/2] dt-bindings: arm: qcom: Add Acer Aspire 1 Nikita Travkin
2023-03-14 6:43 ` [PATCH 2/2] arm64: dts: " Nikita Travkin
2023-03-14 8:26 ` Krzysztof Kozlowski
2023-03-14 9:12 ` Nikita Travkin
2023-03-14 10:24 ` Konrad Dybcio
2023-03-14 13:16 ` Nikita Travkin
2023-03-14 8:21 ` [PATCH 1/2] dt-bindings: arm: " Krzysztof Kozlowski
2023-03-14 8:55 ` Nikita Travkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09056264510944fbc35a0ad27e99c93@trvn.ru \
--to=nikita@trvn.ru \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox