From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881FEA921 for ; Wed, 2 Jul 2025 00:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751417337; cv=none; b=V1vw6FKBlzm0HqC5vYXPFNxau0AGERLyTJLOWj30q5M09XcNUmxCg91Q+LZqfJZavnQ9ycOOLH/lA2ph6mytK/i/jRCBwCryQDtYlushxXP1LKoNjxlopNADsQQ357I2FamMRENnGJTe66S0vJq32B5z8ugPygXRXm2q35fsPzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751417337; c=relaxed/simple; bh=InK9J2/YqbwRfzojDagtvXR6jYQ+cBJHD459vWQEtCg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MyaegoyEXNZWpv5IdIvRV2pP8HLq32F7hiqT7+vu6nlpLGSQMionrRp1FkolBSMCzxrQ9jDQf3I/vq3VHeISTNqgg7aplhhI+GF+AmBqDArUJdDl39NzBpCbD3x5xPMRSO5iE7HokZTHTjRrRy/o6ZrBZaPsXlc+MmeCc1MS7bs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XDJr8m6I; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XDJr8m6I" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-453066fad06so42389325e9.2 for ; Tue, 01 Jul 2025 17:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751417334; x=1752022134; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rGsHHNKY8cp9LTm76izZqQKI5ayNv9sJ0wimG6C8jKE=; b=XDJr8m6IfuQDk6y0MLBZ5youQQPHG49bMipqdF4jwd8nZA3MowkdOYxut8op42wwm5 X6N2hblgwrxog1KJkwYHYUKTv5Gr4ZUEWZZzqmzpQbgX9gnfTPZeZmUCWhwlJGD1Tn/+ V7Rc2LYB+IH4KXxA+9MmVK+oWCq1+nwBn6tvZGCS7TLXpOSQDF6LQ6IQnmfzULeyZkAP 85Fxz4NZQ8npjtTuCoL6tE4gGfJKIQaJ1Jd5diT+rhGRscc690yPV07n83lfw405jkgs jAcftcD9GG2WX/4r3u5lp8/S5Pu5dhYyhCJjEy0kG4wHsYgSbJoj5woYYGMDs3H7Qycg UlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751417334; x=1752022134; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGsHHNKY8cp9LTm76izZqQKI5ayNv9sJ0wimG6C8jKE=; b=CFBK3n0TXYTbN0tbBY3S5xJgXSCzDECoMl7BTIS9PYy4MzNg3aKRPj3GQcLc7Do7Go MAYiMgqVcLx6ABCD115llI1yQHAg/sjTNgtdHtpSQnacaGzY1j9gJVw71MtTt5Bb5Ft8 2/nqQn8uNv0Yx5y6KviTf/yYCCfmIfI8Gh7bJHEO2E0APBg+jN43BbcBvD8ABhpmcEEL iFhDXE12+2HBv/n5pbItGHnvcNTL/W4u6RNElXiiYLcf0vPi7LtSBQgNxUL80EaYh3J+ YFDj0kHzrScuRK8oDofC46pJuBimMgQozPABUGY9mZUSI/g87CrmjAUKE/2Xyrgw3Jw0 cVUg== X-Forwarded-Encrypted: i=1; AJvYcCWIxm/UiLfrQwd3ScLzmyBeDuXk/2IUFI43WDs7ZvZOmkply9rbO5Uxu6JrnggnWUBfM8IQEAaczHsHx/oX@vger.kernel.org X-Gm-Message-State: AOJu0YxvVHeKZ7Cjt9O6Th3PMI7JvCqf8b5xiSYwvmg/YGihH6j8TJmV GpjFAKvyhbEQXRsgvKRYXseLRwq8MQhfVlur7c7XjuEO6o9lAAA9KITivfQHbnzvr5A= X-Gm-Gg: ASbGncvrfhqetnb+QLuGGApuBDbhfr+J0v6Xo7aTChIGFapTiqwjs95DE6IWnlQq0pI xf5ticE5oNBLnWctrsE6eU2Gqynaa3xyUQHG5iJ99Mq+0Ma1JTpFDzcnjGr0ActIO3kQBbEvQRZ 25dx0itijft879227IJ7C/2lYMOBvQxVD28Mlka4voUCDr9uk1536HoCphpVry9AZveSM9h38Pc 1Aena1UbHANR4oXfvF1H6VFgv2plyYay9JFDZIFSH6hxywlsEDyruPyutlBx6y8jGJkOqD85zAt zs5egyO1N7axu3M8UfQsZ6fJYM2yn3+hDa8gE8ltWktrA/VUYbJODHUVpaHTZNhBIK7Jilg9JAP z4ufwx9UfbaLPjXn+5oTQpK3Hs+o= X-Google-Smtp-Source: AGHT+IGKgsMLOI0TmDqWO6ukaJ5/cpcfHm5ix9xN5jkjagPK8L17OmUWnBDEoVzL86A0njQ2MfOtYg== X-Received: by 2002:a05:600c:3504:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-454a36e459cmr10962585e9.10.1751417333805; Tue, 01 Jul 2025 17:48:53 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a406ab6sm183965225e9.30.2025.07.01.17.48.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 17:48:53 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2025 01:48:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera To: Richard Acayan Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Sakari Ailus , Tianshu Qiu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250630225944.320755-7-mailingradian@gmail.com> <3qGugliBdtpdHGZzR9xh_974TfJigMYERGVAfqmpCqe1R7O0CLU8FzXVcIESzTIc-SKzpk42ZAx5-38eDX00Eg==@protonmail.internalid> <20250630225944.320755-11-mailingradian@gmail.com> <488281f6-5e5d-4864-8220-63e2a0b2d7f2@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/07/2025 00:15, Richard Acayan wrote: > On Tue, Jul 01, 2025 at 01:23:44PM +0100, Bryan O'Donoghue wrote: >> On 30/06/2025 23:59, Richard Acayan wrote: >>> The Sony IMX355 is the front camera on the Pixel 3a. It is connected to >>> CSIPHY1 and CCI I2C1, and uses MCLK2. Add support for it. >>> >>> Signed-off-by: Richard Acayan >>> --- >>> .../boot/dts/qcom/sdm670-google-sargo.dts | 112 ++++++++++++++++++ >>> 1 file changed, 112 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> index d01422844fbf..0af6a440ecbc 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> @@ -172,6 +172,34 @@ vreg_s2b_1p05: vreg-s2b-regulator { >>> regulator-min-microvolt = <1050000>; >>> regulator-max-microvolt = <1050000>; >>> }; >>> + >>> + cam_front_ldo: cam-front-ldo-regulator { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "cam_front_ldo"; >>> + regulator-min-microvolt = <1352000>; >>> + regulator-max-microvolt = <1352000>; >>> + regulator-enable-ramp-delay = <135>; >>> + >>> + gpios = <&pm660l_gpios 4 GPIO_ACTIVE_HIGH>; >>> + enable-active-high; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&cam_front_ldo_pin>; >>> + }; >>> + >>> + cam_vio_ldo: cam-vio-ldo-regulator { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "cam_vio_ldo"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + regulator-enable-ramp-delay = <233>; >>> + >>> + gpios = <&pm660_gpios 13 GPIO_ACTIVE_HIGH>; >>> + enable-active-high; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&cam_vio_pin>; >>> + }; >>> }; >>> >>> &apps_rsc { >>> @@ -392,6 +420,58 @@ vreg_bob: bob { >>> }; >>> }; >>> >>> +&camss { >>> + vdda-phy-supply = <&vreg_l1a_1p225>; >> >> You've got your 1p2 but looks like you are missing your 0p8 supply > > This is probably vreg_s6a_0p87 which supplies vreg_l1a_1p225. Yep adds up to me. > >>> + status = "okay"; >>> +}; >>> + >>> +&camss_endpoint1 { >>> + clock-lanes = <7>; >>> + data-lanes = <0 1 2 3>; >>> + remote-endpoint = <&cam_front_endpoint>; >>> + status = "okay"; >>> +}; >> >> This looks not like how the other dts are upstream. Does this work and pass >> the dt checker ? >> >> Right now upstream wants something like this >> >> &camss { >> vdda-phy-supply = <&vreg_l5a_0p88>; >> vdda-pll-supply = <&vreg_l9a_1p2>; >> status = "okay"; >> >> ports { >> /* The port index denotes CSIPHY id i.e. csiphy2 */ >> port@2 { >> csiphy2_ep: endpoint { >> clock-lanes = <7>; >> data-lanes = <0 1 2 3>; >> remote-endpoint = <&imx577_ep>; >> }; >> }; >> }; >> }; > > I misunderstood a review comment from an earlier series. We can do the > same thing here instead of pushing a different style. Yes. Unless/until there's a change in linux-next you can safely ignore all opinions/statements including mine on how things will be in the future... >> Can the upstream driver actually consume the dt as you specified above ? > > If you're curious, it does understand and let you go as far as using the > camera. Nice. Good work. --- bod