Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Cc: Amit Kucheria <amitk@kernel.org>,
	Thara Gopinath <thara.gopinath@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	aastha.pandey@oss.qualcomm.com, dipa.mantre@oss.qualcomm.com,
	Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones
Date: Mon, 16 Mar 2026 08:41:09 +0100	[thread overview]
Message-ID: <f1248497-5ed7-4741-869e-ac25db1a3973@kernel.org> (raw)
In-Reply-To: <c235ff5a-3a9f-4f97-b7b9-d6a95a68e393@oss.qualcomm.com>

On 16/03/2026 08:33, Gaurav Kohli wrote:
> 
> 
> On 3/14/2026 4:01 PM, Krzysztof Kozlowski wrote:
>> On Fri, Mar 13, 2026 at 04:04:18PM +0530, Gaurav Kohli wrote:
>>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com>
>>>
>>> The sm8750 includes four TSENS instances, with a total of 47 thermal
>>> sensors distributed across various locations on the SoC.
>>>
>>> The TSENS max/reset threshold is configured to 130°C in the hardware.
>>> Enable all TSENS instances, and define the thermal zones with a hot trip
>>> at 120°C and critical trip at 125°C.
>>>
>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com>
>>> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++
>>>   1 file changed, 897 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> index f56b1f889b85..db2a97cb228d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> @@ -20,6 +20,7 @@
>>>   #include <dt-bindings/soc/qcom,gpr.h>
>>>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>>>   #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>>> +#include <dt-bindings/thermal/thermal.h>
>>>   
>>>   / {
>>>   	interrupt-parent = <&intc>;
>>> @@ -5457,6 +5458,902 @@ compute-cb@14 {
>>>   				};
>>>   			};
>>>   		};
>>> +
>>> +		tsens0: thermal-sensor@c228000 {
>>
>> Please read carefully DTS coding style before posting patches. Actually,
>> read also Linux kernel coding style as well.
>>
> 
> Thanks Krzysztof for review.
> 
> Can i use temperature-sensor instead of thermal-sensor as per 
> generic-names-recommendation ?

Both work for me.

Best regards,
Krzysztof

  reply	other threads:[~2026-03-16  7:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 10:34 [PATCH 0/2] Enable TSENS and thermal zone for SM8750 SoC Gaurav Kohli
2026-03-13 10:34 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor Gaurav Kohli
2026-03-14 10:30   ` Krzysztof Kozlowski
2026-03-14 10:46     ` Daniel Lezcano
2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli
2026-03-14 10:31   ` Krzysztof Kozlowski
2026-03-16  7:33     ` Gaurav Kohli
2026-03-16  7:41       ` Krzysztof Kozlowski [this message]
2026-03-18  9:44   ` Konrad Dybcio
2026-03-18  9:44     ` Konrad Dybcio
2026-03-23  9:02     ` Gaurav Kohli
2026-03-23 13:12       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1248497-5ed7-4741-869e-ac25db1a3973@kernel.org \
    --to=krzk@kernel.org \
    --cc=aastha.pandey@oss.qualcomm.com \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dipa.mantre@oss.qualcomm.com \
    --cc=gaurav.kohli@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=quic_manafm@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox