From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>, kholk11@gmail.com
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
marijns95@gmail.com, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/2] thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976
Date: Wed, 2 Oct 2019 05:26:57 +0200 [thread overview]
Message-ID: <f1881a4a-f8d4-ec64-972f-cbef506bef0c@linaro.org> (raw)
In-Reply-To: <CAP245DXyPraU_cL6PezSLL8sHP7-JQ6J-qtjqfV6eOxmhOb9pg@mail.gmail.com>
On 02/10/2019 01:00, Amit Kucheria wrote:
> On Tue, Oct 1, 2019 at 2:27 PM <kholk11@gmail.com> wrote:
>>
>> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>>
>> Add support for reading calibrated value from thermistors in
>> MSM8956, MSM8976 and their APQ variants.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
>> ---
[ ... ]
>> -/* v1.x: qcs404,405 */
>> +static int calibrate_8976(struct tsens_priv *priv)
>> +{
>> + int base0 = 0, base1 = 0, i;
>> + u32 p1[11], p2[11];
>> + int mode = 0, tmp = 0;
>> + u32 *qfprom_cdata;
>> +
>> + qfprom_cdata = (u32 *)qfprom_read(priv->dev, "calib");
>> + if (IS_ERR(qfprom_cdata))
>
> kfree(qfprom_data) here
(Assuming s/qfprom_data/qfprom_cdata/)
Where the allocation happen?
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-10-02 3:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 8:57 [PATCH v2 0/2] Add TSENS support for MSM8956/76 kholk11
2019-10-01 8:57 ` [PATCH v2 1/2] thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976 kholk11
2019-10-01 23:00 ` Amit Kucheria
2019-10-02 3:26 ` Daniel Lezcano [this message]
2019-10-03 14:02 ` Amit Kucheria
2019-10-05 9:34 ` AngeloGioacchino Del Regno
2019-10-01 8:57 ` [PATCH v2 2/2] dt: thermal: tsens: Document compatible for MSM8976/56 kholk11
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1881a4a-f8d4-ec64-972f-cbef506bef0c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=kholk11@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).