From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C972CC433FE for ; Mon, 21 Nov 2022 11:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbiKULqh (ORCPT ); Mon, 21 Nov 2022 06:46:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbiKULqc (ORCPT ); Mon, 21 Nov 2022 06:46:32 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C456EDFA3; Mon, 21 Nov 2022 03:46:24 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E94141FB; Mon, 21 Nov 2022 03:46:30 -0800 (PST) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AF133F587; Mon, 21 Nov 2022 03:46:22 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 11:46:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 0/9] Add support to configure TPDM DSB subunit Content-Language: en-US From: Suzuki Kuruppassery Poulose To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org References: <1669018873-4718-1-git-send-email-quic_taozha@quicinc.com> <2e731c94-22a8-f15c-4eaa-aa84e3e9038f@arm.com> In-Reply-To: <2e731c94-22a8-f15c-4eaa-aa84e3e9038f@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/11/2022 10:21, Suzuki Kuruppassery Poulose wrote: > On 21/11/2022 08:21, Tao Zhang wrote: >> Introduction of TPDM DSB subunit >> DSB subunit is responsible for creating a dataset element, and is also >> optionally responsible for packing it to fit multiple elements on a >> single ATB transfer if possible in the configuration. The TPDM Core >> Datapath requests timestamps be stored by the TPDA and then delivering >> ATB sized data (depending on ATB width and element size, this could >> be smaller or larger than a dataset element) to the ATB Mast FSM. >> >> The DSB subunit must be configured prior to enablement. This series >> adds support for TPDM to configure the configure DSB subunit. >> >> Once this series patches are applied properly, the new tpdm nodes for >> should be observed at the tpdm path /sys/bus/coresight/devices/tpdm* >> which supports DSB subunit. >> e.g. >> /sys/devices/platform/soc@0/69d0000.tpdm/tpdm0#ls -l | grep dsb >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_edge_ctrl >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_edge_ctrl_mask >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_mode >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_patt_mask >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_patt_ts >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_patt_type >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_patt_val >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_trig_patt_mask >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_trig_patt_val >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_trig_ts >> -rw-r--r--    1 root     root      4096 Jan  1 00:01 dsb_trig_type >> >> We can use the commands are similar to the below to configure the >> TPDMs which support DSB subunit. Enable coresight sink first. >> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink >> echo 1 > /sys/bus/coresight/devices/tpdm0/reset >> echo 0x3 0x3 0x1 > /sys/bus/coresight/devices/tpdm0/dsb_edge_ctrl_mask >> echo 0x6d 0x6d 0 > /sys/bus/coresight/devices/tpdm0/dsb_edge_ctrl >> echo 1 > /sys/bus/coresight/devices/tpdm0/dsb_patt_ts >> echo 1 > /sys/bus/coresight/devices/tpdm0/dsb_patt_type >> echo 0 > /sys/bus/coresight/devices/tpdm0/dsb_trig_ts >> echo 0 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm0/dsb_patt_mask >> echo 0 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm0/dsb_trig_patt_val >> >> This series applies to coresight/next >> https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git?h=next > > Does it ? > >> This patch series depends on patch series "[v12,0/9] Coresight: Add >> support for TPDM and TPDA" >> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221114144027.14365-1-quic_jinlmao@quicinc.com/ >> > > And the CoreSight Dynamice Trace ID series too. > > Change log please > Also, more importantly, as requested previousl please host a tree with all the dependencies applied including this series. It is hard to review looking all the way back to a dependent series back and forth. Or we could shelve this until the dependencies are merged/queued. Suzuki