From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A77C433EF for ; Fri, 29 Apr 2022 15:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238261AbiD2POq (ORCPT ); Fri, 29 Apr 2022 11:14:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378112AbiD2POn (ORCPT ); Fri, 29 Apr 2022 11:14:43 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D396D4476 for ; Fri, 29 Apr 2022 08:11:24 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id n14so14552803lfu.13 for ; Fri, 29 Apr 2022 08:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=TvFsyI7NAksekaViwUx4f2psKYTKDusGU6diNyW4wEY=; b=T8o72y8HKqohLMREw3MtTyqotxs7B5HFBhFLyKmIfaTKxZBXu3ZutL0Azktumql+b5 4pG5NpDWFKiFDQ/LQrOkkRzRjQQEH7WrNV9Dzvqi5uslhe85raPC2PNEwxQWMwSdKLaO rBXloVU9g6kkznIBzursT9frKbk8tXM5outfJOSwUdjcjyU7M8MASSYi9udAUWb2JnPX 8IE8WLsna9DNKNt0MrnaCBVVhsJNp2FlRs5DL8COBeTLr1jHddjAbDoMk9VbGWWKCsgh svs8h7vojmZkbRP3cIw0c0Bhg5cYnssId94RwzAcqvNZrt0+nvYzwI9pvAZgpEl/JqWU 7diw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=TvFsyI7NAksekaViwUx4f2psKYTKDusGU6diNyW4wEY=; b=R1tW6IKAsi/Aq8DRFXzTGr6Mqu6IHxpf3sM+ZSpJKTaC3ulixZq+8S+eBAyTYNgpI6 PM/hma0ZuEJ7e2HvrViYhTJ7aiEag8vfslncF9iDUVIqzPnfgFGAJkP0jUlDAQWakQqn XJW5YXiAIOUqdPZ3F6Hr+Cng5f+1vsPiHSL4jHHUxKBfVTXVMgfgyJLlw9al5+BAuYjM 9xMaC2BxEkD5Kif0F+QFC9a+Spanc+ghk1Vy1lAwNs/Xkh6OLTc6AJXU+f9T9cm5Uv6M s+eDAkvbQwnOHf/KKtLLyGIscVnsF9RE9eRRuMdQQufO1rdN2KSq1dK/VQHk6MOMXurJ /V4Q== X-Gm-Message-State: AOAM531ru+4bPJeNeklvQqxGB9G4LdqYCI0DHQY93KUxbJcJLdnl4JW7 Ny+smx+PceOkVKUDDb27GtI9YA== X-Google-Smtp-Source: ABdhPJxRjwQAnlbxeqaHOGvshYhAXFOvclIamfeS7o45Me22vXNEXn5PNl4tpW2ISRMWPCvf3MslZQ== X-Received: by 2002:ac2:4c53:0:b0:471:a9db:5d15 with SMTP id o19-20020ac24c53000000b00471a9db5d15mr28179347lfk.634.1651245083092; Fri, 29 Apr 2022 08:11:23 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id l6-20020a2e9086000000b0024f3d1daf04sm286705ljg.140.2022.04.29.08.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 08:11:22 -0700 (PDT) Message-ID: Date: Fri, 29 Apr 2022 18:11:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] ARM: dts: qcom: replace gcc PXO with pxo_board fixed clock Content-Language: en-GB To: Ansuel Smith , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220429122951.13828-1-ansuelsmth@gmail.com> <20220429122951.13828-3-ansuelsmth@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220429122951.13828-3-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 29/04/2022 15:29, Ansuel Smith wrote: > Replace gcc PXO phandle to pxo_board fixed clock declared in the dts. > gcc driver doesn't provide PXO_SRC as it's a fixed-clock. This cause a > kernel panic if any driver actually try to use it. > > Signed-off-by: Ansuel Smith Fixes: 40cf5c884a96 ("ARM: dts: qcom: add L2CC and RPM for IPQ8064") It would be nice if you add Fixes tags to your patches in future. Fixes tags allow picking up patches for stable/LTS trees. For these two patches I'd suggest reordering them. A fix should go first (you'll have to define pxa_board label in it). It can then be accepted into other kernel without dependency on the other patch. The gcc patch will come next, it will define cxo_board label and use both clocks in the gcc node. It is not fixing a bug, so there is no need about backporting it. Generic rule: fixes go first (in the patch series), so that they have minimum inter-dependencies. > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 9817448cfa95..ad30f7c8a5a7 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -784,7 +784,7 @@ tcsr: syscon@1a400000 { > l2cc: clock-controller@2011000 { > compatible = "qcom,kpss-gcc", "syscon"; > reg = <0x2011000 0x1000>; > - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>; > + clocks = <&gcc PLL8_VOTE>, <&pxo_board>; > clock-names = "pll8_vote", "pxo"; > clock-output-names = "acpu_l2_aux"; > }; -- With best wishes Dmitry