From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Can Guo <quic_cang@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro
Date: Thu, 13 Jun 2024 16:18:25 -0700 [thread overview]
Message-ID: <f26d6000-0431-42ef-9e1c-bbf4e5010feb@quicinc.com> (raw)
In-Reply-To: <132dedc1-ee11-44d8-b684-0ffbf994d164@acm.org>
On 6/13/2024 9:19 AM, Bart Van Assche wrote:
> On 6/12/24 9:46 PM, Jeff Johnson wrote:
>> +MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
>> MODULE_LICENSE("GPL v2");
>
> That sounds weird to me. I think we are better of with no module
> description than with the above description.
>
> How about the following description?
>
> "Qualcomm UFS host controller driver".
Sounds good to me. Will spin a v2.
prev parent reply other threads:[~2024-06-13 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 4:46 [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-13 16:19 ` Bart Van Assche
2024-06-13 23:18 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f26d6000-0431-42ef-9e1c-bbf4e5010feb@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox