From: "André Draszik" <andre.draszik@linaro.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
Manivannan Sadhasivam <mani@kernel.org>,
kernel-team@android.com, linux-arm-msm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: move some irq handling back to hardirq (with time limit)
Date: Thu, 24 Jul 2025 12:44:25 +0100 [thread overview]
Message-ID: <f2b85e49152b80a63b20aa5ad67dfbee1190e356.camel@linaro.org> (raw)
In-Reply-To: <20250724-ufshcd-hardirq-v1-1-6398a52f8f02@linaro.org>
On Thu, 2025-07-24 at 10:54 +0100, André Draszik wrote:
> fio results on Pixel 6:
> read / 1 job original after this commit
> min IOPS 4,653.60 2,704.40 3,902.80
> max IOPS 6,151.80 4,847.60 6,103.40
> avg IOPS 5,488.82 4,226.61 5,314.89
> cpu % usr 1.85 1.72 1.97
> cpu % sys 32.46 28.88 33.29
> bw MB/s 21.46 16.50 20.76
>
> read / 8 jobs original after this commit
> min IOPS 18,207.80 11,323.00 17,911.80
> max IOPS 25,535.80 14,477.40 24,373.60
> avg IOPS 22,529.93 13,325.59 21,868.85
> cpu % usr 1.70 1.41 1.67
> cpu % sys 27.89 21.85 27.23
> bw MB/s 88.10 52.10 84.48
>
> write / 1 job original after this commit
> min IOPS 6,524.20 3,136.00 5,988.40
> max IOPS 7,303.60 5,144.40 7,232.40
> avg IOPS 7,169.80 4,608.29 7,014.66
> cpu % usr 2.29 2.34 2.23
> cpu % sys 41.91 39.34 42.48
> bw MB/s 28.02 18.00 27.42
>
> write / 8 jobs original after this commit
> min IOPS 12,685.40 13,783.00 12,622.40
> max IOPS 30,814.20 22,122.00 29,636.00
> avg IOPS 21,539.04 18,552.63 21,134.65
> cpu % usr 2.08 1.61 2.07
> cpu % sys 30.86 23.88 30.64
> bw MB/s 84.18 72.54 82.62
Given the severe performance drop introduced by the culprit
commit, it might make sense to instead just revert it for
6.16 now, while this patch here can mature and be properly
reviewed. At least then 6.16 will not have any performance
regression of such a scale.
Cheers,
Andre'
next prev parent reply other threads:[~2025-07-24 11:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:54 [PATCH] scsi: ufs: core: move some irq handling back to hardirq (with time limit) André Draszik
2025-07-24 11:44 ` André Draszik [this message]
2025-07-24 11:54 ` Neil Armstrong
2025-07-24 13:38 ` André Draszik
2025-07-28 14:36 ` Manivannan Sadhasivam
2025-07-28 14:39 ` Manivannan Sadhasivam
2025-07-28 14:41 ` Neil Armstrong
2025-07-28 14:47 ` Manivannan Sadhasivam
2025-07-24 16:02 ` Bart Van Assche
2025-07-25 15:00 ` André Draszik
2025-07-28 14:42 ` Manivannan Sadhasivam
2025-07-28 14:49 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b85e49152b80a63b20aa5ad67dfbee1190e356.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).