From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2854B1DFED; Fri, 6 Sep 2024 14:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725634116; cv=none; b=qLPSNNr4S04GhoiD2XzYeOPusHoBadfXa5mqbij3tpG8yY+3yYL4VhA7IjVe5GnLveqxdPKKIMBX3UcVDGRQV+RIroXwAeq63KgFfGyrSSJe9HXfPf3aIdEW570xzvyL+nTkbxfER5DTCRsOlSwiNMVWFzM78jb0bgpeYjuLDbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725634116; c=relaxed/simple; bh=e4GihuxjY3vq4Gf7efzEhySvDQVsUfgnSxus+q6w9mU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=MFMKm1P8Dm8xck2tPiii0J03dkRwXDmOpUfJ5xQShyFXhxD8bm76aGOd2fpcce4PJx8Oe38au8BIyyCjd0glIq04k82JU9D5QQzwTHNDUFH6om9ZsCMfCglOcCcaREvUaSWNOw9ZIPXPu1qkPxLZVRSc3CxdqfqtY1kx/umNKU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=JcronXvx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="JcronXvx" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4868nYpI028679; Fri, 6 Sep 2024 14:48:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fzcv8pUBe0hyPv1CXrZbBMCtmJQh55CjwDqiQkwKLeY=; b=JcronXvxYsyd/qpJ yVelI1vYZCZz11+kwynSfIKkmsXjwMzhsCkOxk8sshFJCwT74SzezkkIgivRZ6hG WSlYr0R+Fwva9RAQTB0wQ0hxqcz820ix5m+AGeEV3OtU2tQ1q08mFhY2RYNrH9SV IokJJO5oT+CfPoAQulsAPlzhAKHNlbnf0rD7lx+nqbHk97EECOD1SIO8Jy9swDm9 eK4zGjnVFuwQwnbkkGTDgH4W4TMgPNfeaZ+asLqal7kTzCLurWF9yVwqLRF8f1dD pQzKvWFdr74guBcckvvRKhnuHpDhXGoXERBB549v7fi1jp8miaZuMy7jyaaNw/Cv eAllJQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41fhwu2hk1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Sep 2024 14:48:28 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 486EmRtT007315 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Sep 2024 14:48:27 GMT Received: from [10.111.181.108] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 6 Sep 2024 07:48:27 -0700 Message-ID: Date: Fri, 6 Sep 2024 07:48:26 -0700 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ath11k: allow missing memory-regions To: Caleb Connolly , Jeff Johnson , Kalle Valo CC: , , References: <20240904095815.1572186-2-caleb.connolly@linaro.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20240904095815.1572186-2-caleb.connolly@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: OYknvDksipTpsuZAFt9D0lPXqKnz5oO- X-Proofpoint-GUID: OYknvDksipTpsuZAFt9D0lPXqKnz5oO- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_03,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=716 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409060108 On 9/4/2024 2:57 AM, Caleb Connolly wrote: > On SC7280 platforms which are running with TrustZone, it is not > necessary to manually map the memory regions used by the wifi hardware. > However, ath11k will currently fail to load unless both memory regions > are specified. > > This breaks wifi on the rb3gen2 which only specifies the firmware memory > region and does not use the CE region. > > Adjust the order of operations in ath11k_ahb_fw_resources_init() to > check for the wifi-firmware subnode before attempting to parse the > memory regions. > > Signed-off-by: Caleb Connolly Acked-by: Jeff Johnson