From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EE6C0015E for ; Fri, 28 Jul 2023 15:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236360AbjG1P6d (ORCPT ); Fri, 28 Jul 2023 11:58:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236639AbjG1P63 (ORCPT ); Fri, 28 Jul 2023 11:58:29 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB8AD423B for ; Fri, 28 Jul 2023 08:58:26 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-317744867a6so2284882f8f.1 for ; Fri, 28 Jul 2023 08:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690559905; x=1691164705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d7fcq9Wxv4AEPI5+GHtEeD9t936v+W4TRrWVcahSl6o=; b=twbZD6p5UVZ1hHG2O91qvAxiqy6Y+GYYkkoCpYIZJMvQMygyjgsPtFbGmNaDx7pcJt CuIcSNx5GwX6pX5ewFUzTSeQNslrtVUAl1N09pdmKZ29DYeQXKsm1k5nF1iPjegQKQoU ISw8hOMq8pKoUJOiDTHxL/YV9dmNDzKXA2wbt3BLA7ocmZwPubT7ATyxCQUVFHQa5vh5 tqFtcJbvTBGF4uiybSAUalGfJu1p+E0WmFjOyEcgaZBo1HSQm+NHi1E9+xrX10UNOk0G cTexK7g39KXh5QqwSf+MOUl4FIfNGd1mu2muZbDmEeF+OVHCyJrq4Y8vIGkv8X3B/sgR KdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690559905; x=1691164705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d7fcq9Wxv4AEPI5+GHtEeD9t936v+W4TRrWVcahSl6o=; b=FV133U2IGX4AiRkydikHF8Zy+50p6QkBmaNlj7WqIY0HIf9+yMnLtdfJCbPdx3p75J rfZimVFkuF3xl319V0eCl2pVsNwl+YMr3zoIxu+/FXiC+9m5NdlFVjbWLjjuUkA9+AB7 3Jsu8WBtZDgszIDkF8U22PrtTQS4/Bd0baQrBqfHyxnqB48/u9cHjxJEkWDY7w2/NLgq 0a6VrGUN98mCUw3o65X98l9p6Y3ZNwz1pw5CKJOLuXnoyaYpyrvMylkv2ZNRwndLSUv0 hVM3aGFU1KRBk0mp2ZWze1ILqJu0VTb3/Iuwkgd+bJM/kFFCfYVuwhyKzekvpqN4j/Va I4HA== X-Gm-Message-State: ABy/qLbDScKnf3GL7TQs5L6ziuO1cNOmU5MAP2bImAMMdJ1SjbdzHtXs IHWvExlDetHPkL7Gupj/EcY2ww== X-Google-Smtp-Source: APBJJlF+T6NU2JDjjWZC3+SoMRZuFtVWX99/lY4GVDwkIqqKW8Ib9apLj6yZi8qtvwhpUjgsk57Z8g== X-Received: by 2002:a5d:50cf:0:b0:317:5b1b:1a40 with SMTP id f15-20020a5d50cf000000b003175b1b1a40mr2131659wrt.49.1690559905279; Fri, 28 Jul 2023 08:58:25 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id j4-20020adfe504000000b003063a92bbf5sm5199752wrm.70.2023.07.28.08.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 08:58:24 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 16:58:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 18/33] iris: vidc: hfi: add Host Firmware Interface (HFI) Content-Language: en-US To: Vikash Garodia , stanimir.k.varbanov@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hans.verkuil@cisco.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: quic_dikshita@quicinc.com References: <1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com> <1690550624-14642-19-git-send-email-quic_vgarodia@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <1690550624-14642-19-git-send-email-quic_vgarodia@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/07/2023 14:23, Vikash Garodia wrote: > + rc = hfi_packet_sys_intraframe_powercollapse(core, core->packet, > + core->packet_size, enable); > + if (rc) > + return rc; I'm 99.9999999999 % sure this is misnamed. "Inter" means in-between two things. "Intra" means inside of one thing. So "intraframe" means inside of one frame "interframe" would mean power collapsing in-between two frames, which is what I think this does. And I'd still rather be adding inter-frame power-collapse to as many different versions of the existing silicon and new silicon as opposed to segregating it off in a new driver. I'm assuming that more than sm8550 supports it since @ the end of the day this is a firmware feature to power-collapse during an active session when we aren't busy. --- bod