From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A2BC4332F for ; Tue, 20 Dec 2022 10:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233331AbiLTKIq (ORCPT ); Tue, 20 Dec 2022 05:08:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233179AbiLTKIp (ORCPT ); Tue, 20 Dec 2022 05:08:45 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CED2195 for ; Tue, 20 Dec 2022 02:08:44 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id m29so17610178lfo.11 for ; Tue, 20 Dec 2022 02:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PF3WhBZPrqZkUx2iR7sKjx/b40NNBklcPphMLo49bpo=; b=yjpQzFChoYrSc2LQOa2hogExuJ5IpT/jF2Wug1kMYJObcrEl5C4+Tr8aleZMO7bHof DG21vU6tHoMlFUiRbIc0HtZQjuih3Vh5HsLhpyUhHxQgAmXvDkETnggzZgoZVR8GLtHR cXnS/zCMqP8nXl9kO4IcAr20/qPdUEXspL135JbhFLw/3EaEP+ELDtg8fqeFVAafRqFf hQ9bZpEtbHuM+MI79Ymizk+KfLARzS4c2bl52vTs9pDfUz4+mI52v+ah+KesRDHgQSeE sAhZFhEuAbVRoq7eW+2d+y7YPMSlTurEO1unFAMLNw1pUNJDUKMwBmQShR1kaYxjMMh6 nnDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PF3WhBZPrqZkUx2iR7sKjx/b40NNBklcPphMLo49bpo=; b=XC05GQtrMyejtQ8g4L+Ye+1ZAgtas6xaqvBpExReqIl9P7uRcljtDxT5f8ePZCEbBn c2M/pYb5bGzoHI1e6FIDRkB3oObYoBkXtrfLdUZMpLliK6xix+4ySa63l+PyONSg4KgS dCorCSbHagvCdM0D/TJH8V3l9tMMACkDWrXfGKGvQ4wt9C3rT5ZcuBjXhWMUxJnThYl8 +5ftqjH60UsJ3LXJCeG2lZarSWhJz7LJJJ6HTYkrQI3fvedX73Eo1TjZsr+jl2AfM3cj WVj+rS9oyUFjYg4THAU7/Zyd70rRpldgWDZHsmWM4dqNaGeut67S6Osnvj4mXf2WcO0Q Gf/Q== X-Gm-Message-State: AFqh2kqJ/a58b6UX/YiX9Lg0E7B9bwL9kRYd7fKk4+sQLnlf6j/zL48t 3/yg8avMxfSDTVgHb3PgN8jq3Q== X-Google-Smtp-Source: AMrXdXtVstP+G6cxSsiGdo33znLYjHjgAgv6sotEnb9igOCNhUrEH6f6P4Wok+NwgOBQCbN+kVndlw== X-Received: by 2002:a05:6512:251f:b0:4a4:68b7:dec0 with SMTP id be31-20020a056512251f00b004a468b7dec0mr609718lfb.28.1671530922782; Tue, 20 Dec 2022 02:08:42 -0800 (PST) Received: from [192.168.1.101] (abxh212.neoplus.adsl.tpnet.pl. [83.9.1.212]) by smtp.gmail.com with ESMTPSA id s16-20020a056512215000b004ca0ea7af24sm245720lfr.174.2022.12.20.02.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:08:42 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:08:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 05/15] thermal/drivers/tsens: Drop msm8976-specific defines Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, AngeloGioacchino Del Regno References: <20221220024721.947147-1-dmitry.baryshkov@linaro.org> <20221220024721.947147-6-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20221220024721.947147-6-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20.12.2022 03:47, Dmitry Baryshkov wrote: > Drop msm8976-specific defines, which duplicate generic ones. > > Fixes: 0e580290170d ("thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976") > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/thermal/qcom/tsens-v1.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c > index 96ef12d47bff..a7f53966156b 100644 > --- a/drivers/thermal/qcom/tsens-v1.c > +++ b/drivers/thermal/qcom/tsens-v1.c > @@ -78,11 +78,6 @@ > > #define MSM8976_CAL_SEL_MASK 0x3 > > -#define MSM8976_CAL_DEGC_PT1 30 > -#define MSM8976_CAL_DEGC_PT2 120 > -#define MSM8976_SLOPE_FACTOR 1000 > -#define MSM8976_SLOPE_DEFAULT 3200 > - > /* eeprom layout data for qcs404/405 (v1) */ > #define BASE0_MASK 0x000007f8 > #define BASE1_MASK 0x0007f800 > @@ -160,8 +155,8 @@ static void compute_intercept_slope_8976(struct tsens_priv *priv, > priv->sensor[10].slope = 3286; > > for (i = 0; i < priv->num_sensors; i++) { > - priv->sensor[i].offset = (p1[i] * MSM8976_SLOPE_FACTOR) - > - (MSM8976_CAL_DEGC_PT1 * > + priv->sensor[i].offset = (p1[i] * SLOPE_FACTOR) - > + (CAL_DEGC_PT1 * > priv->sensor[i].slope); > } > }