From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085B3C61DA4 for ; Wed, 15 Mar 2023 09:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbjCOJN3 (ORCPT ); Wed, 15 Mar 2023 05:13:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231616AbjCOJNK (ORCPT ); Wed, 15 Mar 2023 05:13:10 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F7B67004 for ; Wed, 15 Mar 2023 02:12:50 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id r29so8584753wra.13 for ; Wed, 15 Mar 2023 02:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678871569; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8eWJAVwfdAMUCwI3o2WJJsF7HeRR9gB8W1OrllJjb5o=; b=XzSmAIL6WPDc9unS6StGpnGGh/CGMJ8Wy8hZjsWSd8gRTPzMl4yLkyH89Z+NjNNOEE /Zl4VkWXiNeVyyMGC7M7hiIBT32VcDKSLy3AiNF1yo1y17rrs6Q98cNSLWgczakKjRen nr+onVKwv62YRyFi0/Ar2V62oOKd932RzGtYRliH1EwMglxP5NqYCJwxiWMCjhIRnRog 2R4k6Q7byMQpvMmJkzinKqrxYlBIs2v9GCUanWcefXQXQ8MJEjRntl+eLd6HQc/jPsgZ n2XpIhHApTZItuwQB5/c5PwtrzQI3mSIHqoIDWaieiCE+5NREvvA69rUWPdAieBmH6G8 8Huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678871569; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8eWJAVwfdAMUCwI3o2WJJsF7HeRR9gB8W1OrllJjb5o=; b=XyGO5M5576miz21kwU7O15ThvSmMZ0QWwjjahxZKfoCHzIjbQt6mNOcQHiVTzT8YgG A0neSYqpKjPWizJ7xoj0azlDCO+qLVsIx7zsc/YCKJ7aG0ZKpYxLRan9BYlf1wxxOtPM DzQ5ohPAdGUPnfnWDyRwcAwx/uVza4TPQAgyoyjDYMVNuNapk5MvKtrorqDkBU6Jti8n BYtjI/frkmPTve68lwsj7LCeHAVZjyG4mFGuo0suiKkBg7g/gQLkGlvgIphvxDUNh/+d UViKU/nd/8EgPBD6RfsjJeHtSHU2KNc3DOFV9XVwghEw10JMBqo/56aPod4KTzjfkZd3 T1bA== X-Gm-Message-State: AO0yUKUoREJF13wPk5xTHTWyxOfsdwRoCxF21Z5YMq/T4KligDY+Hv1Z 7saoaqhtCD/rvnVPs/Tg464YPw== X-Google-Smtp-Source: AK7set+eEbACpzLETf5+yoKzRbTbJU8SVnRF6TSezwW6SQk2wIN2YnBbU8HXUTnpArYwaQ5lSXadsw== X-Received: by 2002:a5d:4c8e:0:b0:2cf:e710:a4b9 with SMTP id z14-20020a5d4c8e000000b002cfe710a4b9mr1357985wrs.32.1678871569378; Wed, 15 Mar 2023 02:12:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:5d2d:8427:397b:8fe7? ([2a01:e0a:982:cbb0:5d2d:8427:397b:8fe7]) by smtp.gmail.com with ESMTPSA id n4-20020a5d6b84000000b002cfe685bfd6sm4027654wrx.108.2023.03.15.02.12.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 02:12:48 -0700 (PDT) Message-ID: Date: Wed, 15 Mar 2023 10:12:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 7/9] regulator: rpi-panel-attiny: Drop of_match_ptr for ID table Content-Language: en-US To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Laurent Pinchart , Matthias Brugger , AngeloGioacchino Del Regno , Tony Lindgren , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230310214553.275450-1-krzysztof.kozlowski@linaro.org> <20230310214553.275450-7-krzysztof.kozlowski@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20230310214553.275450-7-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/03/2023 22:45, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). > > drivers/regulator/rpi-panel-attiny-regulator.c:390:34: error: ‘attiny_dt_ids’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/rpi-panel-attiny-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c > index 34514976475e..3953fc1f389f 100644 > --- a/drivers/regulator/rpi-panel-attiny-regulator.c > +++ b/drivers/regulator/rpi-panel-attiny-regulator.c > @@ -396,7 +396,7 @@ MODULE_DEVICE_TABLE(of, attiny_dt_ids); > static struct i2c_driver attiny_regulator_driver = { > .driver = { > .name = "rpi_touchscreen_attiny", > - .of_match_table = of_match_ptr(attiny_dt_ids), > + .of_match_table = attiny_dt_ids, > }, > .probe_new = attiny_i2c_probe, > .remove = attiny_i2c_remove, Reviewed-by: Neil Armstrong