From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
<andersson@kernel.org>, <broonie@kernel.org>,
<konrad.dybcio@somainline.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mturquette@baylibre.com>,
<quic_plai@quicinc.com>, <quic_rohkumar@quicinc.com>,
<robh+dt@kernel.org>
Subject: Re: [PATCH v6 4/6] clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration
Date: Tue, 31 Jan 2023 12:05:05 +0530 [thread overview]
Message-ID: <f4cc8f19-ff32-5bcb-14aa-1ced8143c202@quicinc.com> (raw)
In-Reply-To: <CAE-0n50n0JaBOukBvandsciHEyKpqSytU2y7K=fmR7gn8WPp5g@mail.gmail.com>
On 1/31/2023 6:24 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2023-01-26 02:14:23)
>> Skip lpasscorecc clocks registration for ADSP based platforms
>> as it's causing NOC errors when ADSP based clocks are enabled.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Tested-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> ---
>> drivers/clk/qcom/lpasscorecc-sc7280.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/lpasscorecc-sc7280.c b/drivers/clk/qcom/lpasscorecc-sc7280.c
>> index 6ad19b0..3aa16d8 100644
>> --- a/drivers/clk/qcom/lpasscorecc-sc7280.c
>> +++ b/drivers/clk/qcom/lpasscorecc-sc7280.c
>> @@ -395,6 +395,9 @@ static int lpass_core_cc_sc7280_probe(struct platform_device *pdev)
>> const struct qcom_cc_desc *desc;
>> struct regmap *regmap;
>>
>> + if (of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode"))
> Why is this node enabled in DT at all if it doesn't provide any clks?
Yes. Agree that we can disable this node in board specific DTS file. As
I thought, disabling node is not appropriate,
preferred this way.
Anyway, as suggested, will drop this patch and disable node in DT.
next prev parent reply other threads:[~2023-01-31 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:14 [PATCH v6 0/6] Add resets for ADSP based audio clock controller driver Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 1/6] dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 2/6] dt-bindings: clock: lpassaudiocc-sc7280: Add binding headers for lpasscc Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 3/6] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 4/6] clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration Srinivasa Rao Mandadapu
2023-01-31 0:54 ` Stephen Boyd
2023-01-31 6:35 ` Srinivasa Rao Mandadapu [this message]
2023-01-26 10:14 ` [PATCH v6 5/6] clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon Srinivasa Rao Mandadapu
2023-01-31 1:04 ` Stephen Boyd
2023-01-31 9:29 ` Srinivasa Rao Mandadapu
2023-01-31 20:26 ` Stephen Boyd
2023-02-01 7:07 ` Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 6/6] clk: qcom: lpassaudiocc-sc7280: Skip lpass_aon_cc_pll config Srinivasa Rao Mandadapu
2023-01-31 1:06 ` Stephen Boyd
2023-01-31 6:36 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4cc8f19-ff32-5bcb-14aa-1ced8143c202@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox