From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FB9B427A10; Thu, 14 May 2026 15:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778771582; cv=none; b=D3E69F9DJDY1FvUHiOigxLOvjMZP4GJGg/i+ybwTldWHsKxZeXEgn/jBCr5s95es3y6Un+yo4IJUO/uj8c7aPg6gT/D21xZ1gve50NxGoPkY1wEE8+dzbvYEcpBDsu+cFNvtPZs2IBTRSpn2RI0sXHW2eg2fydm6TY6Zzefvx08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778771582; c=relaxed/simple; bh=T3w7EbGZBz4D/NTzORTULk/LURVip4Ir6IuKTi2PPhY=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=iEvMXkrrxyK4oTPmMHR59pveiZktUUlYhCbcNo+4s8Ejv0mGWy53Oj4PxyNWCsMlklKbLwo5eH8lHZmwHBnfKPsdM7V8ehW46PWpghG9OoazyGirB0r0QmKwAdPOGLiAUQOgbNrRpYYEsNgaIRgJ5u8iTerqX3wPxssCVdwPbdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZTN6qAN2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZTN6qAN2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C7DC2BCB3; Thu, 14 May 2026 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778771581; bh=T3w7EbGZBz4D/NTzORTULk/LURVip4Ir6IuKTi2PPhY=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=ZTN6qAN20Zfdyryr7kFdWkmDWODIcx+vtMHa8wzdGn9RGUmaEOSZR8ZX6cBCdFbVE MAKlW3HZB3Yq/DlwnbGptjon3Axl3+NknKM776CorQz+9c1+oN0L+wZ80bHHcACkJz Y2C586wpky9K28LxYzvQPYn5PLDWBS4xqB4142W+rf+O0omTGBSXUz753YbP0zD1sv 2J4tFU68zRcSuS5bIgzcshhl/eL8HMRQrb5/iOXzjbTmp/1VDv7XGv36AJxzHZjBXK qQGbKixgTv49GM3Lq3/Xc9WlhIwlqb74lCXQOKmzIMnxVv5jZjWJs080IQ/SQY16/S i4YBk6VcZVZvw== Message-ID: Date: Thu, 14 May 2026 17:12:53 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: display: panel: Add Novatek NT37705 From: Krzysztof Kozlowski To: Luca Weiss , Conor Dooley Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260501-fp6-panel-v1-0-e09cb05651cc@fairphone.com> <20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com> <20260501-yogurt-wise-2a2884e3ec59@spud> <81a3c207-4d8f-490f-8e2a-6f3f4c2acd35@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <81a3c207-4d8f-490f-8e2a-6f3f4c2acd35@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/05/2026 17:11, Krzysztof Kozlowski wrote: > On 08/05/2026 09:44, Luca Weiss wrote: >> Hi Krzysztof, >> >> On Tue May 5, 2026 at 9:25 AM CEST, Krzysztof Kozlowski wrote: >>> On 05/05/2026 08:40, Luca Weiss wrote: >>>>>>>> + compatible: >>>>>>>> + contains: >>>>>>>> + const: boe,bj631jhm-t71-d900 >>>>>>> >>>>>>> Compatible doesn't match the filename, nor does the commit message match >>>>>>> what you've got here. Sounds like you're missing a fallback to >>>>>>> $filename. >>>>>> >>>>>> The last times I was upstreaming panel drivers (Feb 2024 and June 2025), >>>>>> this was the requested way of doing things. >>>>> >>>>> So this was requested that time and is requested now. What is here >>>>> uncertain? >>>>> >>>>>> >>>>>> Compatible being the company and model number making the actual panel >>>>>> assembly (driver IC + touchscreen + glass etc), while the rest being >>>>>> named after the driver IC manufacturer & number. >>>>> >>>>> So exactly what was asked for... >>>> >>>> I don't quite understand what is asked for now, that's my issue. >>>> >>>> 1. Change the filename to boe,bj631jhm-t71-d900.yaml and leave the rest >>>> as-is. >>>> >>>> 2. Add a fallback compatible for novatek,nt37705. IIRC last time it was >>>> argued that a "generic" nt37705 driver will never be correct for a >>>> specific panel since it's missing a bunch of panel-specific init. So >>>> that's why there should not be a fallback to nt37705. >>> >>> To my limited knowledge the (2) with fallback describing the specific IC >>> is preferred, because that compatible although not currently usable is >>> still specific and describes actual IC used. I imagine that such >>> fallback still could be useful to some SW implementation to determine >>> the IC and act based on that. >>> >>> If you have sources of other preference, please share, but I just gave >>> same review to Neil for his ayaneo,wt0600-2k panels. >> >> I found the discussion from 2024 for the Fairphone 4 panel: >> >> https://lore.kernel.org/lkml/f9164049-6529-42c1-a35a-e91132c823b9@linaro.org/ >> >> (quoting) >> >> ''' >> Not sure if "himax,hx83112a" is needed here, the "djn,9a-3r063-1102b" >> is enough to know the IC is hx83112a. >> >> I don't think you'll ever find a "djn,9a-3r063-1102b" with another >> controller IC ? >> >> And "himax,hx83112a" alone as fallback is not enough to describe the >> panel hardware, so I think it should be dropped. >> ''' >> >> With Konrad replying "+1" to that. > > The arguments from Linux drivers point of view are correct. And you can > apply the same to board-level compatibles. Each most-specific board > level compatible already defines the soc, thus soc-compatible fallback > is redundant, right? > > And also the soc-compatible fallback is too generic to be used alone by > the SW in many cases. > > Yet we use it. Same here. Why? For the same reasons as we use for > board-level compatibles. Because that's convenient way for defining > quirks for the controller IC which otherwise would need to match all > panel compatibles. > > I do not insist on this (for panels, of course), however I would prefer > consistency in the code and in the reviews. Heh, I bet you too would > prefer consistency. :) All my recent reviews were proposing to have the > fallback, thus I consistently propose one here, but I won't object for > the patch in current form, thus: > > Reviewed-by: Krzysztof Kozlowski > > But please also add Link to this exact email I am writing. > > ( Link: ....) Link: https://lore.kernel.org/r/81a3c207-4d8f-490f-8e2a-6f3f4c2acd35@kernel.org/ Best regards, Krzysztof