From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F312F5A1A for ; Thu, 29 Jan 2026 12:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689550; cv=none; b=EP/X9ULROCmDAlMfZ6ptiMRxhoHkTofq13XNJ7hTDNZ5O0bpMsLHtfRMXJCtBgOvImz6cCKkQxQetAqNlmwM8zR5mEtxU757bjF/zOwcqqIKRRrzqFnqH2gYtbaIXYWJqluULfI5+JxApJSR2BGrbvD6mNvX+TBL1r9Ui0MzwHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689550; c=relaxed/simple; bh=SLSpXRFms5PKk7pecOicO+UvyPTN8aa+jIBJ9HXDiB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=muXLs7Nvv15JAfacVO33czhzI+j/8/KG2cjekvBohbbMITnpoKb8HbU5fXe6wX7XVyTqq63n7THA41p8+AYsY9k15/9l6TTNaerMKivnE5fNZKXf0uGudRxBgYUJUGc8gXiRpfxW+Qs+pzdkZoFRrgsfLyOSMXk0/BriMIrSevc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NtmXpPkl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I55MKUC+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NtmXpPkl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I55MKUC+" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TAR5dl2504793 for ; Thu, 29 Jan 2026 12:25:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qob23DBD+bSq7eIQOQujBH/vod+svy0OVOZrvD7Jt/Q=; b=NtmXpPklguVlZPIJ PjezfJmv+cnx5gCqzgnX4AxxolNP0a14YEo2XefhypyikKaIJslezK2vgeIvii1q WEYCR6zFonIO54SUfdOgyS82npfXsppWlC/v4v3SVQiL5tlOv5f7KlAyHo4VEvnS rRVGZb94ggnkrMWXI+f8mwIhZPEAcLcfkX6odI6XFjxqNaG/AHiy8jV3jO7hBQ48 VeyI831yodY7bxf6ZlmCG9wxPcVh6S8EEx25HnhXuU+XDd/Ti4e10rS63QATltOj SK3ITQnS3a8ah6pBT7yFVef3fDc3xnH8wUgDNvrqecwVUd+RIkccevk2dMv+qzee Gv01bQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c05tbranu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 12:25:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c533f07450so28889185a.0 for ; Thu, 29 Jan 2026 04:25:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769689547; x=1770294347; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qob23DBD+bSq7eIQOQujBH/vod+svy0OVOZrvD7Jt/Q=; b=I55MKUC+zHAR+VBPIc/OGXuzpe86HQ3GDXncVpuKjvW/NG41SFZc3SOntXIXkmRWbZ yJNAI/QkJ4yKf1NYnwszdCmcrjhUoVmzD/wPlC0Oy9gsd/tgx03eVHF4TvZNKqnkbj5L SmIIP0tRZCPgLwqjvGhfP3NiGgFG3cRTRL17UjR5luikUbHIZlmOBc0Bp9A2fbByZB8f B25FeUORqENf87tZJx9GcXFLHcBG7nXDHUcZOts5flyN3nx06KFXA9qE4slSqxNU2AN8 B3HYAE8qv/XzY+sfJRvIYLUQ95rc+bIcuox0HzN85P+lGqfEvg7FZWJ6I7PuKbeU7z0L 9qUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769689547; x=1770294347; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qob23DBD+bSq7eIQOQujBH/vod+svy0OVOZrvD7Jt/Q=; b=q5ECzZbJeTktbseAdqhohAoo8OwmDhXgi0WRmskq22Vof1LwRh+j+yx3rXfQDhZJ19 0xbWioQtJTmEA9oZS+qPyf52epszpKDGvIF3BzKYM+sATDHXXJV56gcJD/FDP9Qf113O jTUjITLY4j1+L7wKuipsxJe5ZXgPJ+Z+dUz1Uq7zNlU3UUWix41rQEBt0vbnm7G3zPzP AaAHeA6JVubJwyi9sLP58JX/cUuZZO8g9wTWg/zo5YLXOkHwuM5t0P73BGRTST4e/EsM iMVIRXMkoGJ+4v/IgllWY1PHFHsDg53dS9pHke1jsvCA/os77nAHKhVLIvRaH3o+KhaA Jtfg== X-Forwarded-Encrypted: i=1; AJvYcCVy4EXvN+RdFTbkF8zWbr7to26bJokuXDU5W+Rs8EWYUgMrR/LWLamsO1nAzB4sM3MfkxsbU7iOGBpUvN+r@vger.kernel.org X-Gm-Message-State: AOJu0YzdsdrL6FZPxIeWPm7bZbeqynuVhaZjEUa9cWBlMQ9JFWAZEAPi WnAc6TNDkQjFoMWlS40DV8Pjj+hgTECaqIJXtjKK2gxlQ2PracnKSWCb74C7ihpzYdBid1zPJpt WQCusaLxxeqr+lXQyojSfmGK4+gtpmKtToCkPxI6vtfCgooEAO+IlirycqsKA7d8zrtK5 X-Gm-Gg: AZuq6aKXeJc7KDqdHF4Z8G5A4+fCnpACdEuGTRkuZCcbMkgdYX7cxKQiGvUUwpMoIiw ibU5URxi+eWrbl52eZTein9/jou7nNpXT7T8HVAvL9BDNiRhqVsEIztTAfpYyCN6/FJetPBt2FY eq2ZqS1Qp+7eSmaVCdX26auVpt5w5F0D8ajUWMVs8rv0xxV7XehM4LNfymb9M1iuu26tR092MRh raJJ7qC4Um1JhMaACnrIawPqBcV091tCm9EJCL3xA2ZlmJHsvgm5/h/PP6YMGE9nrXgzZlAtqjK VACkSnaPyym+FDt9OR5uWCQ8w7HViNItpnKoncDYF5IgTFIXojYy4NNg3VXdy3Ea3wc5D4pK3G7 yCkaCOSxgIq4w5rzM7wqZZ4x/Ksh8MSilnA2ac5xDWM05m3uUyaQfJQEYLYbAnpthq2g= X-Received: by 2002:a05:620a:4621:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c71adc0ae0mr369271185a.11.1769689547387; Thu, 29 Jan 2026 04:25:47 -0800 (PST) X-Received: by 2002:a05:620a:4621:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c71adc0ae0mr369268185a.11.1769689546930; Thu, 29 Jan 2026 04:25:46 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8debc6e956sm50055766b.64.2026.01.29.04.25.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 04:25:46 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 13:25:44 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: ipq9574: Enable eMMC variant To: Varadarajan Narayanan , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: sumit.garg@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com References: <20260129062825.666457-1-varadarajan.narayanan@oss.qualcomm.com> <20260129062825.666457-5-varadarajan.narayanan@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260129062825.666457-5-varadarajan.narayanan@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Zj57k_766UWubG7sZo6t7YO5mG_lUZIz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA4NCBTYWx0ZWRfX1PvZMt04xMXI hHFf3lzgvPV6znEEZN3lNXa/2gUCxO530PvscwzaT6hAPqlRVlmYgZquuHc8zLc751c3ZLFGl7p hLu7jsNv3FtFi0u/soNltwMqPWei8QJTg1WVLGL6DwqkO5m2HlN6Oe2lcpO5Gh15cSYmdI1UPD9 INrOnF1uxgR1/I79eRZVm9JKrgUdQ2eRg0896WVLBK+1rm4Ag9aLBZo1W+xn6Ocob8tX53gOJUj tw4sAmetyDe0O5o+89w1pJ9+zu4DuL061uaN/wDPNghAshJjovVqqmKxCMr9ez/ar589Gs2M1cb y0nJ9uBLj04ZgBBVBsKXKkjA+QTb3tRawqIIMU3SZfoGVokxPotnokMY3KMp1Fw2MFCGEVXECf5 sunKju4igZgv6aBSNWq3BixeRZXEb+1Lwv4/mW1/lau3wK3rcrX6PexuF/AG9r5qND5klZBdMWN OScB421f46/av0FlHlA== X-Proofpoint-ORIG-GUID: Zj57k_766UWubG7sZo6t7YO5mG_lUZIz X-Authority-Analysis: v=2.4 cv=betmkePB c=1 sm=1 tr=0 ts=697b51cb cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=vLnTREUV4GIbjpHtmtAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290084 On 1/29/26 7:28 AM, Varadarajan Narayanan wrote: > RDP433 can have NAND or eMMC based on a board level rework. Since the > same GPIOS are used for both the interfaces, only one of them can be > used. Add a new DTS file to disable NAND and enable eMMC. > > Signed-off-by: Varadarajan Narayanan > --- > v3: As qpic_nand is disabled in ipq9574-rdp-common.dtsi, no need to disable > it here. Just enable eMMC. > --- > arch/arm64/boot/dts/qcom/Makefile | 2 +- > .../boot/dts/qcom/ipq9574-rdp433-emmc.dts | 29 +++++++++++++++++++ > 2 files changed, 30 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 6f34d5ed331c..d5fe12ef4300 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -26,7 +26,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp418.dtb > -dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb ipq9574-rdp433-emmc.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp449.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > new file mode 100644 > index 000000000000..249b8e07db8f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > @@ -0,0 +1,29 @@ > +// SPDX-License-Identifier: BSD-3-Clause-Clear > +/* > + * IPQ9574 RDP433 (eMMC variant) board device tree source > + * > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +/dts-v1/; > + > +#include "ipq9574-rdp-common.dtsi" > +#include "ipq9574-rdp433-common.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C7 (eMMC)"; > + compatible = "qcom,ipq9574-ap-al02-c7-emmc", "qcom,ipq9574"; > +}; > + > +&sdhc_1 { > + pinctrl-0 = <&sdc_default_state>; > + pinctrl-names = "default"; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + max-frequency = <384000000>; These are all properties of the controller, which the mmc core later validates against the properties of the card, please move them to the SoC DTSI > + bus-width = <8>; This is arguably a property of the board, but in reality it's so common that it may as well reside in the SoC dtsi too I'm a little surprised to see no power supplies, are they always-on? Konrad